[No QA] Update Max lines limit for library modules by parasharrajat · Pull Request #73415 · Expensify/App

parasharrajat · 2025-10-24T10:43:35Z

Explanation of Change

Fixed Issues

$ #72804
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-10-24T10:43:41Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-10-24T10:44:06Z

@dukenv0307 We don't need C+ for this. Please pass over to Engineer.

DylanDylann · 2025-10-24T10:53:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

roryabraham · 2025-10-24T17:46:52Z

@parasharrajat I think we should to discuss this one in slack first. My original P/S was targeted specifically at IOU.ts, and while I personally think this is a good idea we should get buy-in from others first because it has the potential to be disruptive.

Also, why 4k lines? Is that the limit where syntax highlighting and git blame stops working?

parasharrajat · 2025-10-24T17:58:59Z

Also, why 4k lines? Is that the limit where syntax highlighting and git blame stops working?

Just sounds like a sweet spot. github will support more lines than that.

parasharrajat · 2025-10-24T19:10:25Z

Posted https://expensify.slack.com/archives/C08CZDJFJ77/p1761332557830229

parasharrajat · 2025-10-25T11:47:23Z

We got 6 👍 on the post. Should we proceed here @roryabraham?

parasharrajat · 2025-10-28T21:55:41Z

@roryabraham Can we go ahead with this?

roryabraham · 2025-10-28T22:08:44Z

Yes, thanks for posting in slack. Let's do it

parasharrajat · 2025-10-28T22:10:11Z

Let's merge this. We will work on refactoring PRs separately.

roryabraham · 2025-10-28T22:11:19Z

    },

+    {
+        files: ['src/libs/**/*.ts'],


@parasharrajat what about .tsx files?

Also, why only src/libs?

I'd think this should be everywhere, but ignoring only specific globs like .github/actions/javascript/**/index.js and `src/languages?

Let me check.

Here are all files in src

7361 ./src/languages/pt-BR.ts 7376 ./src/languages/de.ts 7383 ./src/languages/it.ts 7812 ./src/languages/es.ts 7202 ./src/languages/zh-hans.ts 7310 ./src/languages/en.ts 7378 ./src/languages/fr.ts 7358 ./src/languages/nl.ts 7346 ./src/languages/pl.ts 7309 ./src/languages/ja.ts 12615 ./src/libs/ReportUtils.ts 6256 ./src/libs/actions/Report.ts 14187 ./src/libs/actions/IOU.ts 6508 ./src/libs/actions/Policy/Policy.ts 7373 ./src/CONST/index.ts 5990 ./src/styles/index.ts 12163 ./src/NAICS.ts

I think we should only track the src folder. I will exclude languages. Do you have suggestions on exclusion?

@roryabraham What do you think?

Agree with excluding src/languages. We should also exclude NAICS.ts. Don't feel strongly one way or the other about CONST.ts 🤷🏼

codecov · 2025-11-07T20:37:05Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`75.08% <ø> (-0.07%)`	⬇️
src/libs/actions/IOU.ts	`64.40% <ø> (ø)`
src/libs/actions/Policy/Policy.ts	`33.77% <ø> (ø)`
src/libs/actions/Report.ts	`54.29% <ø> (ø)`
src/styles/index.ts	`45.10% <ø> (ø)`
... and 11 files with indirect coverage changes

OSBotify · 2025-11-10T20:24:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-11T12:43:13Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.49-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-11-11T13:32:00Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.49-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-11-11T18:58:38Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.52-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	failure ❌

OSBotify · 2025-11-12T15:50:26Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-12T22:19:52Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.52-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	failure ❌

Update Max lines limit for library modules

7d9242d

parasharrajat requested a review from a team as a code owner October 24, 2025 10:43

melvin-bot Bot assigned parasharrajat Oct 24, 2025

melvin-bot Bot requested review from dukenv0307 and removed request for a team October 24, 2025 10:43

DylanDylann approved these changes Oct 24, 2025

View reviewed changes

melvin-bot Bot requested a review from roryabraham October 24, 2025 10:53

Update rule

e291da6

roryabraham changed the title ~~[No QA] Update Max lines limit for library modules~~ [HOLD][No QA] Update Max lines limit for library modules Oct 24, 2025

Merge branch 'main' of github.com:Expensify/App into eslint-limit

a444854

parasharrajat changed the title ~~[HOLD][No QA] Update Max lines limit for library modules~~ [No QA] Update Max lines limit for library modules Oct 28, 2025

roryabraham reviewed Oct 28, 2025

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into eslint-limit

a33d5b3

parasharrajat requested a review from a team as a code owner November 7, 2025 20:18

melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 7, 2025 20:19

Update rule

0a6ca40

parasharrajat requested a review from a team as a code owner November 7, 2025 20:25

parasharrajat requested a review from roryabraham November 7, 2025 20:48

roryabraham approved these changes Nov 10, 2025

View reviewed changes

roryabraham merged commit df5bfb6 into Expensify:main Nov 10, 2025
26 checks passed

OSBotify mentioned this pull request Nov 11, 2025

Deploy Checklist: New Expensify 2025-11-11 #74800

Closed

58 tasks

melvin-bot Bot mentioned this pull request Nov 12, 2025

Break up src/libs/actions/IOU.ts #72804

Open

Conversation

parasharrajat commented Oct 24, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 24, 2025

Uh oh!

parasharrajat commented Oct 24, 2025

Uh oh!

DylanDylann commented Oct 24, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

roryabraham commented Oct 24, 2025

Uh oh!

parasharrajat commented Oct 24, 2025

Uh oh!

parasharrajat commented Oct 24, 2025

Uh oh!

parasharrajat commented Oct 25, 2025

Uh oh!

parasharrajat commented Oct 28, 2025

Uh oh!

roryabraham commented Oct 28, 2025

Uh oh!

parasharrajat commented Oct 28, 2025

Uh oh!

roryabraham Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Nov 7, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

OSBotify commented Nov 10, 2025

Uh oh!

OSBotify commented Nov 11, 2025

Uh oh!

OSBotify commented Nov 11, 2025

Uh oh!

OSBotify commented Nov 11, 2025

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

parasharrajat Oct 29, 2025 •

edited

Loading

codecov Bot commented Nov 7, 2025 •

edited by github-actions Bot

Loading