Skip to content

[CP Staging] Revert "Expense-After split expense preview displayed, in few seconds a confi…"#73856

Merged
Gonals merged 1 commit intomainfrom
revert-72730-fix/72415
Oct 30, 2025
Merged

[CP Staging] Revert "Expense-After split expense preview displayed, in few seconds a confi…"#73856
Gonals merged 1 commit intomainfrom
revert-72730-fix/72415

Conversation

@Gonals
Copy link
Contributor

@Gonals Gonals commented Oct 30, 2025

Reverts #72730

This caused a blocker: #73811

@Gonals Gonals self-assigned this Oct 30, 2025
@Gonals Gonals requested a review from a team as a code owner October 30, 2025 15:19
@melvin-bot melvin-bot bot requested review from MonilBhavsar and removed request for a team October 30, 2025 15:20
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2025

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov
Copy link

codecov bot commented Oct 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...ages/iou/request/step/IOURequestStepScan/index.tsx 0.00% <ø> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here.

@AndrewGable AndrewGable requested a review from a team October 30, 2025 15:55
@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team October 30, 2025 15:55
@AndrewGable AndrewGable removed the request for review from JmillsExpensify October 30, 2025 15:56
@AndrewGable
Copy link
Contributor

AndrewGable commented Oct 30, 2025

I was just testing the new product pr team, you can ignore the above @JmillsExpensify / @Gonals .

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73856.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/73856/index.html ⏩ SKIPPED ⏩
Android The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://73856.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@Gonals Gonals changed the title Revert "Expense-After split expense preview displayed, in few seconds a confi…" [CP Staging] Revert "Expense-After split expense preview displayed, in few seconds a confi…" Oct 30, 2025
NikkiWines
NikkiWines approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gonals Gonals merged commit d3a1ef2 into main Oct 30, 2025
27 of 31 checks passed
@Gonals Gonals deleted the revert-72730-fix/72415 branch October 30, 2025 16:50
@melvin-bot melvin-bot bot added the Emergency label Oct 30, 2025
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2025

@Gonals looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Gonals Gonals removed the Emergency label Oct 30, 2025
@Gonals
Copy link
Contributor Author

Gonals commented Oct 30, 2025

Straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Oct 30, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 30, 2025
@Gonals @OSBotify
Merge pull request #73856 from Expensify/revert-72730-fix/72415
152c4cf 
[CP Staging] Revert "Expense-After split expense preview displayed, in few seconds a confi…"

(cherry picked from commit d3a1ef2)

(cherry-picked to staging by puneetlath)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 30, 2025
@OSBotify OSBotify mentioned this pull request Oct 30, 2025
Closed
71 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Oct 30, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.41-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 31, 2025

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.41-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 31, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.42-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@JS00001 JS00001 JS00001 approved these changes

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@Gonals Gonals

Labels

CP Staging marks PRs that have been CP'd to staging Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gonals @AndrewGable @OSBotify @NikkiWines @JS00001