Bump `react-native-webview` to v13.16.0 by war-in · Pull Request #73930 · Expensify/App

war-in · 2025-10-31T15:12:51Z

Explanation of Change

Fixed Issues

$ #73883
$ #73902
$ #73909
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13759

Tests

Issue 1

Launch Hybrid app IOS
User logged in
Create a New Workspace
Navigate to More Feature >> Toggle On "Accounting"
Navigate to "Accounting" >> Tap "Connect" QBO
User should be directed to QBO connect page

Issue 2

Sign in to ND, enable use staging server
Create a workspace
Open Company cards page in the workspace settings
Tap Add Cards and select any bank - US for a location
Choose Direct feed as the connection method, tap Next
Tap American Express (Bank of America, Wells Fargo) tap Next
The bank modal opens

Issue 3

Open app
Type new email with a '+' in it and Join
At "What do you want to do today?" select option "Manage my team's expenses"
At "How many employees do you have?" select "1-10 employees"
Complete onboard flow with Skip "Take us for a test drive"
Tap on #Admin room
Tap on arrow of "Take a test drive"
Tap on "Take a quick product tour"
Test driving modal should display

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-10-31T15:13:09Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-10-31T15:15:17Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-31T15:24:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 56 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-10-31T15:25:26Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-31T16:00:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73930 Mobile-Expensify PR Expensify/Mobile-Expensify#13759.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/73930/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/73930/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/73930/NewExpensify.dmg	https://73930.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Ollyws · 2025-10-31T17:35:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android_Native_02.mov

Android_Native.mov

Android_Native_03.mov

Android: mWeb Chrome

Android_Chrome.mov

iOS: HybridApp

iOS_Native.mov

iOS_Native_03.mov

iOS_Native_02.mov

iOS: mWeb Safari

iOS_Safari.mov

MacOS: Chrome / Safari

MacOS_Chrome_02.mov

MacOS_Chrome.mov

MacOS: Desktop

MacOS_Desktop.mov

Ollyws

LGTM.

Bump `react-native-webview` to v13.16.0 (cherry picked from commit 9b8cd7a) (cherry-picked to staging by puneetlath)

OSBotify · 2025-10-31T18:32:42Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.41-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-31T21:18:09Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.41-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-31T21:49:14Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-03T22:42:27Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chore: update react-native-webview

b09e129

melvin-bot bot assigned war-in Oct 31, 2025

war-in marked this pull request as ready for review October 31, 2025 15:15

war-in requested a review from a team as a code owner October 31, 2025 15:15

melvin-bot bot requested review from Ollyws and removed request for a team October 31, 2025 15:15

puneetlath approved these changes Oct 31, 2025

View reviewed changes

Ollyws approved these changes Oct 31, 2025

View reviewed changes

melvin-bot bot requested a review from aldo-expensify October 31, 2025 17:44

puneetlath merged commit 9b8cd7a into Expensify:main Oct 31, 2025
37 checks passed

OSBotify pushed a commit that referenced this pull request Oct 31, 2025

Merge pull request #73930 from software-mansion-labs/war-in/bump-webview

a2fba36

Bump `react-native-webview` to v13.16.0 (cherry picked from commit 9b8cd7a) (cherry-picked to staging by puneetlath)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 31, 2025

OSBotify mentioned this pull request Oct 31, 2025

Deploy Checklist: New Expensify 2025-10-30 #73803

Closed

71 tasks

aldo-expensify mentioned this pull request Oct 31, 2025

iOS- Onboarding - Tap on Take a quick product tour, test driving modal not appear #73909

Closed

8 tasks

Ollyws mentioned this pull request Nov 18, 2025

[$250] Workspace - Blank page appear when user click Connect QBO #73883

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump `react-native-webview` to v13.16.0#73930

Bump `react-native-webview` to v13.16.0#73930
puneetlath merged 1 commit intoExpensify:mainfrom
software-mansion-labs:war-in/bump-webview

war-in commented Oct 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

melvin-bot bot commented Oct 31, 2025

Uh oh!

codecov bot commented Oct 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

Ollyws commented Oct 31, 2025

Uh oh!

Ollyws left a comment

Uh oh!

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

war-in commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

melvin-bot bot commented Oct 31, 2025

Uh oh!

codecov bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

Ollyws commented Oct 31, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

war-in commented Oct 31, 2025 •

edited

Loading

codecov bot commented Oct 31, 2025 •

edited

Loading