[CP Staging] Revert "refactor: isolate dismissDuplicateTransactionViolation from Onyx.connect data"

[tgolen]

Reverts #72955

Fixed issues

$ #74255

This PR needs reverted because it lead to a deploy blocker.

We changed the key format from just the transactionID to the full Onyx collection key (transaction_123), but the code in dismissDuplicateTransactionViolation()still expects the transactionID as the key.

The original collection for the violations is here and it was extracting transaction_ from the key in the collection. So allTransactionViolation was only keyed by the transactionID.

In the new code here, the collection is keyed by transaction_<transactionID>.

This causes the lookups here to fail.

cc @Skalakid

[melvin-bot]

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

LGTM 👍 Thank you for your hard work!

[codecov]

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/TransactionDuplicate/Review.tsx	0.00%	4 Missing ⚠️
src/libs/actions/Transaction.ts	0.00%	3 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/actions/Transaction.ts	46.88% <0.00%> (-11.93%)	⬇️
src/pages/TransactionDuplicate/Review.tsx	0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[luacmartins]

Straight revert, merging without checklists

[melvin-bot]

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.44-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[Julesssss]

Requested a retest here

[Julesssss]

This revert resolved the linked issue, I checked both off the checklist

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅