Adjust padding in new `SelectionList` by zfurtak · Pull Request #74362 · Expensify/App

zfurtak · 2025-11-05T17:29:14Z

Explanation of Change

Fixed Issues

$ #74155 (and SelectionList migration issue)
PROPOSAL:

Tests

Go to Workspaces
Choose your workspace
Go to Reports -> and Add field
Create one with list type
Add many values to the list so it's scrollable
Click Initial value
Verify that list items doesn't appear behind navigation buttons.

Verify that no errors appear in the JS console

Offline tests

QA Steps

as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

screen-20251106-135304.mp4

Android: mWeb Chrome

screen-20251106-135638.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

codecov · 2025-11-06T10:03:04Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/SelectionList/BaseSelectionList.tsx	`55.23% <100.00%> (-2.00%)`	⬇️
...es/OnboardingEmployees/BaseOnboardingEmployees.tsx	`95.65% <ø> (ø)`
... and 169 files with indirect coverage changes

blazejkustra

One prop less 🤌🇮🇹🍝 Bellissimo

melvin-bot · 2025-11-06T14:09:17Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-11-06T14:11:18Z

+    const paddingBottomStyle = useMemo(() => !isKeyboardShown && safeAreaPaddingBottomStyle, [isKeyboardShown, safeAreaPaddingBottomStyle]);
+
+    const hasFooter = footerContent ?? confirmButtonConfig?.showButton;



❌ PERF-6 (docs)

This value derivation should be wrapped in useMemo with specific property dependencies to prevent unnecessary recalculations when unrelated confirmButtonConfig properties change.

Suggested fix:

const hasFooter = useMemo(() => footerContent ?? confirmButtonConfig?.showButton, [footerContent, confirmButtonConfig?.showButton]);

I think it's fine. Not much performance benefit

aimane-chnaif · 2025-11-06T14:20:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

JmillsExpensify

No PR review required from a product perspective. Unsubscribing.

OSBotify · 2025-11-11T12:43:46Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.49-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-11-11T13:32:33Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.49-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-11-11T18:59:11Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.52-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	failure ❌

OSBotify · 2025-11-12T15:50:59Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-12T22:20:25Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.52-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	failure ❌

Fix safe padding

07f6812

melvin-bot Bot assigned zfurtak Nov 5, 2025

zfurtak added 2 commits November 5, 2025 18:31

Fix lint

1f76b8f

Fix lint

fe78a32

zfurtak changed the title ~~Adjust padding in new SelectionList and fix it in ReportFieldsListValuesPage~~ Adjust padding in new SelectionList Nov 6, 2025

Merge branch 'main' into @zfurtak/fix-padding

18390df

Revert change

b6d2ba8

blazejkustra approved these changes Nov 6, 2025

View reviewed changes

zfurtak marked this pull request as ready for review November 6, 2025 14:09

zfurtak requested review from a team as code owners November 6, 2025 14:09

melvin-bot Bot requested a review from aimane-chnaif November 6, 2025 14:09

melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 6, 2025 14:09

github-actions Bot reviewed Nov 6, 2025

View reviewed changes

aimane-chnaif reviewed Nov 7, 2025

View reviewed changes

Comment thread src/components/SelectionList/BaseSelectionList.tsx Outdated

JmillsExpensify reviewed Nov 7, 2025

View reviewed changes

aimane-chnaif approved these changes Nov 7, 2025

View reviewed changes

melvin-bot Bot requested a review from srikarparsi November 7, 2025 15:17

Adjust to review

56087c6

srikarparsi approved these changes Nov 11, 2025

View reviewed changes

srikarparsi merged commit 1e2c61e into Expensify:main Nov 11, 2025
26 checks passed

OSBotify mentioned this pull request Nov 11, 2025

Deploy Checklist: New Expensify 2025-11-11 #74800

Closed

58 tasks

melvin-bot Bot mentioned this pull request Nov 12, 2025

[WAITING ON CHECKLIST] [$250] Android - Reports - Initial values overlap navigation bar #74155

Closed

8 tasks

		const paddingBottomStyle = useMemo(() => !isKeyboardShown && safeAreaPaddingBottomStyle, [isKeyboardShown, safeAreaPaddingBottomStyle]);

		const hasFooter = footerContent ?? confirmButtonConfig?.showButton;

Conversation

zfurtak commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Nov 6, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Nov 6, 2025

Uh oh!

github-actions Bot Nov 6, 2025

Choose a reason for hiding this comment

❌ PERF-6 (docs)

Uh oh!

aimane-chnaif Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 11, 2025

Uh oh!

OSBotify commented Nov 11, 2025

Uh oh!

OSBotify commented Nov 11, 2025

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zfurtak commented Nov 5, 2025 •

edited

Loading

codecov Bot commented Nov 6, 2025 •

edited by github-actions Bot

Loading

aimane-chnaif commented Nov 6, 2025 •

edited

Loading