[HOLD][ASAP-Submit] Update expense reports Next Steps for retracted reports in Auto-Submit workspaces.#75155
[HOLD][ASAP-Submit] Update expense reports Next Steps for retracted reports in Auto-Submit workspaces.#75155Krishna2323 wants to merge 8 commits intoExpensify:mainfrom
Conversation
… in Auto-Submit workspaces. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@MarioExpensify have you added the account to the beta? I can’t test the changes online. |
|
Sorry @Krishna2323, I was sure I added 🤦 Just added it. |
|
Hey @rojiphil, I’m facing an issue while testing. Could you please check if I’m doing something wrong or if there’s an issue with my account? Thanks! Monosnap.screencast.2025-11-21.14-30-43.mp4 |
|
I will retry online testing today. @rojiphil could you please take a look at the comment above when you get a chance? Thanks! |
|
@Krishna2323 Is this PR still relevant? If not, curious if we can close the PR. |
|
@rojiphil @Krishna2323 this is put on HOLD indefinitely for now, I'll check how we would handle your compensation for it and circle back here. |
Explanation of Change
Retracted reports will not auto-submit, so we’ll update the Next steps (see buildNextStep) to “Waiting for to submit these expense(s).“
Fixed Issues
$ #63197
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop