Show the CREATED report action when the expense report was created during harvest#75511
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…y; pass reportNameValuePairs to payload
…ions for harvestCreatedExpenseReport in all major languages
…nd update translations
- Add test to verify correct message generation with valid report ID - Include required imports (getEnvironmentURL and ROUTES) - Test validates proper URL and reportID interpolation in translation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
ESLint failure is not related to this PR. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Replace deepEqual with shallow comparison for reportNameValuePairs - Add reportNameValuePairs to renderItem dependency array - Compare only relevant properties (origin and originalID) to avoid deep equality overhead
| reportAction: { | ||
| asCopilot: 'als Co-Pilot für', | ||
| harvestCreatedExpenseReport: ({reportUrl, reportID}: HarvestCreatedExpenseReportParams) => | ||
| `hat diesen Bericht erstellt, um alle Ausgaben aus <a href="${reportUrl}">#${reportID}</a> aufzunehmen, die mit der von dir gewählten Frequenz nicht eingereicht werden konnten`, |
There was a problem hiding this comment.
You need to use the generated report Name for this reportID part.
const reportName = getReportName(report) ?? report?.reportName ?? '';
There was a problem hiding this comment.
Oops. The copy is saying #reportID, thought? #74580 (comment)
There was a problem hiding this comment.
I think it is a simple mistake, this should be report name link. following other messages.
|
|
||
| type HarvestCreatedExpenseReportParams = { | ||
| reportUrl: string; | ||
| reportID: string; |
There was a problem hiding this comment.
| reportID: string; | |
| reportName: string; |
| prevProps.reportNameValuePairs?.origin === nextProps.reportNameValuePairs?.origin && | ||
| prevProps.reportNameValuePairs?.originalID === nextProps.reportNameValuePairs?.originalID |
There was a problem hiding this comment.
It is better to pass origin and originalID as params to the component instead of reportNameValuePairs otherwise this will create bugs in future.
There was a problem hiding this comment.
I prefer to pass the whole reportNameValuePairs so we can reuse it somewhere later. Hmm, do you think I should use deepEqual here?
There was a problem hiding this comment.
This check is good as lightweight than comparing the whole object but exactly for the reason you mentioned someone may depend on reportNameValuePairs prop without thinking that we only compare two properties from it causing a bug.
Another reason is that we should only pass necessary props if we need more in the future, we can update it at that time.
There was a problem hiding this comment.
Agreed. But I need reportNameValuePairs to check harvestCreatedExpenseReport here
There was a problem hiding this comment.
Actually you need originalID and origin in those functions so we can Just pass those instead of whole object.
There was a problem hiding this comment.
okay. So do you mean those funcs (I.e harvestCreatedExpenseReport here) will receive originalID and origin as params instead of reportNameValuePairs?
| return <ReportActionItemGrouped wrapperStyle={isWhisper ? styles.pt1 : {}}>{content}</ReportActionItemGrouped>; | ||
| }; | ||
| if (action.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED) { | ||
| if (action.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED && !isHarvestCreatedExpenseReport) { |
There was a problem hiding this comment.
This does not look right.
There was a problem hiding this comment.
This created view is necessary IMO.
There was a problem hiding this comment.
Can you elaborate on your opinion? It makes the view broken if I revert this change
There was a problem hiding this comment.
This component renders some part of the UI so if hid this, won't it change the UI.
|
@hoangzinh Can you add me to the workspace you are harvested so that I can test this? |
|
@hoangzinh yes, put the device offline first. |
|
@parasharrajat, given with my testing result here, do you think my investigation here is correct? (too many here) |
|
@hoangzinh can you hide the join thread button as well? 
|
Screenshots🔲 iOS / native14.12.2025_14.57.07_REC.mp4🔲 iOS / Safari14.12.2025_15.06.40_REC.mp4🔲 MacOS / Chrome
🔲 Android / Chrome14.12.2025_15.37.31_REC.mp4🔲 Android / native14.12.2025_15.35.12_REC.mp4 |
- Add isHarvestReport parameter to joinThread shouldShow function - Check if action is harvest created expense report - Prevent showing join thread for harvest reports to maintain consistency with leave thread behavior
@parasharrajat I updated in this commit c215ffd |
|
@cristipaval Looks like there is some backend bug which duplicates the expense in harvested report. I have this report 509955657650749 which was havested on 9th Dec, It should have only one expense but the I see 6 copies of same expense. 14.12.2025_14.30.36_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
cristipaval
left a comment
cristipaval
left a comment
There was a problem hiding this comment.
Thank you both for the hard work on this one! 🙏
|
@hoangzinh could you please look into the failing check? |
It also happens on main branch. Anw, I just tried to merge latest main, hopefully it will fix it |
|
@cristipaval I'm curious how the QA team can test this PR if the internal tool, which triggers the harvest report, is having an issue. |
|
@hoangzinh We can ask them to set the Submission Frequency to Daily and ask them to wait for a day. Or we can ask them to use accounts that already have reports with moved expenses during the harvest. They should have such accounts and we can also help them with that. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.79-0 🚀
|
|
@cristipaval could you please manually trigger the harvest report? The tester used this account unzig.test+1712harvest@gmail.com |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.81-0 🚀
|
Done, @nlemma |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
8 participants
Explanation of Change
Follow this design doc #74580 (comment)
Fixed Issues
$ #74580
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisite:
Test steps:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-11-20.at.22.37.43.android.mov
Android: mWeb Chrome
Screen.Recording.2025-11-20.at.22.45.07.android.chrome.mov
iOS: Native
Screen.Recording.2025-11-20.at.22.47.58.mov
iOS: mWeb Safari
Screen.Recording.2025-11-20.at.22.46.12.ios.safari.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-20.at.22.23.37.web.mov
MacOS: Desktop
Screen.Recording.2025-11-20.at.22.32.42.desktop.mov