-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[DEW]: Update SubmitReport API command
#75712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
SubmitReport API command
SubmitReport API commandSubmitReport API command
|
translation confirmation was requested here: https://expensify.slack.com/archives/C01GTK53T8Q/p1763725986769179 |
…Page for performance improvement
bernhardoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the offline case. The queued message is still shown when going online, but I think if we really want to fix this, we should first remove the Onyx.connect usage for the last action and then revisit this, but that's for another issue.
web.offline.mp4
We can merge this for now.
francoisl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this!!
|
Hmm Github is telling me some commits are not signed, so it won't let me merge because they're required at the repo level. The GH UI isn't loading all commit details on the /commits page, I'll check on the command line. |
|
Those are the unsigned commits it looks like: |
d5ffd39 to
ca67273
Compare
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.2.95-0 🚀
|
|
Hi @abzokhattab We can use our Expensifail accounts for testing this PR and no need special settings in a Workspace, right?
|
|
Can you tell me what account you're testing from? I'll need to enable something on that account first. |
|
@francoisl There are accounts for testing the PR: |
|
Let me know when it's done. Thank you in advance |
|
Ok I enabled it on these policies so you should be able to test with those:
It doesn't look like the account applausetester+ndk80@applause.expensifail.com exists though. Let me know if you need to use any other account |
|
@francoisl Could you please enable it in this account applausetester+ndk74@applause.expensifail.com as well? Thank you |
|
Done! (policy 4DF895B89CD9CF90) |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.95-5 🚀
|
Explanation of Change
Add support for Dynamic External Workflow (DEW) in the report submission flow.
Key Changes:
Fixed Issues
$ #75222
PROPOSAL:
Tests
Prerequisites:
Test 1: Submit Success - Online
Test 2: Submit Success - Offline → Online
Test 3: Submit Failed
RBR in LHN
submitOffline tests
Waiting for you to come back online to determine next stepsviewnotsubmitQA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-11-27.at.00.22.59.mov
Android: mWeb Chrome
Screen.Recording.2025-11-26.at.23.46.27.mov
iOS: Native
Screen.Recording.2025-11-26.at.23.34.28.mov
iOS: mWeb Safari
Screen.Recording.2025-11-26.at.23.36.50.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-26.at.23.13.16.mov
Screen.Recording.2025-11-26.at.23.23.00.mov
Screen.Recording.2025-11-26.at.23.30.08.mov
Screen.Recording.2025-12-02.at.21.18.46.mov