Skip to content

Make NetSuiteCustomListSelectorModal use new SelectionList #75906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grgia merged 5 commits into from
Dec 1, 2025
Merged

Make NetSuiteCustomListSelectorModal use new SelectionList #75906

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18b5104
Make NetSuiteCustomListSelectorModal use new SelectionList
OlGierd03 Nov 24, 2025
15d4f57
Remove unnecessary use of spreading an array
OlGierd03 Nov 26, 2025
9a9fbc0
Applied suggested fix of the inverted headerMessage logic bug
OlGierd03 Nov 26, 2025
4bcbb21
Extract the rawCustomLists variable outside the useMemo
OlGierd03 Nov 26, 2025
7feacee
Merge branch 'main' into @OlGierd03/migrate-NetSuiteCustomListSelecto…
OlGierd03 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions ...counting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomListSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import React, {useMemo} from 'react';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import Modal from '@components/Modal';
import ScreenWrapper from '@components/ScreenWrapper';
import SelectionList from '@components/SelectionListWithSections';
import RadioListItem from '@components/SelectionListWithSections/RadioListItem';
import SelectionList from '@components/SelectionList';
import RadioListItem from '@components/SelectionList/ListItem/RadioListItem';
import useDebouncedState from '@hooks/useDebouncedState';
import useLocalize from '@hooks/useLocalize';
import type {CustomListSelectorType} from '@pages/workspace/accounting/netsuite/types';
Expand Down Expand Up @@ -37,8 +37,10 @@ function NetSuiteCustomListSelectorModal({isVisible, currentCustomListValue, onC
const {translate} = useLocalize();
const [searchValue, debouncedSearchValue, setSearchValue] = useDebouncedState('');

const {sections, headerMessage, showTextInput} = useMemo(() => {
const customLists = policy?.connections?.netsuite?.options?.data?.customLists ?? [];
const rawCustomLists = policy?.connections?.netsuite?.options?.data?.customLists;

const {options, showTextInput} = useMemo(() => {
const customLists = rawCustomLists ?? [];
const customListData = customLists.map((customListRecord) => ({
text: customListRecord.name,
value: customListRecord.name,
Expand All @@ -52,17 +54,20 @@ function NetSuiteCustomListSelectorModal({isVisible, currentCustomListValue, onC
const isEmpty = debouncedSearchValue.trim() && !filteredCustomLists.length;

return {
sections: isEmpty
? []
: [
{
data: filteredCustomLists,
},
],
headerMessage: isEmpty ? translate('common.noResultsFound') : '',
options: isEmpty ? [] : filteredCustomLists,
showTextInput: customListData.length > CONST.STANDARD_LIST_ITEM_LIMIT,
};
}, [debouncedSearchValue, policy?.connections?.netsuite?.options?.data?.customLists, translate, currentCustomListValue]);
}, [debouncedSearchValue, rawCustomLists, currentCustomListValue]);

const textInputOptions = useMemo(
() => ({
value: searchValue,
label: showTextInput ? translate('common.search') : undefined,
onChangeText: setSearchValue,
headerMessage: debouncedSearchValue.trim() && options.length === 0 ? translate('common.noResultsFound') : '',
}),
[searchValue, showTextInput, translate, setSearchValue, debouncedSearchValue, options.length],
);

return (
<Modal
Expand All @@ -84,17 +89,13 @@ function NetSuiteCustomListSelectorModal({isVisible, currentCustomListValue, onC
onBackButtonPress={onClose}
/>
<SelectionList
sections={sections}
textInputValue={searchValue}
textInputLabel={showTextInput ? translate('common.search') : undefined}
onChangeText={setSearchValue}
data={options}
textInputOptions={textInputOptions}
onSelectRow={onCustomListSelected}
headerMessage={headerMessage}
ListItem={RadioListItem}
initiallyFocusedOptionKey={currentCustomListValue}
initiallyFocusedItemKey={currentCustomListValue}
shouldSingleExecuteRowSelect
shouldStopPropagation
shouldUseDynamicMaxToRenderPerBatch
addBottomSafeAreaPadding
/>
</ScreenWrapper>
Expand Down
Loading