fix: No message that expense is on hold when split expense offline #75980

paulnjs · 2025-11-25T08:15:59Z

Explanation of Change

Fixed Issues

$#74682
PROPOSAL:#74682 (comment)

Tests

Open the app
Create expense in workspace chat
Open expense thread
Go offline
Hold the expense
Split the expense
Verify there is a system message that expenses are put on hold in each expense thread

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Create expense in workspace chat
Open expense thread
Go offline
Hold the expense
Split the expense
Verify there is a system message that expenses are put on hold in each expense thread

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

chorme.mov

… msg offline

github-actions · 2025-11-25T08:16:08Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2025-11-25T08:24:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/index.ts	`66.27% <91.66%> (+0.24%)`	⬆️
... and 5 files with indirect coverage changes

melvin-bot · 2025-11-25T08:59:10Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2025-11-25T11:08:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-02.at.8.09.43.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-02.at.8.14.03.PM.mov

iOS: HybridApp

Screen.Recording.2025-12-02.at.8.09.17.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-02.at.8.14.35.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-02.at.7.54.05.PM.mov

eh2077 · 2025-11-25T11:41:12Z

@paulnjs I think we'll also need backend fix for the issue. Can you help comment in the parent issue to answer the following questions?

### What is the expected behavior of the backend?

### What is the actual behavior of the backend?

### What data are you passing to the backend?

### What data is the backend returning?

### What data do you think the backend should be returning?

BE issue: transaction thread has duplicate hold message.

Staging

Screen.Recording.2025-11-25.at.7.47.01.PM.mov

This PR

Screen.Recording.2025-11-25.at.7.26.33.PM.mov

eh2077 · 2025-11-25T12:01:03Z

@paulnjs In this PR, I think we should align offline behavior with BE - show on hold messages in transaction thread.

trjExpensify

This PR doesn't look right to me. When you split a held expense:

The "child" expenses should inherit the held status
The hold system message and reason should be inside each of the transaction threads of the held expense.

It looks like that largely works on staging:

2025-11-25_12-49-05.mp4

The only bugs appear to be:

A duplicate hold reason in the transaction thread on being split. (@lakchote is fixing that in the BE in this PR)
The expense previews in the report preview component says "Review required" instead of "This expense was put on hold." even though that message appears to be within the character limit to show 🤔

eh2077 · 2025-11-25T15:39:31Z

@trjExpensify Thanks for the review! I agree all you mentioned, just one more offline issue - no hold system message and reason in transaction threads, see #75980 (comment)

trjExpensify · 2025-11-25T16:22:45Z

As in, copying the message to the child split expense threads when offline doesn't happen? Only when you come back online, do they appear?

eh2077 · 2025-11-25T16:33:43Z

As in, copying the message to the child split expense threads when offline doesn't happen? Only when you come back online, do they appear?

Yes, that's right, see staging video from #75980 (comment)

eh2077 · 2025-11-26T15:15:32Z

@paulnjs Friendly bump

paulnjs · 2025-11-26T15:20:04Z

@eh2077 Ya, i'm investigating. I will ping you when it's done

paulnjs · 2025-11-27T12:17:27Z

@trjExpensify @eh2077 After testing more cases, I realized that BE will duplicate all messages from original expense to the split expenses, not just the hold system message or hold reason. Then duplicate the violation for each expense. If we want to create all messages for the split expenses optimistically, we need to pass all new actionIDs to BE. Is it possible?

eh2077 · 2025-11-27T12:30:49Z

@paulnjs Do you mean we need BE change? If so, can you sort out following things?

what API endpoint?
what changes does the current API endpoint need?
what is currently returned?
what should be returned and why?

paulnjs · 2025-11-28T04:49:21Z

@eh2077

what API endpoint?

 It’s Transaction_Split API

what changes does the current API endpoint need?

On BE side, we will duplicate all messages from original expense to the split expenses, so if we want to do that optimistically, we have to generate the new reportActionIDs for each split expense in FE side. That means we need to pass them to the payload of Transaction_Split API

what is currently returned?
what should be returned and why?

BE is returning the reportActions for each split correctly. What we need to do now is to generate the actions optimistically and pass them to BE.

lakchote · 2025-11-28T15:12:45Z

@paulnjs you can provide the optimistic hold report action ID and hold report action comment:

holdReportActionID[i]
holdReportActionCommentID[i]

where i is the split index (0, 1, 2, etc.).

For copied user comments, I recommend letting those sync from the server response rather than passing optimistic IDs - the complexity and race condition risks outweigh the UX benefit.

If someone adds a comment to the original thread between when FE reads the number of comments and when the split executes, the ID mapping breaks. Comments added while offline would be missed. FE would need to know exactly how many comments exist before splitting. This data can easily be stale.

Also it's different from hold actions, hold status directly affects what actions are available on the expense (can't submit, shows warning, etc). That's worth optimistic updates. Copied comments are just informational.

paulnjs · 2025-12-01T15:06:39Z

@lakchote This is what I see in the Transaction_Split API, the format is split[i][field] so I think it should be

split[i]holdReportActionID
split[i]holdReportActionCommentID

Could you help to confirm? And did BE handle this?

lakchote · 2025-12-01T15:22:44Z

@paulnjs, yes, this is correct. BE handles these params already.

MarioExpensify

Awesome, thank you @paulnjs

MarioExpensify · 2025-12-29T21:46:52Z

@lakchote is ooo until Jan 2nd, we'll be able to merge once we get his approval.

lakchote

LGTM, waiting for your approval now @trjExpensify

trjExpensify

👍

trjExpensify · 2026-01-05T15:59:54Z

Thanks for the bump, @lakchote. Good to merge!

OSBotify · 2026-01-07T14:00:17Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.95-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

This reverts commit d382b9a, reversing changes made to e219999.

[CP Staging] Revert "Merge pull request #75980 from paulnjs/paulnjs-fix/74682"

[CP Staging] Revert "Merge pull request #75980 from paulnjs/paulnjs-fix/74682" (cherry picked from commit edc85de) (cherry-picked to staging by mountiny)

lakchote · 2026-01-07T16:52:02Z

Reverted as it caused a blocker: #79004

cc @trjExpensify @eh2077 @MarioExpensify

* main: (267 commits) Update Mobile-Expensify submodule version to 9.2.95-2 Update version to 9.2.95-2 revert 6020367 fix wrong messages Update Mobile-Expensify submodule version to 9.2.95-1 Update version to 9.2.95-1 Revert "Merge pull request #75980 from paulnjs/paulnjs-fix/74682" fix for taxes Update Mobile-Expensify submodule version to 9.2.95-0 Update version to 9.2.95-0 Remove expense type from the amount row label in MoneyRequestView Prettier fix Fix after merge Add translations fix: remove redundant change fix iOS crash when attempting to insert an empty buffer fix: extract onPress handler to useCallback in ApprovalWorkflowEditor fixing long email displayed in the approver description fix: typecheck - category Revert changes in NumberWithSymbolForm ... # Conflicts: # src/languages/de.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts

OSBotify · 2026-01-08T15:27:33Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.95-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-08T16:48:01Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.96-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T18:17:00Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-09T19:13:22Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T19:20:18Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T20:00:43Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

kavimuru · 2026-01-10T01:31:44Z

Failing on iOS and Android with original bug id #74682

https://platform.applause.com/services/links/v1/external/fe59daa5c436eb60dc1055cab6eff67e4db2d90a88d2001c9ad155fde8b65f5d
https://platform.applause.com/services/links/v1/external/21ebb01ea90543072ab107b7423f13ee0eecfb8c5d3ae90af5d8da93bd77b0e1

OSBotify · 2026-01-10T02:19:49Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Expense preview not show paid tag and thread message is shown as…

ed66729

… msg offline

melvin-bot bot assigned paulnjs Nov 25, 2025

update code

87be81c

fix lint

a0ba127

paulnjs marked this pull request as ready for review November 25, 2025 08:59

paulnjs requested review from a team as code owners November 25, 2025 08:59

melvin-bot bot requested review from eh2077 and removed request for a team November 25, 2025 08:59

melvin-bot bot requested review from trjExpensify and removed request for a team November 25, 2025 08:59

trjExpensify requested changes Nov 25, 2025

View reviewed changes

Merge branch 'main' into paulnjs-fix/74682

21858df

MarioExpensify approved these changes Dec 29, 2025

View reviewed changes

lakchote approved these changes Jan 5, 2026

View reviewed changes

trjExpensify approved these changes Jan 5, 2026

View reviewed changes

lakchote merged commit d382b9a into Expensify:main Jan 6, 2026
33 checks passed

This was referenced Jan 6, 2026

Investigate workflow job failing on main: typecheck / typecheck #78909

Closed

[Due for payment 2026-01-15] Investigate workflow job failing on main: test / test (job 2) #78910

Closed

lakchote mentioned this pull request Jan 6, 2026

Revert "fix: No message that expense is on hold when split expense offline" #78911

Closed

situchan mentioned this pull request Jan 6, 2026

[No QA] Remove desktop from checklist and build process #78912

Merged

54 tasks

OSBotify mentioned this pull request Jan 7, 2026

Deploy Checklist: New Expensify 2026-01-07 #78997

Closed

54 tasks

lanitochka17 mentioned this pull request Jan 7, 2026

Expense - Hold action and reason message appear twice after splitting held expense #79004

Closed

7 tasks

lakchote added a commit that referenced this pull request Jan 7, 2026

Revert "Merge pull request #75980 from paulnjs/paulnjs-fix/74682"

fa9d53a

This reverts commit d382b9a, reversing changes made to e219999.

lakchote mentioned this pull request Jan 7, 2026

[CP Staging] Revert "Merge pull request #75980 from paulnjs/paulnjs-fix/74682" #79009

Merged

58 tasks

Beamanator added a commit that referenced this pull request Jan 7, 2026

Merge pull request #79009 from Expensify/lucien/revert-pr-75980

edc85de

[CP Staging] Revert "Merge pull request #75980 from paulnjs/paulnjs-fix/74682"

paulnjs mentioned this pull request Jan 8, 2026

fix: No message that expense is on hold when split expense offline #79078

Draft

53 tasks

melvin-bot bot mentioned this pull request Jan 8, 2026

[Due for payment 2026-01-16] [Due for payment 2026-01-15] [$250] Expense - No message that expense is on hold when split expense offline #74682

Open

8 tasks

OSBotify mentioned this pull request Jan 9, 2026

Deploy Checklist: New Expensify 2026-01-09 #79227

Open

60 tasks

fix: No message that expense is on hold when split expense offline #75980

fix: No message that expense is on hold when split expense offline #75980

Conversation

paulnjs commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

codecov bot commented Nov 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 25, 2025

Uh oh!

eh2077 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Staging

This PR

Uh oh!

eh2077 commented Nov 25, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Nov 25, 2025

Uh oh!

trjExpensify commented Nov 25, 2025

Uh oh!

eh2077 commented Nov 25, 2025

Uh oh!

eh2077 commented Nov 26, 2025

Uh oh!

paulnjs commented Nov 26, 2025

Uh oh!

paulnjs commented Nov 27, 2025

Uh oh!

eh2077 commented Nov 27, 2025

Uh oh!

paulnjs commented Nov 28, 2025

Uh oh!

lakchote commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulnjs commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarioExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

MarioExpensify commented Dec 29, 2025

Uh oh!

lakchote left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Jan 5, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

lakchote commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

paulnjs commented Nov 25, 2025 •

edited

Loading

codecov bot commented Nov 25, 2025 •

edited by github-actions bot

Loading

eh2077 commented Nov 25, 2025 •

edited

Loading

eh2077 commented Nov 25, 2025 •

edited

Loading

lakchote commented Nov 28, 2025 •

edited

Loading

paulnjs commented Dec 1, 2025 •

edited

Loading

lakchote commented Dec 1, 2025 •

edited

Loading

lakchote left a comment •

edited

Loading

lakchote commented Jan 7, 2026 •

edited

Loading