Allow admin to create report on behalf of employee #76000

s77rt · 2025-11-25T10:28:55Z

Explanation of Change

Fixed Issues

$ #75607
PROPOSAL:

Tests

Requires 2 accounts, an admin and an employee
Employee have assigned an E-Card.

Employee: Have an unreported card expense
Admin: Open ND and go to Reports > Unapproved card
Admin: In Status filter select Unreported then click Apply
Admin: Find the employee expense and select it
Admin: Click on green button at the top and choose Move expense
Admin: Choose Create report
Admin: Verify the expense is no longer displayed
Admin: In Status filter select Draft and Outstanding then click Apply
Admin: Verify the expense is now displayed
Employee: Open policy expense chat and verify that a new report was created and it contains your expense

Screen.Recording.2026-01-13.at.3.36.02.PM.mov

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2025-11-25T10:38:07Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Search/index.tsx	`35.41% <ø> (ø)`
...es/iou/request/step/IOURequestEditReportCommon.tsx	`76.38% <100.00%> (ø)`
src/libs/ReportUtils.ts	`72.02% <50.00%> (+0.05%)`	⬆️
src/libs/actions/Report.ts	`53.62% <50.00%> (ø)`
...rc/pages/iou/request/step/IOURequestEditReport.tsx	`0.00% <0.00%> (ø)`
...rc/pages/Search/SearchTransactionsChangeReport.tsx	`0.00% <0.00%> (ø)`
...rc/pages/iou/request/step/IOURequestStepReport.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

src/libs/ReportUtils.ts

s77rt · 2026-01-21T18:27:59Z

@DylanDylann

When moving the expense to new report, It only creates new report but doesn;t move the expense to new report

I think this is broken on main too? It seems that the transactions data that we get from onyx is for an old searchHash so we end up using a snapshot data that does not include the transactions. This is partially caused by #79462

s77rt · 2026-01-21T18:29:01Z

Do we need to update the optimistic data to make it work offline?

This should already work offline as I'm not adding new actions that would create new outcome.

s77rt · 2026-01-21T18:55:26Z

I can fix this for just this case to pass the transactions from the selectedTransactions object instead of using onyx. But for now let's see how easy the onyx problem is.

Slack thread https://expensify.slack.com/archives/C07NMDKEFMH/p1769021596645979

s77rt · 2026-01-21T20:03:46Z

@DylanDylann Can you please test again.

DylanDylann · 2026-01-22T07:57:21Z

@s77rt After moving the expense to the new report, the expense is still displayed in the unreported list. I need to apply the filter again to update the expense list. But I believe this will be fixed in #79506

Screen.Recording.2026-01-22.at.14.51.32.mov

DylanDylann · 2026-01-22T07:59:33Z

This should already work offline as I'm not adding new actions that would create new outcome.

The new report will be created on the admin account while offline, it should actually only be displayed on the employee account

Screen.Recording.2026-01-22.at.14.56.23.mov

DylanDylann · 2026-01-22T08:00:22Z

@s77rt If this bug #76000 (comment) could be fixed by #79506 I think we should do nothing here

s77rt · 2026-01-22T16:52:04Z

@DylanDylann

The new report will be created on the admin account while offline, it should actually only be displayed on the employee account

Can you please test again? It was created on the employee's expense chat from my end

s77rt · 2026-01-22T17:05:08Z

@DylanDylann

After moving the expense to the new report, the expense is still displayed in the unreported list. I need to apply the filter again to update the expense list. But I believe this will be fixed in #79506

I'm not sure what broke this but I guess this must be something on main already. That linked PR won't fix that. I think we can proceed and have that fixed separately cc @luacmartins

(btw, we can't optimistically remove the data from the snapshot because we don't have the hash for that search (the ones in groups), we only have the one for the main query that contains the groups -- one way to do it is to pass down the snapshot hash)

luacmartins · 2026-01-22T17:17:44Z

I'm not sure what broke this but I guess this must be something on main already. That linked PR won't fix that. I think we can proceed and have that fixed separately cc @luacmartins

That's fine with me

DylanDylann · 2026-01-22T17:19:02Z

Can you please test again? It was created on the employee's expense chat from my end

@s77rt My bad. It's working fine

DylanDylann · 2026-01-22T17:57:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-23.at.01.21.08.mov

Android: mWeb Chrome

Screen.Recording.2026-01-23.at.01.11.45.mov

iOS: HybridApp

Screen.Recording.2026-01-23.at.01.08.41.mov

iOS: mWeb Safari

Screen.Recording.2026-01-23.at.01.06.29.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-23.at.01.02.51.mov

OSBotify · 2026-01-23T01:02:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-23T22:34:13Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2026-01-23T23:17:42Z

@s77rt @luacmartins Can this one please be tested internally, We are currently blocked from creating card expense using Expensify card.

s77rt · 2026-01-26T09:51:19Z

I think that's fine. I tested this locally and @DylanDylann tested too

OSBotify · 2026-01-26T21:56:22Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

allow admin to create report on behald of employee

9624ed2

melvin-bot bot assigned s77rt Nov 25, 2025

s77rt mentioned this pull request Nov 25, 2025

[Due for payment 2026-02-02] Allow Admin to create report on employees' behalf #75607

Open

s77rt changed the title ~~Allow admin to create report on behalf on employee~~ Allow admin to create report on behalf of employee Nov 25, 2025

s77rt added 11 commits November 26, 2025 10:20

Merge branch 'main' into report-transaction-new-report

2f31cbd

lint

a2a4db8

pass accountID to CreateAppReport

a8c2633

pass owner personal details on report creation

9123cb9

get owner from selected report

e390506

allow editing unreported managed card transaction

84983e5

make changeTransactionsReport accept transactions

23e156f

add transaction to SelectedTransactionInfo

b790fdb

pass transactions to changeTransactionsReport

1dcfb45

update CreateAppReportParams to use reportCreateEmail

2b2077f

lint

1692887

s77rt changed the title ~~Allow admin to create report on behalf of employee~~ [Hold Web-E #49610] Allow admin to create report on behalf of employee Dec 1, 2025

s77rt commented Jan 5, 2026

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

s77rt added 6 commits January 13, 2026 13:19

merge main

7dbb1be

handle unreported expenses

7efe983

add comment

8a12936

rename param reportCreatorEmail to ownerEmail

a5225d7

rename variable

f49d612

lint

607b09d

s77rt changed the title ~~[Hold Web-E #49610] Allow admin to create report on behalf of employee~~ Allow admin to create report on behalf of employee Jan 13, 2026

lint

e1727f0

s77rt marked this pull request as ready for review January 13, 2026 14:48

s77rt requested review from a team as code owners January 13, 2026 14:48

melvin-bot bot requested a review from dominictb January 13, 2026 14:48

merge main

8f0b167

s77rt added 3 commits January 21, 2026 20:30

Merge branch 'main' into report-transaction-new-report

60ebd76

get transactions from SelectedTransactions object

24b9b01

lint

1d3e080

merge main

6659725

DylanDylann approved these changes Jan 22, 2026

View reviewed changes

melvin-bot bot requested a review from luacmartins January 22, 2026 18:21

luacmartins approved these changes Jan 23, 2026

View reviewed changes

luacmartins merged commit 10351bc into Expensify:main Jan 23, 2026
30 checks passed

OSBotify mentioned this pull request Jan 23, 2026

Deploy Checklist: New Expensify 2026-01-23 #80389

Closed

43 tasks

lanitochka17 mentioned this pull request Jan 23, 2026

Expense - Member's expense is moved to self workspace chat after moving it to new report #80400

Open

7 tasks

mitarachim mentioned this pull request Jan 24, 2026

Expense - Create report button shows wrong workspace, expense cannot be moved #80414

Closed

7 tasks

nlemma mentioned this pull request Jan 26, 2026

Expense - Non-admin approver can access Report list via link when the field is disabled #80492

Open

7 tasks

Allow admin to create report on behalf of employee #76000

Allow admin to create report on behalf of employee #76000

Conversation

s77rt commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

s77rt commented Jan 21, 2026

Uh oh!

s77rt commented Jan 21, 2026

Uh oh!

s77rt commented Jan 21, 2026

Uh oh!

s77rt commented Jan 21, 2026

Uh oh!

DylanDylann commented Jan 22, 2026

Uh oh!

DylanDylann commented Jan 22, 2026

Uh oh!

DylanDylann commented Jan 22, 2026

Uh oh!

s77rt commented Jan 22, 2026

Uh oh!

s77rt commented Jan 22, 2026

Uh oh!

luacmartins commented Jan 22, 2026

Uh oh!

DylanDylann commented Jan 22, 2026

Uh oh!

DylanDylann commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

m-natarajan commented Jan 23, 2026

Uh oh!

s77rt commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

s77rt commented Nov 25, 2025 •

edited

Loading

codecov bot commented Nov 25, 2025 •

edited by github-actions bot

Loading

DylanDylann commented Jan 22, 2026 •

edited

Loading

s77rt commented Jan 26, 2026 •

edited

Loading