Company card - Android: "Can't downgrade workspace" content is very small when font size is small #76092

twilight2294 · 2025-11-26T05:29:37Z

Explanation of Change

This PR is a follow up to #72926, there is an edge case where on android if the font is small, then the text is displayed extra small, we fix that with this PR.

Fixed Issues

$ #74299
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Device font size is set to minimum.
Workspace is on Control plan and has two feeds (any) in Company card page.

Test:

Launch Expensify app.
Go to workspace settings > Overview.
Tap Plan.
Tap Collect.
Tap Save.
Tap Downgrade workspace.

Verify that "Can't downgrade workspace" content will not be too small.

Verify that no errors appear in the JS console

PR Author Checklist

Screen.Recording.2025-11-26.at.11.03.28.AM.mov

melvin-bot · 2025-11-26T05:29:44Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2025-11-26T05:29:57Z

@situchan will review this since it comes from our PR

codecov · 2025-11-26T05:37:52Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/RenderHTML.tsx	`100.00% <ø> (ø)`
... and 15 files with indirect coverage changes

bernhardoj · 2025-11-26T06:34:04Z

@twilight2294 just a tip, you can add the original issue as the last issue on the Fixed Issues list so the original C+ is added.

$ 2nd issue
$ original issue

trjExpensify · 2025-11-26T16:05:55Z

Tagging in @Expensify/design team 👍

dannymcclain · 2025-11-26T16:09:44Z

Don't we have upper and lower bounds for font sizes even when the user adjusts via settings?

dubielzyk-expensify · 2025-11-27T00:47:51Z

I'm a bit confused why it's small to begin with since both of the text in this photo should be our regular body text size. So shouldn't the confirmation dialog text at least be the same as the one in the background. Can we triple check that we're using the right variables and code here? I could totally be missing something though

src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx

situchan · 2025-11-27T11:33:05Z

Here's difference:

dubielzyk-expensify · 2025-11-27T23:21:40Z

At least it looks like the left screenshot uses the same body font. The right is wrong.

Can you scale the font size up as well to see that they interact the same?

twilight2294 · 2025-12-04T13:41:38Z

At least it looks like the left screenshot uses the same body font. The right is wrong.

Can you scale the font size up as well to see that they interact the same?

@dubielzyk-expensify what's the expected result now? do we not want to adjust the font at all?

dubielzyk-expensify · 2025-12-05T01:11:13Z

We just want to use regular text size such that if the user scales up the device text size, then it scales with them.

They should both be body default text size

twilight2294 · 2025-12-08T06:17:07Z

Looking

twilight2294 · 2025-12-15T09:00:47Z

Fixed the code to not update the font size :

Screen.Recording.2025-12-15.at.2.29.38.PM.mov

src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx

twilight2294 · 2025-12-18T08:35:33Z

bump for review @situchan

twilight2294 · 2025-12-22T06:22:44Z

bump

situchan · 2025-12-26T12:29:24Z

src/components/RenderHTML.tsx

    return onLinkPress ? (
        <RenderHTMLConfigProvider
-            defaultTextProps={{selectable: true}}
+            defaultTextProps={{selectable: true, allowFontScaling: false}}


We already set this prop here:

App/src/components/HTMLEngineProvider/BaseHTMLEngineProvider.tsx

Line 211 in 75234df

const defaultTextProps: TextProps = useMemo(() => ({selectable: textSelectable, allowFontScaling: false, textBreakStrategy: 'simple'}), [textSelectable]);

Do you know why it doesn't work?

Nvm, we're rendering separately. Not related each other.

App/src/components/HTMLEngineProvider/BaseHTMLEngineProvider.tsx

Lines 237 to 245 in 75234df

<RenderHTMLConfigProvider

defaultTextProps={defaultTextProps}

defaultViewProps={defaultViewProps}

renderers={htmlRenderers}

computeEmbeddedMaxWidth={computeEmbeddedMaxWidth}

enableExperimentalBRCollapsing={enableExperimentalBRCollapsing}

>

{children}

</RenderHTMLConfigProvider>

App/src/components/RenderHTML.tsx

Lines 51 to 56 in 75234df

<RenderHTMLConfigProvider

defaultTextProps={{selectable: true}}

renderersProps={renderersProps}

>

{htmlSource}

</RenderHTMLConfigProvider>

situchan · 2025-12-26T12:36:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

situchan · 2025-12-26T12:39:54Z

This is global fix for all texts rendered with RenderHTML, not only downgrade workspace modal content.

@twilight2294 please add screenshots for all platforms.

cead22 · 2025-12-29T17:50:16Z

If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

Can you also add more tests to make sure other uses of RenderHTML still work as intended?

dubielzyk-expensify · 2026-01-05T01:21:10Z

Text and UI wise it looks correct now 👍

OSBotify · 2026-01-06T23:14:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-07T14:00:20Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.95-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-08T15:27:36Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.95-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Update WorkspaceDowngradePage.tsx

ea6a474

twilight2294 requested review from a team as code owners November 26, 2025 05:29

melvin-bot bot assigned twilight2294 Nov 26, 2025

melvin-bot bot requested review from bernhardoj and trjExpensify and removed request for a team November 26, 2025 05:29

melvin-bot bot removed the request for review from a team November 26, 2025 05:29

twilight2294 changed the title ~~Company card - "Can't downgrade workspace" content is very small when font size is small~~ Company card - Android: "Can't downgrade workspace" content is very small when font size is small Nov 26, 2025

trjExpensify requested review from a team and removed request for trjExpensify November 26, 2025 16:05

situchan reviewed Nov 27, 2025

View reviewed changes

src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx Outdated Show resolved Hide resolved

jayeshmangwani mentioned this pull request Dec 2, 2025

[Due for payment 2026-01-15] [$250] Company card - "Can't downgrade workspace" content is very small when font size is small #74299

Open

8 tasks

twilight2294 added 3 commits December 15, 2025 14:21

Merge branch 'Expensify:main' into patch-49

dab0bbb

fix font scaling

93261a0

Update WorkspaceDowngradePage.tsx

f355d63

twilight2294 requested a review from situchan December 15, 2025 09:00

twilight2294 commented Dec 15, 2025

View reviewed changes

src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx Outdated Show resolved Hide resolved

twilight2294 added 2 commits December 15, 2025 14:31

Apply suggestion from @twilight2294

2a83d83

Merge branch 'Expensify:main' into patch-49

e93abdb

Merge branch 'Expensify:main' into patch-49

f4ed12f

situchan reviewed Dec 26, 2025

View reviewed changes

situchan approved these changes Dec 26, 2025

View reviewed changes

melvin-bot bot requested a review from cead22 December 26, 2025 12:37

cead22 approved these changes Jan 6, 2026

View reviewed changes

cead22 merged commit 65e7b60 into Expensify:main Jan 6, 2026
31 of 33 checks passed

OSBotify mentioned this pull request Jan 7, 2026

Deploy Checklist: New Expensify 2026-01-07 #78997

Closed

54 tasks

	<RenderHTMLConfigProvider
	defaultTextProps={defaultTextProps}
	defaultViewProps={defaultViewProps}
	renderers={htmlRenderers}
	computeEmbeddedMaxWidth={computeEmbeddedMaxWidth}
	enableExperimentalBRCollapsing={enableExperimentalBRCollapsing}
	>
	{children}
	</RenderHTMLConfigProvider>

	<RenderHTMLConfigProvider
	defaultTextProps={{selectable: true}}
	renderersProps={renderersProps}
	>
	{htmlSource}
	</RenderHTMLConfigProvider>

Company card - Android: "Can't downgrade workspace" content is very small when font size is small #76092

Company card - Android: "Can't downgrade workspace" content is very small when font size is small #76092

Uh oh!

Conversation

twilight2294 commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

melvin-bot bot commented Nov 26, 2025

Uh oh!

twilight2294 commented Nov 26, 2025

Uh oh!

codecov bot commented Nov 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj commented Nov 26, 2025

Uh oh!

trjExpensify commented Nov 26, 2025

Uh oh!

dannymcclain commented Nov 26, 2025

Uh oh!

dubielzyk-expensify commented Nov 27, 2025

Uh oh!

Uh oh!

situchan commented Nov 27, 2025

Uh oh!

dubielzyk-expensify commented Nov 27, 2025

Uh oh!

twilight2294 commented Dec 4, 2025

Uh oh!

dubielzyk-expensify commented Dec 5, 2025

Uh oh!

twilight2294 commented Dec 8, 2025

Uh oh!

twilight2294 commented Dec 15, 2025

Uh oh!

Uh oh!

twilight2294 commented Dec 18, 2025

Uh oh!

twilight2294 commented Dec 22, 2025

Uh oh!

situchan Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

situchan Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

situchan commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Dec 26, 2025

Uh oh!

cead22 commented Dec 29, 2025

Uh oh!

dubielzyk-expensify commented Jan 5, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 6, 2026

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

twilight2294 commented Nov 26, 2025 •

edited

Loading

codecov bot commented Nov 26, 2025 •

edited by github-actions bot

Loading

situchan commented Dec 26, 2025 •

edited

Loading