fix: Pay button show original amount in approved report after splitting amount again in 1st report by nkdengineer · Pull Request #76479 · Expensify/App

nkdengineer · 2025-12-02T04:17:05Z

Explanation of Change

fix: Pay button show original amount in approved report after splitting amount again in 1st report

Fixed Issues

$ #75622
PROPOSAL: #75622 (comment)

Tests

Precondition : Create a workspace with Delay submission disabled and Add approvals enabled

Navigate to workspace chat & create a manual expense
Create an empty report (Report 2)
Split the expense previously created in the workspace chat into 2 child splits
Select one of the splits and move it to another report (Report 2)
Submit and approve Report 2
Open the other split expense in Report 1
Click on More > Edit Splits
Click Add Split >> Split the amount into 2 child splits
Go back to workspace chat
Verify that the pay button of the report 2 still displays the correct amount

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-02.at.11.09.36.mov

Android: mWeb Chrome

Screen.Recording.2025-12-02.at.11.08.40.mov

iOS: Native

Screen.Recording.2025-12-02.at.11.11.18.mov

iOS: mWeb Safari

Screen.Recording.2025-12-02.at.11.10.34.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-02.at.11.07.15.mov

…ng amount again in 1st report

codecov · 2025-12-02T04:25:35Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU.ts	`64.89% <66.66%> (+0.19%)`	⬆️
... and 11 files with indirect coverage changes

melvin-bot · 2025-12-02T04:33:36Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/IOU.ts

dukenv0307 · 2025-12-02T17:29:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-03.at.00.25.58.mov

Android: mWeb Chrome

Screen.Recording.2025-12-03.at.00.22.04.mov

iOS: HybridApp

Screen.Recording.2025-12-03.at.00.28.15.mov

iOS: mWeb Safari

Screen.Recording.2025-12-03.at.00.23.23.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-03.at.00.19.36.mov

NikkiWines · 2025-12-02T21:06:29Z

src/libs/actions/IOU.ts

    const failureData = [] as OnyxUpdate[];
    const optimisticData = [] as OnyxUpdate[];

+    // Before the loop (around line 14388)


Before the loop what? This comment is not very helpful

@NikkiWines I removed. I don't see this when coping the PERF suggestion

joekaufmanexpensify

Fine from a product perspective 👍

NikkiWines

one small thing

NikkiWines · 2025-12-05T17:29:53Z

src/libs/actions/IOU.ts

+    for (const expense of splitExpenses) {
+        if (expense.reportID) {
+            const currentTotal = reportTotals.get(expense.reportID) ?? 0;
+            reportTotals.set(expense.reportID, currentTotal - (expense.amount ?? 0));
+        }


Can you add a comment about why this loop is necessary

@NikkiWines I updated.

NikkiWines

🚢

NikkiWines · 2025-12-09T14:22:43Z

@nkdengineer you've got a test failure

OSBotify · 2025-12-09T17:22:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-10T22:06:05Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T23:59:19Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:01:12Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:06:26Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Pay button show original amount in approved report after splitti…

45c8488

…ng amount again in 1st report

melvin-bot bot assigned nkdengineer Dec 2, 2025

nkdengineer marked this pull request as ready for review December 2, 2025 04:33

nkdengineer requested review from a team as code owners December 2, 2025 04:33

melvin-bot bot requested review from dukenv0307 and removed request for a team December 2, 2025 04:33

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team December 2, 2025 04:33

github-actions bot reviewed Dec 2, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

nkdengineer added 3 commits December 2, 2025 21:22

Merge branch 'main' into fix/75622

2ff42c4

optimize perf

93e1919

fix lint

1df36d8

dukenv0307 approved these changes Dec 2, 2025

View reviewed changes

melvin-bot bot requested a review from NikkiWines December 2, 2025 17:29

NikkiWines requested changes Dec 2, 2025

View reviewed changes

joekaufmanexpensify previously approved these changes Dec 3, 2025

View reviewed changes

nkdengineer added 2 commits December 5, 2025 23:13

Merge branch 'main' into fix/75622

ea9fe5c

remove comment

58ee7c2

nkdengineer dismissed joekaufmanexpensify’s stale review via 58ee7c2 December 5, 2025 16:14

NikkiWines requested changes Dec 5, 2025

View reviewed changes

nkdengineer added 2 commits December 9, 2025 00:46

Merge branch 'main' into fix/75622

ad0ec66

add comment

6ebe2e4

NikkiWines approved these changes Dec 8, 2025

View reviewed changes

Merge branch 'main' into fix/75622

5eb2a7a

NikkiWines merged commit ba34b92 into Expensify:main Dec 9, 2025
28 checks passed

OSBotify mentioned this pull request Dec 10, 2025

Deploy Checklist: New Expensify 2025-12-10 #77285

Closed

94 tasks

melvin-bot bot mentioned this pull request Dec 12, 2025

[Due for payment 2025-12-19] [$250] Pay button show original amount in approved report after splitting amount again in 1st report #75622

Closed

8 tasks

Comments

Conversation

nkdengineer commented Dec 2, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 2, 2025

Uh oh!

Uh oh!

dukenv0307 commented Dec 2, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

NikkiWines Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines commented Dec 9, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Dec 2, 2025 •

edited by github-actions bot

Loading