Replace Lottie animations of some empty states to static images on Web by fabioh8010 · Pull Request #76560 · Expensify/App

fabioh8010 · 2025-12-02T18:54:18Z

Explanation of Change

This PR replaces the Lottie animations of some empty state UIs on Web, with the purpose of lowering down the memory / cpu usage that is very high when using Lottie animations and impacts user's experience.

Fixed Issues

$ #76166
PROPOSAL:

Tests

Pre-requisites

To make testing easier, you can make this change in SearchUIUtils.ts.

diff --git a/src/libs/SearchUIUtils.ts b/src/libs/SearchUIUtils.ts
index 0095bd7f707..03b9124f436 100644
--- a/src/libs/SearchUIUtils.ts
+++ b/src/libs/SearchUIUtils.ts
@@ -620,14 +620,14 @@ function getSuggestedSearchesVisibility(
         [CONST.SEARCH.SEARCH_KEYS.EXPENSES]: true,
         [CONST.SEARCH.SEARCH_KEYS.REPORTS]: true,
         [CONST.SEARCH.SEARCH_KEYS.CHATS]: true,
-        [CONST.SEARCH.SEARCH_KEYS.SUBMIT]: shouldShowSubmitSuggestion,
-        [CONST.SEARCH.SEARCH_KEYS.PAY]: shouldShowPaySuggestion,
-        [CONST.SEARCH.SEARCH_KEYS.APPROVE]: shouldShowApproveSuggestion,
-        [CONST.SEARCH.SEARCH_KEYS.EXPORT]: shouldShowExportSuggestion,
-        [CONST.SEARCH.SEARCH_KEYS.STATEMENTS]: shouldShowStatementsSuggestion,
-        [CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CASH]: shouldShowUnapprovedCashSuggestion,
-        [CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CARD]: shouldShowUnapprovedCardSuggestion,
-        [CONST.SEARCH.SEARCH_KEYS.RECONCILIATION]: shouldShowReconciliationSuggestion,
+        [CONST.SEARCH.SEARCH_KEYS.SUBMIT]: true,
+        [CONST.SEARCH.SEARCH_KEYS.PAY]: true,
+        [CONST.SEARCH.SEARCH_KEYS.APPROVE]: true,
+        [CONST.SEARCH.SEARCH_KEYS.EXPORT]: true,
+        [CONST.SEARCH.SEARCH_KEYS.STATEMENTS]: true,
+        [CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CASH]: true,
+        [CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CARD]: true,
+        [CONST.SEARCH.SEARCH_KEYS.RECONCILIATION]: true,
     };
 }

Native

Go to Inbox tab (make sure you have a clean LHN), assert the empty state UI is using Lottie illustration as exactly as before.
Go to Workspaces tab (make sure you don't have workspaces), assert the empty state UI is using Lottie illustration as exactly as before.
Go to Reports tab (make sure you don't have any expenses/reports), go over some empty sections and assert the empty state UIs are using Lottie illustrations as exactly as before.

Web / mWeb

Go to Inbox tab (make sure you have a clean LHN), assert the empty state UI is now using static illustration instead of Lottie one.
Go to Workspaces tab (make sure you don't have workspaces), assert the empty state UI is now using static illustration instead of Lottie one.
Go to Reports tab (make sure you don't have any expenses/reports), go over some empty sections and assert the empty state UIs are now using static illustrations instead of Lottie ones.
(Google Chrome only) During each step above and with Google Chrome's Task Manager, assert the memory / cpu usage are low and stable when displaying the static illustrations.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests, but you won't be able to edit code to make testing easier in Reports tab.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-11.at.09.39.28-compressed.mov

Android: mWeb Chrome

⚠️ You can see that there are some glitches in this recording but I tested on production and they are also happening, so it's just some problem with the emulator.

Screen.Recording.2025-12-11.at.09.41.59-compressed.mov

iOS: Native

Screen.Recording.2025-12-11.at.09.45.36-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-12-11.at.09.47.21-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-11.at.09.49.58-compressed.mov

Screen.Recording.2025-12-11.at.09.52.57-compressed.mov

codecov · 2025-12-02T19:02:27Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/BlockingViews/BlockingView.tsx	`100.00% <ø> (ø)`
...EmptyStateComponent/GenericEmptyStateComponent.tsx	`100.00% <100.00%> (ø)`
src/components/Icon/chunks/illustrations.chunk.ts	`0.00% <ø> (ø)`
src/components/LHNOptionsList/LHNOptionsList.tsx	`87.50% <ø> (ø)`
...ptionsList/useEmptyLHNIllustration/index.native.ts	`100.00% <100.00%> (ø)`
src/libs/SearchUIUtils.ts	`73.12% <ø> (ø)`
src/pages/Search/EmptySearchView.tsx	`86.66% <100.00%> (-0.44%)`	⬇️
...ch/useSearchEmptyStateIllustration/index.native.ts	`100.00% <100.00%> (ø)`
src/pages/workspace/WorkspacesListPage.tsx	`76.77% <ø> (ø)`
src/styles/index.ts	`45.94% <ø> (ø)`
... and 6 more
... and 9 files with indirect coverage changes

fabioh8010 · 2025-12-11T10:43:40Z

React Compiler Compliance Check is also failing in other PRs, see this thread.
Verify signed commits failed due to 401 API error (RequestError [HttpError]: Bad credentials), doesn't seem related to my PR or commits.

melvin-bot · 2025-12-11T10:44:17Z

@dubielzyk-expensify @akinwale One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…tates

dubielzyk-expensify · 2025-12-11T10:47:27Z

Videos are all looking good to me 👍

dannymcclain · 2025-12-11T15:39:55Z

Videos are looking good to me too.

fabioh8010 · 2025-12-12T10:33:36Z

I'm going to be OOO from Dec 15th to Jan 15h, so @VickyStash will take care of the PR while I'm on vacations.

joekaufmanexpensify

Change makes sense to me 👍

akinwale · 2025-12-15T06:38:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

76560-android-hybrid.mp4

Android: mWeb Chrome

76560-android-chrome.mp4

iOS: HybridApp

76560-ios-hybrid.mp4

iOS: mWeb Safari

76560-ios-safari.mp4

MacOS: Chrome / Safari

76560-web.mp4

akinwale

LGTM.

OSBotify · 2025-12-15T14:10:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-16T22:46:58Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-12-17T09:13:59Z

@fabioh8010 We can't paste the code to console in Native apps. In this case, how to execute step 1

OSBotify · 2025-12-17T12:24:40Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T18:46:09Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:09:33Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fabioh8010 added 4 commits December 2, 2025 18:19

Add empty state illustrations

bdf197f

Compress SVGs

acc91af

Move WorkspacesEmptyStateComponent to proper folder

f555acf

Use static illustration for Workspace empty state

8c11f77

melvin-bot Bot assigned fabioh8010 Dec 2, 2025

fabioh8010 mentioned this pull request Dec 2, 2025

[Due for payment 2025-12-25] [Due for payment 2025-12-11] Temporarily use static assets instead lottie animations on web #76166

Closed

fabioh8010 added 6 commits December 3, 2025 16:33

Merge branch 'main' into feature/76166-empty-states

e21e11c

Merge branch 'main' into feature/76166-empty-states

ec03769

Merge branch 'main' into feature/76166-empty-states

4f82c93

Use static illustration for Expenses/Reports empty states in Search

2221312

Use static illustration for empty LHN state

5b38abc

Use static illustrations for empty states in other sections in Search

034cd98

fabioh8010 changed the title ~~[WIP] Replace Lottie animations of some empty states to static images on Web~~ Replace Lottie animations of some empty states to static images on Web Dec 11, 2025

fabioh8010 marked this pull request as ready for review December 11, 2025 10:44

fabioh8010 requested review from a team as code owners December 11, 2025 10:44

melvin-bot Bot requested review from akinwale, dubielzyk-expensify and joekaufmanexpensify and removed request for a team December 11, 2025 10:44

melvin-bot Bot removed the request for review from a team December 11, 2025 10:44

Merge remote-tracking branch 'origin/main' into feature/76166-empty-s…

f67860b

…tates

Merge branch 'main' into feature/76166-empty-states

6fc6447

Remove useMemo

cae97ea

joekaufmanexpensify approved these changes Dec 12, 2025

View reviewed changes

akinwale approved these changes Dec 15, 2025

View reviewed changes

melvin-bot Bot requested a review from mjasikowski December 15, 2025 06:39

mjasikowski approved these changes Dec 15, 2025

View reviewed changes

mjasikowski merged commit 31b4b8b into Expensify:main Dec 15, 2025
32 of 33 checks passed

OSBotify mentioned this pull request Dec 16, 2025

Deploy Checklist: New Expensify 2025-12-16 #77818

Closed

Conversation

fabioh8010 commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Pre-requisites

Native

Web / mWeb

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Dec 2, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fabioh8010 commented Dec 11, 2025

Uh oh!

melvin-bot Bot commented Dec 11, 2025

Uh oh!

dubielzyk-expensify commented Dec 11, 2025

Uh oh!

dannymcclain commented Dec 11, 2025

Uh oh!

fabioh8010 commented Dec 12, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

akinwale commented Dec 15, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 15, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

IuliiaHerets commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fabioh8010 commented Dec 2, 2025 •

edited

Loading

codecov Bot commented Dec 2, 2025 •

edited by github-actions Bot

Loading