Fix: When auto-reporting is disabled, user cannot submit expense to 1:1 DM from FAB #77149

twilight2294 · 2025-12-09T14:51:59Z

Explanation of Change

Fixed Issues

$ #75109
PROPOSAL: #75109 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Turn off Submission frequency, Add approvals and Make or track payments in Workflows settings.
Test:

Open FAB > Create expense > Manual.
Enter amount > Next.
On confirm page, click To field.
Select a user (not workspace chat).
Click Create expense.

Verify that The expense will be created in 1:1 DM.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-09.at.8.32.53.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-09.at.8.31.19.PM.mov

iOS: Native

Screen.Recording.2025-12-09.at.8.27.07.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-09.at.8.28.01.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-09.at.8.23.42.PM.mov

…:1 DM from FAB

melvin-bot · 2025-12-09T15:03:32Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/IOU.ts

codecov · 2025-12-09T15:16:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/index.ts	`70.52% <100.00%> (+0.06%)`	⬆️
... and 6 files with indirect coverage changes

src/libs/actions/IOU.ts

twilight2294 · 2025-12-09T18:30:36Z

@ikevin127 i will fix the failing jest tomorrow

ikevin127 · 2025-12-09T19:51:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-hybrid.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: HybridApp

ios-hybrid.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

ikevin127

🟢 LGTM - Once failing workflow is addressed (probably a sync with main) this can be merged.

joekaufmanexpensify

Fix makes sense 👍

mollfpr · 2025-12-11T05:10:33Z

@twilight2294 Could you resolve the failing test? Thank you!

joekaufmanexpensify · 2026-01-20T16:36:37Z

@twilight2294 how's this coming?

This reverts commit 1be90b2.

twilight2294 · 2026-01-21T12:42:58Z

@ikevin127 PR is ready for your review. The bug which i was saying about already exists on prod, I will post bug report in Expensify-Open-Source and ping you there

…to issue75109

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1801e017e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/index.ts

twilight2294 · 2026-01-21T13:08:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6884e773e2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-21T13:20:46Z

src/libs/actions/IOU/index.ts

+    if (chatReport && !isPolicyExpenseChat && !isPolicyExpenseChatReportUtil(chatReport) && !isSelfDM(chatReport)) {
+        const parentChatReportParticipants = Object.keys(chatReport.participants ?? {}).map(Number);
+        const expectedParticipants = [payerAccountID, payeeAccountID].sort();
+        const sortedParentChatReportParticipants = parentChatReportParticipants.sort();
+
+        const participantsMatch =
+            expectedParticipants.length === sortedParentChatReportParticipants.length && expectedParticipants.every((id, index) => id === sortedParentChatReportParticipants.at(index));
+
+        if (!participantsMatch) {
+            chatReport = null;
+        }


Avoid discarding group chat reports

When a money request is initiated from a non-policy group chat, the report’s participants list will include more than the payer/payee pair, so participantsMatch becomes false and the code nulls chatReport. The subsequent getChatByParticipants only searches 1:1 chats, so the request will be created in a DM instead of the original group chat, removing group visibility. This is a behavioral regression for requests started in group chats; consider exempting group chats (e.g., isGroupChat) from this participant-matching null-out.

Useful? React with 👍 / 👎.

ikevin127 · 2026-01-23T00:45:15Z

@ikevin127 PR is ready for your review. The bug which i was saying about already exists on prod, I will post bug report in Expensify-Open-Source and ping you there

✅ Sounds good to me as long as you have proof that the issue is already on production - meaning it can't be reported as a regression of this PR.

@twilight2294 About the latest codex comment, is this a valid concern given your changes ? If it is I'd say it must be addressed - please let me know and once everything is addressed I will take a final pass at the PR with some tests to make sure we're ready to merge 🟢

twilight2294 · 2026-01-27T17:52:19Z

sorry i missed your message, i thought the PR was pending for your review, I'm on it today

twilight2294 · 2026-01-29T11:34:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04726920b6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/index.ts

twilight2294 · 2026-01-29T13:26:01Z

@codex review

chatgpt-codex-connector · 2026-01-29T13:38:25Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

twilight2294 · 2026-01-30T18:54:27Z

@mollfpr can you review this PR, thanks !

mollfpr

Thank you!

OSBotify · 2026-01-30T19:50:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:15:40Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix: When auto-reporting is disabled, user cannot submit expense to 1…

0183026

…:1 DM from FAB

melvin-bot bot assigned twilight2294 Dec 9, 2025

Merge branch 'Expensify:main' into issue75109

85881e2

twilight2294 marked this pull request as ready for review December 9, 2025 15:03

twilight2294 requested review from a team as code owners December 9, 2025 15:03

melvin-bot bot requested review from ikevin127 and removed request for a team December 9, 2025 15:03

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team December 9, 2025 15:03

twilight2294 mentioned this pull request Dec 9, 2025

[$250] Expense - When auto-reporting is disabled, user cannot submit expense to 1:1 DM from FAB #75109

Open

8 tasks

github-actions bot reviewed Dec 9, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

address AI reviewers comments

9ce5f1c

twilight2294 added 2 commits December 9, 2025 21:40

Update IOU.ts

7236202

Merge branch 'Expensify:main' into issue75109

5652f79

twilight2294 commented Dec 9, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

Apply suggestion from @twilight2294

8e4992d

twilight2294 commented Dec 9, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

twilight2294 added 2 commits December 9, 2025 23:30

Apply suggestion from @twilight2294

5b898be

Update IOU.ts

0e6a87b

ikevin127 approved these changes Dec 9, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr December 9, 2025 21:28

joekaufmanexpensify previously approved these changes Dec 10, 2025

View reviewed changes

twilight2294 added 2 commits December 11, 2025 13:09

Merge branch 'Expensify:main' into issue75109

0ac2b5c

fix failing tests and add new tests

1a436a1

twilight2294 added 5 commits January 21, 2026 11:23

Merge branch 'main' into issue75109

5e3a2d1

update code to fix regressions

1be90b2

Revert "update code to fix regressions"

5b5164e

This reverts commit 1be90b2.

Merge branch 'Expensify:main' into issue75109

e1801e0

add tests

062f916

twilight2294 marked this pull request as ready for review January 21, 2026 12:42

shMerge branch 'issue75109' of https://github.com/twilight2294/App in…

bf7ccdb

…to issue75109

chatgpt-codex-connector bot reviewed Jan 21, 2026

View reviewed changes

src/libs/actions/IOU/index.ts Show resolved Hide resolved

fix codex comment

6884e77

chatgpt-codex-connector bot reviewed Jan 21, 2026

View reviewed changes

twilight2294 added 2 commits January 29, 2026 16:58

Merge branch 'Expensify:main' into issue75109

b9dad76

apply codex suggestions

0472692

chatgpt-codex-connector bot reviewed Jan 29, 2026

View reviewed changes

src/libs/actions/IOU/index.ts Outdated Show resolved Hide resolved

address codex comments

c19b989

fix failing typecheck

220d414

ikevin127 approved these changes Jan 30, 2026

View reviewed changes

mollfpr approved these changes Jan 30, 2026

View reviewed changes

mollfpr merged commit 5a582d6 into Expensify:main Jan 30, 2026
30 checks passed

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Open

Fix: When auto-reporting is disabled, user cannot submit expense to 1:1 DM from FAB #77149

Fix: When auto-reporting is disabled, user cannot submit expense to 1:1 DM from FAB #77149

Uh oh!

Conversation

twilight2294 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 9, 2025

Uh oh!

Uh oh!

codecov bot commented Dec 9, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

twilight2294 commented Dec 9, 2025

Uh oh!

ikevin127 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Dec 11, 2025

Uh oh!

joekaufmanexpensify commented Jan 20, 2026

Uh oh!

twilight2294 commented Jan 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

twilight2294 commented Jan 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Jan 23, 2026

Uh oh!

twilight2294 commented Jan 27, 2026

Uh oh!

twilight2294 commented Jan 29, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

twilight2294 commented Jan 29, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 29, 2026

Uh oh!

twilight2294 commented Jan 30, 2026

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Jan 30, 2026

twilight2294 commented Dec 9, 2025 •

edited

Loading

codecov bot commented Dec 9, 2025 •

edited by github-actions bot

Loading

ikevin127 commented Dec 9, 2025 •

edited

Loading