Skip to content

[No QA] feat: add Sentry debug controls to Troubleshoot page#77254

Merged
rlinoz merged 6 commits intoExpensify:mainfrom
software-mansion-labs:dariusz-biela/perf/sentry/troubleshoot-panel-enable-debug
Dec 15, 2025
Merged

[No QA] feat: add Sentry debug controls to Troubleshoot page#77254
rlinoz merged 6 commits intoExpensify:mainfrom
software-mansion-labs:dariusz-biela/perf/sentry/troubleshoot-panel-enable-debug

Conversation

@dariusz-biela
Copy link
Copy Markdown
Contributor

@dariusz-biela dariusz-biela commented Dec 10, 2025

Explanation of Change

Add UI controls to enable/disable Sentry debug logging at runtime without
code changes. Previously debugging Sentry required modifying constants in
debugTransport.ts and rebuilding the app.

Changes:

  • Add SentryDebugToolMenu component with toggle and span filter input
  • Store debug settings in Onyx (IS_SENTRY_DEBUG_ENABLED, SENTRY_DEBUG_HIGHLIGHTED_SPAN_OPS)
  • Update debugTransport to read settings from Onyx instead of hardcoded constants
  • Remove early return in telemetry/index.ts so Sentry initializes in dev mode
  • Show Sentry debug section only in development environment

Fixed Issues

$ #76428
PROPOSAL:

Tests

  1. Launch the development environment
  2. Go to the Troubleshoot panel
  3. Enable "Log Sentry requests to console"
  4. Set "Highlighted span operations" to navigation.processing
  5. Do some navigation
  • Check if the [SENTRY] logs appear in the console
  • Check if [SENTRY] logs are not looping
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2025-12-10.at.17.57.18.mov
Android: Native image
iOS: Native Screenshot 2025-12-10 at 18 08 21

  Add UI controls to enable/disable Sentry debug logging at runtime without
  code changes. Previously debugging Sentry required modifying constants in
  debugTransport.ts and rebuilding the app.

  Changes:
  - Add SentryDebugToolMenu component with toggle and span filter input
  - Store debug settings in Onyx (IS_SENTRY_DEBUG_ENABLED, SENTRY_DEBUG_HIGHLIGHTED_SPAN_OPS)
  - Update debugTransport to read settings from Onyx instead of hardcoded constants
  - Remove early return in telemetry/index.ts so Sentry initializes in dev mode
  - Show Sentry debug section only in development environment
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Dec 10, 2025

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/setup/telemetry/index.ts 0.00% <ø> (ø)
...c/pages/settings/Troubleshoot/TroubleshootPage.tsx 0.00% <0.00%> (ø)
src/libs/actions/SentryDebug.ts 0.00% <0.00%> (ø)
src/components/SentryDebugToolMenu.tsx 0.00% <0.00%> (ø)
src/setup/telemetry/debugTransport.ts 0.00% <0.00%> (ø)
... and 175 files with indirect coverage changes

  Prevents infinite logging loop by filtering log entries with [SENTRY] prefix from Sentry envelopes before outputting to console. Also skips envelopes that contain only headers after filtering.
@dariusz-biela dariusz-biela marked this pull request as ready for review December 11, 2025 14:25
@dariusz-biela dariusz-biela requested review from a team as code owners December 11, 2025 14:25
@melvin-bot melvin-bot Bot requested review from JmillsExpensify and huult and removed request for a team December 11, 2025 14:25
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Dec 11, 2025

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team December 11, 2025 14:25
@github-actions
Copy link
Copy Markdown
Contributor

Code Review Complete ✅

I've reviewed all the code changes in this PR and found no rule violations. The implementation looks good:

Key Observations:

  • ✅ Proper Onyx usage with useOnyx and connectWithoutView
  • ✅ Clean component structure with appropriate separation of concerns
  • ✅ Good TypeScript typing throughout
  • ✅ Effective loop prevention with filterSentryDebugLogs function
  • ✅ Safe runtime configuration via Onyx
  • ✅ Proper React patterns (hooks, state management)

The PR successfully adds runtime Sentry debug controls without requiring code changes or rebuilds. Nice work! 🎉

@dariusz-biela dariusz-biela changed the title feat: add Sentry debug controls to Troubleshoot page [No QA] feat: add Sentry debug controls to Troubleshoot page Dec 11, 2025
@OSBotify
Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index aec47d69..c495b318 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1927,6 +1927,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: 'Fehlerdaten aufzeichnen',
             softKillTheApp: 'App sanft beenden',
             kill: 'Beenden',
+            sentryDebug: 'Sentry-Debug',
+            sentryDebugDescription: 'Sentry-Anfragen in der Konsole protokollieren',
+            sentryHighlightedSpanOps: 'Hervorgehobene Bereichsnamen',
+            sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, Navigation, ui.load',
         },
         debugConsole: {
             saveLog: 'Protokoll speichern',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index edf8bcb9..5f720aac 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1927,6 +1927,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: 'Enregistrer les données de dépannage',
             softKillTheApp: 'Fermer l’application en douceur',
             kill: 'Tuer',
+            sentryDebug: 'Débogage Sentry',
+            sentryDebugDescription: 'Consigner les requêtes Sentry dans la console',
+            sentryHighlightedSpanOps: 'Noms de segments surlignés',
+            sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.clic, navigation, ui.chargement',
         },
         debugConsole: {
             saveLog: 'Enregistrer le journal',
@@ -6239,7 +6243,7 @@ Exigez des informations de dépense comme les reçus et les descriptions, défin
                 autoPayReportsUnderTitle: 'Rapports de paiement automatique sous',
                 autoPayReportsUnderDescription: 'Les notes de frais entièrement conformes en dessous de ce montant seront automatiquement réglées.',
                 unlockFeatureEnableWorkflowsSubtitle: ({featureName, moreFeaturesLink}: FeatureNameParams) =>
-                    `Allez dans [plus de fonctionnalités](${moreFeaturesLink}) et activez les workflows, puis ajoutez ${featureName} pour déverrouiller cette fonctionnalité.`,
+                    `Accédez à [plus de fonctionnalités](${moreFeaturesLink}) et activez les workflows, puis ajoutez ${featureName} pour déverrouiller cette fonctionnalité.`,
                 enableFeatureSubtitle: ({featureName, moreFeaturesLink}: FeatureNameParams) =>
                     `Allez dans [plus de fonctionnalités](${moreFeaturesLink}) et activez ${featureName} pour déverrouiller cette fonctionnalité.`,
             },
diff --git a/src/languages/it.ts b/src/languages/it.ts
index d7642a8d..e6520b4c 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1922,6 +1922,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: 'Registrare dati di risoluzione problemi',
             softKillTheApp: "Termina l'app in modo non forzato",
             kill: 'Termina',
+            sentryDebug: 'Debug di Sentry',
+            sentryDebugDescription: 'Registra le richieste Sentry nella console',
+            sentryHighlightedSpanOps: 'Nomi degli span evidenziati',
+            sentryHighlightedSpanOpsPlaceholder: 'clic.interazione.ui, navigazione, caricamento.ui',
         },
         debugConsole: {
             saveLog: 'Salva registro',
@@ -6210,7 +6214,7 @@ Richiedi dettagli di spesa come ricevute e descrizioni, imposta limiti e valori
                 autoPayReportsUnderTitle: 'Pagamento automatico dei report inferiori a',
                 autoPayReportsUnderDescription: 'Le note spese completamente conformi inferiori a questo importo verranno rimborsate automaticamente.',
                 unlockFeatureEnableWorkflowsSubtitle: ({featureName, moreFeaturesLink}: FeatureNameParams) =>
-                    `Vai a [altre funzionalità](${moreFeaturesLink}) e abilita i flussi di lavoro, quindi aggiungi ${featureName} per sbloccare questa funzionalità.`,
+                    `Vai su [altre funzionalità](${moreFeaturesLink}) e abilita i flussi di lavoro, quindi aggiungi ${featureName} per sbloccare questa funzionalità.`,
                 enableFeatureSubtitle: ({featureName, moreFeaturesLink}: FeatureNameParams) =>
                     `Vai a [altre funzionalità](${moreFeaturesLink}) e abilita ${featureName} per sbloccare questa funzione.`,
             },
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index dcea62da..b526ad4a 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1922,6 +1922,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: 'トラブルシュートデータを記録',
             softKillTheApp: 'アプリをソフト終了する',
             kill: '強制終了',
+            sentryDebug: 'Sentry デバッグ',
+            sentryDebugDescription: 'Sentry リクエストをコンソールに記録',
+            sentryHighlightedSpanOps: 'ハイライト表示されたスパン名',
+            sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, ナビゲーション, ui.load',
         },
         debugConsole: {
             saveLog: 'ログを保存',
@@ -6156,7 +6160,7 @@ ${reportName}
                 adultEntertainment: 'アダルトエンターテインメント',
             },
             expenseReportRules: {
-                title: '経費精算書',
+                title: '経費レポート',
                 subtitle: '経費精算レポートのコンプライアンス、承認、支払いを自動化します。',
                 preventSelfApprovalsTitle: '自己承認を防ぐ',
                 preventSelfApprovalsSubtitle: 'ワークスペースメンバーが自分自身の経費精算レポートを承認できないようにします。',
@@ -6173,7 +6177,7 @@ ${reportName}
                 autoPayReportsUnderTitle: '以下のレポートを自動支払い',
                 autoPayReportsUnderDescription: 'この金額以下の、要件を完全に満たした経費精算書は自動的に支払われます。',
                 unlockFeatureEnableWorkflowsSubtitle: ({featureName, moreFeaturesLink}: FeatureNameParams) =>
-                    `[その他の機能](${moreFeaturesLink}) に移動してワークフローを有効にし、その後 ${featureName} を追加してこの機能を有効化してください。`,
+                    `[その他の機能](${moreFeaturesLink}) に移動してワークフローを有効にし、その後 ${featureName} を追加してこの機能を有効にしてください。`,
                 enableFeatureSubtitle: ({featureName, moreFeaturesLink}: FeatureNameParams) =>
                     `[その他の機能](${moreFeaturesLink})に移動し、${featureName} を有効にしてこの機能をアンロックしてください。`,
             },
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 036c1bfb..4df13fd8 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1920,6 +1920,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: 'Gegevens voor probleemoplossing vastleggen',
             softKillTheApp: 'De app zacht afsluiten',
             kill: 'Beëindigen',
+            sentryDebug: 'Sentry-debug',
+            sentryDebugDescription: 'Sentry-aanvragen naar console loggen',
+            sentryHighlightedSpanOps: 'Gemarkeerde spannamen',
+            sentryHighlightedSpanOpsPlaceholder: 'ui.interactie.klik, navigatie, ui.laden',
         },
         debugConsole: {
             saveLog: 'Log opslaan',
@@ -6181,7 +6185,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
                 adultEntertainment: 'Volwassenenentertainment',
             },
             expenseReportRules: {
-                title: 'Onkostendeclaraties',
+                title: 'Declaraties',
                 subtitle: 'Automatiseer naleving, goedkeuringen en betalingen van onkostendeclaraties.',
                 preventSelfApprovalsTitle: 'Zelfgoedkeuringen voorkomen',
                 preventSelfApprovalsSubtitle: 'Voorkom dat werkruimtedeelnemers hun eigen onkostendeclaraties goedkeuren.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index d2d43c9a..bd1daaf7 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1918,6 +1918,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: 'Rejestruj dane diagnostyczne',
             softKillTheApp: 'Delikatnie zakończ działanie aplikacji',
             kill: 'Zakończ',
+            sentryDebug: 'Debugowanie Sentry',
+            sentryDebugDescription: 'Rejestruj żądania Sentry w konsoli',
+            sentryHighlightedSpanOps: 'Nazwy podświetlonych fragmentów',
+            sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, nawigacja, ui.load',
         },
         debugConsole: {
             saveLog: 'Zapisz log',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 4010d47c..22205cc7 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1917,6 +1917,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: 'Registrar Dados de Solução de Problemas',
             softKillTheApp: 'Encerrar o aplicativo sem forçar',
             kill: 'Encerrar',
+            sentryDebug: 'Depuração do Sentry',
+            sentryDebugDescription: 'Registrar solicitações do Sentry no console',
+            sentryHighlightedSpanOps: 'Nomes de trechos destacados',
+            sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navegação, ui.load',
         },
         debugConsole: {
             saveLog: 'Salvar log',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 8ee1d32a..ed0594ca 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1892,6 +1892,10 @@ const translations: TranslationDeepObject<typeof en> = {
             recordTroubleshootData: '记录故障排查数据',
             softKillTheApp: '软关闭应用',
             kill: '终止',
+            sentryDebug: 'Sentry 调试',
+            sentryDebugDescription: '将 Sentry 请求记录到控制台',
+            sentryHighlightedSpanOps: '高亮显示的跨度名称',
+            sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, 导航, ui.load',
         },
         debugConsole: {
             saveLog: '保存日志',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@huult
Copy link
Copy Markdown
Contributor

huult commented Dec 12, 2025

@dariusz-biela Please take a look at the failing checks

Add sentryDebug, sentryDebugDescription sentryHighlightedSpanOps translations
for de, fr, it, ja, nl, pl, pt-BR, zh-hans. Placeholder kept identical across all languages as it contains technical span operation names.
Copy link
Copy Markdown
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No product review required. Unsubscribing.

@huult
Copy link
Copy Markdown
Contributor

huult commented Dec 12, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2025-12-15.at.10.52.02.mp4
Android: mWeb Chrome
Screen.Recording.2025-12-15.at.10.53.00.mp4
iOS: HybridApp
Screen.Recording.2025-12-15.at.10.55.33.mp4
iOS: mWeb Safari
Screen.Recording.2025-12-15.at.11.17.54.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-12-15.at.10.47.44.mp4

@huult
Copy link
Copy Markdown
Contributor

huult commented Dec 15, 2025

@JmillsExpensify Do we need to add the SentryDebugToolMenu to the test tool modal page? I’ve created an example, as shown in the video below:

Screen.Recording.2025-12-15.at.10.30.53.mov

@huult
Copy link
Copy Markdown
Contributor

huult commented Dec 15, 2025

If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

@dariusz-biela Could you post a Slack message to confirm the translation and share the Slack link?

Comment thread src/components/SentryDebugToolMenu.tsx
@dariusz-biela
Copy link
Copy Markdown
Contributor Author

If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

@dariusz-biela Could you post a Slack message to confirm the translation and share the Slack link?

@huult
Do you think this is necessary?

This UI will never be displayed to a normal user and is only available in the development environment.

I treated adding translations more as a way to satisfy eslint and typecheck.

Copy link
Copy Markdown
Contributor

@huult huult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot melvin-bot Bot requested a review from rlinoz December 15, 2025 11:53
Copy link
Copy Markdown
Contributor

@rlinoz rlinoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rlinoz rlinoz merged commit 24b8ee4 into Expensify:main Dec 15, 2025
32 checks passed
@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.79-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.81-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants