fix: Step 2 missing in Set up tags, categories, and Invite your team#77312
fix: Step 2 missing in Set up tags, categories, and Invite your team#77312nkuoch merged 1 commit intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ All modified and coverable lines are covered by tests. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Yep, makes sense
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-12-13.01-00-26.mp4Android: mWeb Chrome2025-12-13.00-03-07.mp4iOS: HybridAppiOS: mWeb Safari2025-12-13.00-02-05.mp4MacOS: Chrome / Safari2025-12-13.00-00-00.mp4 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/nkuoch in version: 9.2.79-0 🚀
|
|
🚀 Deployed to staging by https://github.com/nkuoch in version: 9.2.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
Explanation of Change
fix: Step 2 missing in Set up tags, categories, and Invite your team
Fixed Issues
$ #76512
PROPOSAL: #76512 (comment)
Tests
Offline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-11.at.12.31.22.mov
Android: mWeb Chrome
Screen.Recording.2025-12-11.at.12.30.47.mov
iOS: Native
Screen.Recording.2025-12-11.at.12.32.01.mov
iOS: mWeb Safari
Screen.Recording.2025-12-11.at.12.31.42.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-11.at.12.20.47.mov