fix: Add domain page reopens when swiping back after entering magic code#77368
Merged
yuwenmemon merged 1 commit intoExpensify:mainfrom Dec 11, 2025
Conversation
…er entering magic code
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-12-11.15.46.18.movAndroid: mWeb Chrome2025-12-11.15.48.28.moviOS: HybridApp2025-12-11.15.42.48.moviOS: mWeb Safari2025-12-11.15.43.42.movMacOS: Chrome / Safari2025-12-11.15.39.38.mov |
Contributor
|
LGTM! |
ZhenjaHorbach
approved these changes
Dec 11, 2025
yuwenmemon
approved these changes
Dec 11, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
Dec 11, 2025
…erify-account-forward-to fix: Add domain page reopens when swiping back after entering magic code (cherry picked from commit b3f2f6e) (cherry-picked to staging by yuwenmemon)
94 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.75-3 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.77-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.78-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes navigation after successful account verification in the add domain flow.
Fixed Issues
$ #77358
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2025-12-11.o.14.35.32.mov
Android: mWeb Chrome
iOS: Native
Nagranie.z.ekranu.2025-12-11.o.14.32.42.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2025-12-11.o.14.19.07.mov