fix: Resolve empty space issue when deleting an expense with Group By filter applied #77393

samranahm · 2025-12-11T15:00:01Z

Explanation of Change

Fixed Issues

$ #77010
PROPOSAL: #77010 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

Create 2+ expenses in workspace chat
Open Reports > Expenses
Open filter page and choose Group by > from
From the group by expenses choose one expense and delete that expense
Reset the Group by filter
After resetting the filter verify no empty space should be created after resetting filter

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android.Native.mov

Android: mWeb Chrome

Android.mWeb.chrome.mov

iOS: Native

IOS.Native.mov

iOS: mWeb Safari

IOS.mWeb.safari.mov

MacOS: Chrome / Safari

macOs.chrome.mov

Copilot

Pull request overview

This PR fixes an issue where empty space appears when deleting an expense with a Group By filter applied. The fix ensures that selected transactions are properly cleared when the groupBy filter changes or is reset.

Key Changes:

Added logic to track previous groupBy value using usePrevious hook
Clear selected transactions when the groupBy filter changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-11T15:05:52Z

src/components/Search/index.tsx

+    useEffect(() => {
+        if (prevValidGroupBy === validGroupBy) {
+            return;
+        }
+        clearSelectedTransactions();
+    }, [validGroupBy, prevValidGroupBy, clearSelectedTransactions]);


Consider adding a test case to verify that selected transactions are cleared when the groupBy filter changes. While the implementation is correct, test coverage would help prevent regressions of this fix in the future.

codecov · 2025-12-11T15:08:38Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Search/index.tsx	`32.69% <80.00%> (+0.57%)`	⬆️
... and 10 files with indirect coverage changes

samranahm · 2025-12-17T12:44:39Z

@mananjadhav Friendly bump for review.

mananjadhav · 2025-12-17T21:11:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-empty-space-group.mov

Android: mWeb Chrome

mweb-chrome-empty-space-group.mov

iOS: HybridApp

iOS: mWeb Safari

mweb-safari-empty-space-group.mov

MacOS: Chrome / Safari

web-empty-space-group.mov

mananjadhav · 2025-12-17T22:08:06Z

I am having issues with iOS build.

mananjadhav · 2025-12-21T05:49:56Z

@heyjennahay @srikarparsi Quick bump on the PR.

heyjennahay

Happy with product change

samranahm · 2025-12-23T22:26:49Z

@srikarparsi Gentle bump.

mananjadhav · 2025-12-30T17:51:30Z

@srikarparsi This one's been waiting for you.

OSBotify · 2026-01-06T04:41:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-06T14:09:13Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.94-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…n-deleting-expense fix: Resolve empty space issue when deleting an expense with Group By filter applied

OSBotify · 2026-01-07T13:40:05Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.94-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: resolve empty space issue on expense deletion

0794edb

Copilot AI review requested due to automatic review settings December 11, 2025 15:00

samranahm requested review from a team as code owners December 11, 2025 15:00

melvin-bot bot assigned samranahm Dec 11, 2025

melvin-bot bot requested review from heyjennahay, mananjadhav and srikarparsi December 11, 2025 15:00

Copilot started reviewing on behalf of samranahm December 11, 2025 15:00 View session

samranahm mentioned this pull request Dec 11, 2025

[Due for payment 2026-01-14] [$250] Android-Reports-Empty space seen when deleting expense on "Group-by" filter and resetting it #77010

Open

8 tasks

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Merge branch 'Expensify:main' into 77010/empty-space-on-deleting-expense

f6f5b22

mananjadhav approved these changes Dec 17, 2025

View reviewed changes

heyjennahay approved these changes Dec 22, 2025

View reviewed changes

heyjennahay removed the request for review from a team December 22, 2025 23:34

Merge branch 'Expensify:main' into 77010/empty-space-on-deleting-expense

0ab9b9b

srikarparsi approved these changes Jan 6, 2026

View reviewed changes

srikarparsi merged commit f0a5619 into Expensify:main Jan 6, 2026
30 checks passed

OSBotify mentioned this pull request Jan 6, 2026

Deploy Checklist: New Expensify 2026-01-06 #78900

Closed

53 tasks

nlemma mentioned this pull request Jan 6, 2026

[$250] Filter- Delete option is not available in group-by filter #78929

Open

7 tasks

abzokhattab pushed a commit to abzokhattab/App that referenced this pull request Jan 6, 2026

Merge pull request Expensify#77393 from samranahm/77010/empty-space-o…

5de32b9

…n-deleting-expense fix: Resolve empty space issue when deleting an expense with Group By filter applied

fix: Resolve empty space issue when deleting an expense with Group By filter applied #77393

fix: Resolve empty space issue when deleting an expense with Group By filter applied #77393

Uh oh!

Conversation

samranahm commented Dec 11, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samranahm commented Dec 17, 2025

Uh oh!

mananjadhav commented Dec 17, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Dec 17, 2025

Uh oh!

mananjadhav commented Dec 21, 2025

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

samranahm commented Dec 23, 2025

Uh oh!

mananjadhav commented Dec 30, 2025

Uh oh!

Uh oh!

OSBotify commented Jan 6, 2026

Uh oh!

OSBotify commented Jan 6, 2026

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Dec 11, 2025 •

edited by github-actions bot

Loading