Remove deprecated report name functions in ReportUtils (Part 1) #77614

lorretheboy · 2025-12-13T14:46:20Z

Explanation of Change

Scope of changes:

Renamed computeReportName to computeReportNameWithoutFormula

Deleted functions:

getInvoiceReportName
getMoneyRequestReportName
getInvoicesChatName
getInvoicePayerName
getPolicyExpenseChatName
getGroupChatName
buildReportNameFromParticipantNames

Fixed Issues

$ #76852
PROPOSAL: #76852 (comment)

Tests

Test 01:

Login to ND
Create WS
Create expense
Verify that expense name is shown correctly (preview, details)

Test 02:

Login to ND
Create group chat
Verify that group chat name is shown correctly

Test 03:

Login to ND
Send an invoice
Verify that we can send invoice and invoice name is correct

Test 04:

Login to ND
Go to Reports --> Explore Reports
Verify that reports preview names are display correctly

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

WEBSITE.ANDROID.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

WEBSITE.IOS.mov

MacOS: Chrome / Safari

WEBSITE-04.mov

WEBSITE-03.mov

WEBSITE-04.mov

codecov · 2025-12-13T14:54:33Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ModifiedExpenseMessage.ts	`53.42% <ø> (ø)`
src/libs/ReportNameUtils.ts	`83.27% <ø> (+0.68%)`	⬆️
src/libs/ReportUtils.ts	`72.80% <100.00%> (-0.13%)`	⬇️
... and 11 files with indirect coverage changes

melvin-bot · 2025-12-13T15:32:34Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-12-13T15:33:04Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

waterim

LGTM, code-wise looks good.
Thanks for splitting this, reviews are much easier now

grgia

mostly looks good, a few minor comments

grgia · 2025-12-15T17:23:45Z

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

@@ -1,5 +1,5 @@
 import type {OnyxEntry} from 'react-native-onyx';
-import {computeReportName} from '@libs/ReportNameUtils';
+import {computeReportNameWithoutFormula} from '@libs/ReportNameUtils';


this function name isn't intuitive, why rename it?

Yeah. It is also one of the requirement from original issue

Yes, I'm fine to rename it, but in reading it here, computeReportNameWithoutFormula is not clear. What do you think?

@grgia bth, both names are ok to me. The current name is a bit more specific and I would prefer to keep the current one. However, I'm happy to hear others' thoughts

src/libs/ModifiedExpenseMessage.ts

src/libs/ReportUtils.ts

lorretheboy · 2025-12-21T16:19:15Z

Checking it now...

lorretheboy · 2025-12-22T11:45:50Z

Conflicts and failed tests are resolved

heyjennahay · 2025-12-24T11:36:39Z

No product change. Removing product reviewer

neil-marcellini

The code looks good thanks. Before we merge we need to fix conflicts.

I agree with @grgia that the name isn't very intuitive. computeReportNameWithoutFormula implies the existence of computeReportName, but if we're just renaming it, this will be the only computeReportName, so it's kind of implied it's without formula.

That makes sense to me, let's leave it as computeReportName. We will be calling Formula.compute to generate the optimistic report names upon creation soon with this issue Optimistically compute report names on creation, but I think it's clear what the difference is.

Also, if we don't rename the function the diff will be way smaller which is good.

github-actions · 2026-01-01T18:08:05Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

lorretheboy · 2026-01-01T18:21:30Z

Sorry for the force push, I have to force push to solve the un-signed commit issue

neil-marcellini · 2026-01-01T18:30:54Z

@lorretheboy is this ready for another review now?

lorretheboy · 2026-01-01T18:32:04Z

@neil-marcellini Yes, I'm waiting for pipelines to ping for review again. Once all done, it is good to re-review

neil-marcellini

Great thanks!

eVoloshchak · 2026-01-02T10:55:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-02.at.11.52.13.mov

Android: mWeb Chrome

Screen.Recording.2026-01-02.at.11.54.21.mov

iOS: HybridApp

Screen.Recording.2026-01-02.at.11.44.05.mov

iOS: mWeb Safari

Screen.Recording.2026-01-02.at.11.47.37.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-02.at.11.41.14.mov

eVoloshchak

LGTM!

OSBotify · 2026-01-02T16:45:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-02T23:30:27Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.92-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-05T16:00:36Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.92-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Remove deprecated report name functions in ReportUtils (Part 1)

lorretheboy added 11 commits December 8, 2025 20:08

chore: merge main

65cd64b

chore: rename func

3d2f120

fix: remove getGroupChatName

0d03405

fix: remove getPolicyExpenseChatName

d8c0d9c

fix: remove getMoneyRequestReportName

d2bd8f9

fix: remove getInvoicePayerName

75f60dc

fix: remove getInvoicesChatName

34d6e28

fix: remove buildReportNameFromParticipantNames

6120b35

fix: remove getInvoiceReportName

8c07320

fix: generateArchivedReportName

95fbdf9

chore: merge main

f077c0e

melvin-bot bot assigned lorretheboy Dec 13, 2025

lorretheboy added 2 commits December 13, 2025 22:55

fix: cycle linter issue

f8032f3

fix: linter

2c870f4

lorretheboy marked this pull request as ready for review December 13, 2025 15:32

lorretheboy requested review from a team as code owners December 13, 2025 15:32

melvin-bot bot requested review from eVoloshchak and heyjennahay December 13, 2025 15:32

melvin-bot bot requested review from a team and grgia and removed request for a team December 13, 2025 15:32

melvin-bot bot removed the request for review from a team December 13, 2025 15:33

lorretheboy mentioned this pull request Dec 13, 2025

[Due for payment 2026-01-12] Remove deprecated report name functions in ReportUtils #76852

Open

1 task

waterim approved these changes Dec 15, 2025

View reviewed changes

grgia reviewed Dec 15, 2025

View reviewed changes

lorretheboy added 2 commits December 22, 2025 18:29

chore: resolve conflicts

2cdde37

fix: types

5a1712d

heyjennahay removed their request for review December 24, 2025 11:36

neil-marcellini self-requested a review December 30, 2025 22:30

neil-marcellini previously approved these changes Dec 30, 2025

View reviewed changes

lorretheboy dismissed neil-marcellini’s stale review via 9e97f63 January 1, 2026 18:06

lorretheboy force-pushed the fix-pr-1/76852 branch from 9e97f63 to b645eea Compare January 1, 2026 18:07

lorretheboy requested a review from a team as a code owner January 1, 2026 18:07

fix: conflicts

aaffc34

lorretheboy force-pushed the fix-pr-1/76852 branch from b645eea to aaffc34 Compare January 1, 2026 18:14

lorretheboy added 2 commits January 2, 2026 01:17

fix: revert changes

fd914c9

fix: revert changes

39c7424

neil-marcellini approved these changes Jan 1, 2026

View reviewed changes

eVoloshchak approved these changes Jan 2, 2026

View reviewed changes

melvin-bot bot requested a review from neil-marcellini January 2, 2026 11:11

neil-marcellini merged commit 053998f into Expensify:main Jan 2, 2026
29 of 30 checks passed

OSBotify mentioned this pull request Jan 2, 2026

Deploy Checklist: New Expensify 2026-01-02 #78798

Closed

17 tasks

jponikarchuk mentioned this pull request Jan 3, 2026

Invoice - Invoice report title on the preview does not match it in the header and report field #78805

Open

7 tasks

abzokhattab pushed a commit to abzokhattab/App that referenced this pull request Jan 6, 2026

Merge pull request Expensify#77614 from lorretheboy/fix-pr-1/76852

f8cddb1

Remove deprecated report name functions in ReportUtils (Part 1)

Remove deprecated report name functions in ReportUtils (Part 1) #77614

Remove deprecated report name functions in ReportUtils (Part 1) #77614

Conversation

lorretheboy commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 13, 2025

Uh oh!

melvin-bot bot commented Dec 13, 2025

Uh oh!

waterim left a comment

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

grgia Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lorretheboy commented Dec 21, 2025

Uh oh!

lorretheboy commented Dec 22, 2025

Uh oh!

heyjennahay commented Dec 24, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 1, 2026

Uh oh!

lorretheboy commented Jan 1, 2026

Uh oh!

neil-marcellini commented Jan 1, 2026

Uh oh!

lorretheboy commented Jan 1, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 2, 2026

Uh oh!

OSBotify commented Jan 2, 2026

Uh oh!

OSBotify commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

lorretheboy commented Dec 13, 2025 •

edited

Loading

codecov bot commented Dec 13, 2025 •

edited by github-actions bot

Loading

eVoloshchak commented Jan 2, 2026 •

edited

Loading