Skip to content

[CP Prod] Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual"#77674

Merged
MonilBhavsar merged 2 commits intomainfrom
revert-76799-fix/74911
Dec 16, 2025
Merged

[CP Prod] Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual"#77674
MonilBhavsar merged 2 commits intomainfrom
revert-76799-fix/74911

Conversation

@MonilBhavsar
Copy link
Copy Markdown
Contributor

@MonilBhavsar MonilBhavsar commented Dec 15, 2025 •
edited
Loading

Reverts #76799
Fixes #77606

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 15, 2025

🚧 @MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025 •
edited by github-actions Bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/iou/request/IOURequestStartPage.tsx 86.48% <100.00%> (-0.19%) ⬇️
... and 11 files with indirect coverage changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 15, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #77674.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/77674/index.html ⏩ SKIPPED ⏩
Android The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://77674.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@AndrewGable AndrewGable marked this pull request as ready for review December 16, 2025 00:09
@AndrewGable AndrewGable requested review from a team as code owners December 16, 2025 00:09
@melvin-bot melvin-bot Bot requested review from arosiclair and joekaufmanexpensify and removed request for a team December 16, 2025 00:09
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Dec 16, 2025

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team December 16, 2025 00:09
@AndrewGable
Copy link
Copy Markdown
Contributor

AndrewGable commented Dec 16, 2025

Not sure why tests are failing, I tried merging main but they continue to fail.

@MonilBhavsar
Copy link
Copy Markdown
Contributor Author

MonilBhavsar commented Dec 16, 2025

Flaky tests may be. Passing now

@MonilBhavsar MonilBhavsar changed the title Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual" [CP Staging] Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual" Dec 16, 2025
@MonilBhavsar
Copy link
Copy Markdown
Contributor Author

MonilBhavsar commented Dec 16, 2025

Thanks!

@MonilBhavsar MonilBhavsar merged commit 08f7d35 into main Dec 16, 2025
41 of 45 checks passed
@MonilBhavsar MonilBhavsar deleted the revert-76799-fix/74911 branch December 16, 2025 07:01
@melvin-bot melvin-bot Bot added the Emergency label Dec 16, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Dec 16, 2025

@MonilBhavsar looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@MonilBhavsar
Copy link
Copy Markdown
Contributor Author

MonilBhavsar commented Dec 16, 2025

A straight revert PR

@github-actions github-actions Bot mentioned this pull request Dec 16, 2025
Closed
@OSBotify OSBotify mentioned this pull request Dec 16, 2025
Closed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Dec 16, 2025

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.79-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@os-botify os-botify Bot mentioned this pull request Dec 17, 2025
Closed
51 tasks
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 17, 2025
@mountiny mountiny removed the CP Staging marks PRs that have been CP'd to staging label Dec 17, 2025
@mountiny mountiny changed the title [CP Staging] Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual" Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual" Dec 17, 2025
@mountiny mountiny changed the title Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual" [CP Prod] Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual" Dec 17, 2025
OSBotify pushed a commit that referenced this pull request Dec 17, 2025
@MonilBhavsar @OSBotify
Merge pull request #77674 from Expensify/revert-76799-fix/74911
abbb516 
[CP Staging] Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual"

(cherry picked from commit 08f7d35)

(cherry-picked to production by mountiny)
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Dec 17, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.80-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Dec 17, 2025

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.81-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mountiny mountiny mentioned this pull request Jan 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertjchen robertjchen robertjchen approved these changes

@joekaufmanexpensify joekaufmanexpensify Awaiting requested review from joekaufmanexpensify

@arosiclair arosiclair Awaiting requested review from arosiclair

Assignees

@MonilBhavsar MonilBhavsar

Labels

CP Production Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android – Add Expense (Camera Icon) – Incorrect Redirect After Selecting Recipient

5 participants

@MonilBhavsar @AndrewGable @OSBotify @robertjchen @mountiny