Skip to content

Conversation

@stephanieelliott
Copy link
Contributor

@stephanieelliott stephanieelliott commented Dec 15, 2025

@github-actions github-actions bot changed the title [HOLD] Create Troubleshoot-Expensify-Card.md [No QA] [HOLD] Create Troubleshoot-Expensify-Card.md Dec 15, 2025
@OSBotify
Copy link
Contributor

OSBotify commented Dec 15, 2025

A preview of your ExpensifyHelp changes have been deployed to https://0d5ddaca.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott marked this pull request as ready for review December 31, 2025 09:05
@stephanieelliott stephanieelliott requested a review from a team as a code owner December 31, 2025 09:05
@melvin-bot
Copy link

melvin-bot bot commented Dec 31, 2025

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot melvin-bot bot requested review from bfitzexpensify and removed request for a team December 31, 2025 09:05
@melvin-bot
Copy link

melvin-bot bot commented Dec 31, 2025

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a new troubleshooting guide for Expensify Card issues. The document is well-structured, user-focused, and provides clear step-by-step guidance for resolving common card problems. The content demonstrates strong readability with logical flow and helpful role-based sections. However, there are several opportunities to improve AI readiness through more descriptive headings and enhance style compliance with Expensify terminology standards.

Scores Summary

  • Readability: 9/10 - Excellent clarity and logical organization with clear navigation instructions and well-structured troubleshooting steps. Minor improvement: some sentences could be slightly more concise.
  • AI Readiness: 6/10 - Good YAML metadata and breadcrumb structure, but headings lack specificity. Many section headings use pronouns ("your") or generic terms that would make content harder to discover through AI search.
  • Style Compliance: 7/10 - Generally follows Expensify style with proper terminology (Workspace Admin, workspace), but some inconsistencies exist in navigation patterns and button terminology.

Key Findings

Strengths:

  • Clear role-based organization (Cardholders vs Workspace Admins)
  • Comprehensive coverage of common issues with actionable solutions
  • Consistent navigation instructions using "navigation tabs on the left/bottom" pattern
  • Well-structured FAQ section addressing additional user questions
  • Good use of Smart Limit, Monthly limit, and Fixed amount terminology
  • Proper YAML metadata with descriptive keywords

Areas for Improvement:

  1. Heading Specificity (AI Readiness): Many headings use possessive pronouns that reduce searchability:

    • "Your Expensify Card hasn't been activated" → "Expensify Card not activated"
    • "You've reached your card's spend limit" → "Expensify Card spend limit reached"
    • "Your workspace's domain limit has run out" → "Workspace domain limit exhausted"
  2. Navigation Terminology (Style Compliance): Inconsistent patterns across documentation:

    • Uses "navigation tabs on the left" and "navigation tabs at the bottom"
    • Compare to Set-Up-and-Manage-the-Expensify-Card.md which uses "From the navigation tabs (on the left on web, and at the bottom on mobile)"
    • Consider standardizing to match established patterns
  3. Button Label Clarity: "Fix" button mentioned without full context - consider specifying appearance/location more clearly

  4. Domain Limit Terminology: "Domain limit" is used throughout but may benefit from brief clarification since it's workspace-level, not individual card-level

  5. Link Reference: The locked bank account link uses parenthetical notation correctly but points to future content (Unlock-a-Business-Bank-Account)

Recommendations

High Priority:

  1. Revise headings to remove possessive pronouns and make them more searchable/AI-friendly
  2. Standardize navigation instructions to match existing documentation patterns
  3. Add brief parenthetical explanation for "domain limit" on first use

Medium Priority:
4. Consider adding a brief introductory sentence about what Smart Limit means in the "card's spend limit" section
5. Ensure "Fix" button description includes visual cues or placement details
6. Review FAQ heading style - consider whether "How can I..." vs "How do I..." is the standard

Low Priority:
7. Consider adding cross-references to related troubleshooting articles
8. Minor sentence structure optimization for brevity in a few places

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Troubleshoot-Expensify-Card.md - New file with strong foundation but needs heading optimization for AI discoverability and navigation pattern consistency

Note: This is a summary assessment. The document is production-ready with minor revisions recommended for optimal AI search performance and style consistency.

@stephanieelliott
Copy link
Contributor Author

Applied all relevant suggestions form the review bot!

@stephanieelliott stephanieelliott changed the title [No QA] [HOLD] Create Troubleshoot-Expensify-Card.md [No QA] Create Troubleshoot-Expensify-Card.md Dec 31, 2025
@bfitzexpensify
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing
    • I verified proper file naming conventions were followed for any new files or renamed files
    • I verified the JSDocs style guidelines were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again
  • I verified all code is DRY
  • I verified any variables that can be defined as constants are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist
    • All props are defined accurately and documented
    • The file is named correctly
    • The component name is clear and non-ambiguous
    • State only contains data necessary for rendering
    • All JSX used for rendering exists in the render method
    • The component is broken down appropriately to separate concerns
  • If any new file was added I verified that:
    • The file has a description at the top explaining its purpose
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function
  • If the PR modifies code that runs when editing or sending messages, I verified no unexpected markdown behavior
  • If the PR modifies a generic component, I verified it does not break other usages
  • If the PR modifies a component with Storybook stories, I verified all stories still work
  • If the PR modifies a deeplinked page, I verified it works for logged-in and logged-out users
  • If the PR modifies the UI:
    • Inputs are properly aligned
    • Design was tagged or reviewed
  • If a new page is added, it uses ScrollView
  • I verified sufficient unit tests were added
  • If main was merged after review, I tested again
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@bfitzexpensify bfitzexpensify merged commit 40dbb46 into main Jan 2, 2026
12 of 13 checks passed
@bfitzexpensify bfitzexpensify deleted the stephanieelliott-patch-23 branch January 2, 2026 15:01
@melvin-bot melvin-bot bot added the Emergency label Jan 2, 2026
@melvin-bot
Copy link

melvin-bot bot commented Jan 2, 2026

@bfitzexpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 2, 2026

🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.2.92-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 5, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.92-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

abzokhattab pushed a commit to abzokhattab/App that referenced this pull request Jan 6, 2026
…tch-23

[No QA] Create Troubleshoot-Expensify-Card.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants