-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix: Expense - Get "Hmm... it's not here" after split and move expense to personal space #77911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
970c107 to
61789df
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
Reassigning to @FitseTLT for review as C+ on the issue and unsubscribing 😄 |
|
@cristianstoichin u need to add snapshots for all platforms. |
Hello @FitseTLT I've added platform specific recordings. Please let me know if I missed anything. thank you. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely something we want to address. Product approved.
|
Hello @FitseTLT , is this something you can review please? thanks |
|
@cristianstoichin Can u pls merge main? Thx |
|
@cristianstoichin please update the test step to:
|
Done. |
@FitseTLT this is done. Thanks |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-01-02.20-19-00.mp4Android: mWeb Chrome2026-01-02.23-32-32.mp4iOS: HybridApp2026-01-02.21-27-24.mp4iOS: mWeb Safari2026-01-02.23-30-17.mp4MacOS: Chrome / Safari2026-01-02.23-28-40.mp4 |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.94-0 🚀
|
Fix: Expense - Get "Hmm... it's not here" after split and move expense to personal space
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.94-4 🚀
|
Explanation of Change
Fixed Issues
$#75472
PROPOSAL:#75472 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-17.at.5.37.05.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-12-17.at.5.14.07.PM.mov
iOS: Native
Screen.Recording.2025-12-17.at.4.44.57.PM.mov
iOS: mWeb Safari
Screen.Recording.2025-12-17.at.4.51.39.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-17.at.10.34.29.AM.mov