[Release 2] [Domain Control] Close domain member account by jmusial · Pull Request #78002 · Expensify/App

jmusial · 2025-12-18T16:19:58Z

Explanation of Change

Part for Domain Control project. This PR adds closing member account with GBR and RBR flows. For now it features single modal confirmation, pending discussion.

For the flow preview please refer to MacOS: Chrome / Safari

Fixed Issues

$ #79358 PROPOSAL:

Tests

Go to the Domain-> Members ( dev.new.expensify.com:8082/domain/[DomainID]/members/)
Click on a user and open their Details.
Click Close account.
(A decision modal should appear with two options: Force close and Safely close.
Repeat the scenario on two different accounts to verify both options.)
After selecting one of the options, the account should be deleted.

Verify that no errors appear in the JS console

Offline tests

Repeat the steps from the test section above while in offline state and verify whether a pending delete action remains under the member.

QA Steps

1. Navigate to Domain → Members
(dev.new.expensify.com:8082/domain/[DomainID]/members/).

2. Select a member and open their Details view.

3. Click Close account.

4. Verify that a decision modal appears with two options:

5. Force close

6. Safely close

7. Execute the flow on two different accounts, selecting a different option each time, and verify that:

8. The selected account is successfully deleted.

9. Confirm that no errors appear in the JS console.

Offline verification:
7. Repeat steps 1–5 while the application is in offline mode.
8. Verify that a pending delete action is visible under the member while offline

PR Author Checklist

Screenshots/Videos

Android: Native

Refer to MacOS: Chrome / Safari

Android: mWeb Chrome

Refer to MacOS: Chrome / Safari

iOS: Native

Refer to MacOS: Chrome / Safari

iOS: mWeb Safari

Refer to MacOS: Chrome / Safari

MacOS: Chrome / Safari

Close.acc.POC.mov

melvin-bot · 2025-12-18T16:20:04Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-12-19T15:57:48Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/DecisionModal.tsx	`100.00% <100.00%> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/actions/Domain.ts	`31.96% <100.00%> (+6.74%)`	⬆️
src/pages/domain/Admins/DomainAdminDetailsPage.tsx	`0.00% <ø> (ø)`
.../pages/domain/BaseDomainMemberDetailsComponent.tsx	`0.00% <ø> (ø)`
src/pages/domain/BaseDomainMembersPage.tsx	`0.00% <ø> (ø)`
src/selectors/PersonalDetails.ts	`80.00% <100.00%> (+5.00%)`	⬆️
src/selectors/Domain.ts	`90.56% <94.11%> (+1.37%)`	⬆️
src/pages/domain/Members/DomainMembersPage.tsx	`0.00% <0.00%> (ø)`
...c/pages/domain/Members/DomainMemberDetailsPage.tsx	`0.00% <0.00%> (ø)`
... and 161 files with indirect coverage changes

OSBotify · 2026-01-20T10:15:57Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

The diff is too large to include in this comment (119KB), so I've created a gist for you:

📋 View the translation diff here 📋

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply, or directly by running gh gist view --raw fee9857a0ee60b23c3c2d872d9ad7f52 | git apply 😉

jmusial · 2026-02-04T11:55:38Z

@ZhenjaHorbach last commit fixes it

Screen.Recording.2026-02-04.at.12.54.03.mov

ZhenjaHorbach · 2026-02-04T12:02:08Z

Perfect
Thanks!
Looks good from my side

melvin-bot · 2026-02-04T12:02:36Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to # as well as to this PR... Please reach out for help on Slack if no one gets assigned!

situchan · 2026-02-04T15:54:46Z

src/languages/en.ts

+            forceCloseAccount: 'Force close account',
+            safeCloseAccount: 'Close account safely',
+            closeAccountInfo:
+                'We recommend closing the account safely to skip closing it in case there are: <ul><li>Pending approvals</li><li>Active reimbursements</li><li>No alternative login methods</li></ul> Otherwise, you can ignore the safety precautions above and force close the selected account.',


Super minor one. There's space before Otherwise

…' into feat/domain-member-close-account

mountiny · 2026-02-04T17:15:38Z

src/components/DecisionModal.tsx

+    isFirstOptionSuccess = true,
+    isSecondOptionSuccess = false,
+    isSecondOptionDanger = false,
+}: DecisionModalProps) {


Ok but lets follow up on this one! @sumo-slonik can you please create an issue for the PR you made with explanation of the motivation behind it?

NikkiWines

one small typo, otherwise looks good 👍

NikkiWines · 2026-02-04T17:49:05Z

src/libs/actions/Domain.ts

+ * Adds a member to a domain
+ * @param domainAccountID Account ID of a domain
+ * @param email Email of a user to be added
+ * @param defaultSecurityGroupID Security group ip to be used for optimistic updates


Suggested change

* @param defaultSecurityGroupID Security group ip to be used for optimistic updates

* @param defaultSecurityGroupID Security group ID to be used for optimistic updates

NikkiWines · 2026-02-04T17:50:35Z

src/pages/domain/Members/DomainMemberDetailsPage.tsx

+    const icons = useMemoizedLazyExpensifyIcons(['RemoveMembers']);
+    const [isModalVisible, setIsModalVisible] = useState(false);
+    const [shouldForceCloseAccount, setShouldForceCloseAccount] = useState<boolean>();
+    // we need to use isSmallScreenWidth here because the DecisionModal is opening from RHP and ShouldUseNarrowLayout layout will not work in this place


NAB:

Suggested change

// we need to use isSmallScreenWidth here because the DecisionModal is opening from RHP and ShouldUseNarrowLayout layout will not work in this place

// We need to use isSmallScreenWidth here because the DecisionModal is opening from RHP and ShouldUseNarrowLayout layout will not work in this place

NikkiWines

👍

melvin-bot · 2026-02-05T14:58:05Z

@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-02-05T15:02:36Z

🚧 @NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

NikkiWines · 2026-02-05T15:04:48Z

tests were passing 👍

github-actions · 2026-02-05T15:08:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #78002.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-01941ae-2e219f78ca3bc5337bdb26c14e30c9994ec2829b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-01941ae-403a7d4b5b86c5a9d928e38f36d0492881f3b878/index.html

Web 🕸️
https://78002.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-05T20:45:57Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:46:23Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Decision modal for on close account

105f463

melvin-bot bot assigned jmusial Dec 18, 2025

jmusial added 3 commits December 19, 2025 15:26

Merge branch 'main' into feat/domain-member-close-account

cae53c0

add dev buttons update action handlers

29a1b2a

Merge branch 'main' into feat/domain-member-close-account

c911a12

jmusial added 3 commits December 22, 2025 11:37

Merge branch 'main' into feat/domain-member-close-account

395608f

code cleanup

2006575

update with RBR and pending

0a94209

jmusial changed the title ~~Feat/domain member close account~~ [Release 2] [Domain Control] Close domain member account Dec 22, 2025

Merge branch 'main' into feat/domain-member-close-account

5044ec0

jmusial changed the title ~~[Release 2] [Domain Control] Close domain member account~~ [HOLD] [Release 2] [Domain Control] Close domain member account Dec 22, 2025

jmusial added 5 commits December 23, 2025 17:47

Merge branch 'main' into feat/domain-member-close-account

953c767

Merge branch 'main' into feat/domain-member-close-account

2df3b19

Merge branch 'main' into feat/domain-member-close-account

7a5b50d

Cleanup after merge

23a4ee9

Merge branch 'main' into feat/domain-member-close-account

b572b62

jmusial moved this to In Progress in Bring Domain Control to NewDot Jan 14, 2026

jmusial added this to Bring Domain Control to NewDot Jan 14, 2026

jmusial added 9 commits January 14, 2026 16:59

Merge branch 'main' into feat/domain-member-close-account

2b9b0ee

Merge branch 'main' into feat/domain-member-close-account

4ca3eac

add a second modal confirm modal

58b92f7

cleanup

c538487

prettier fix

0f41e23

Merge branch 'main' into feat/domain-member-close-account

c999814

use BaseDomainMemberPage

44549c1

add test

c41472d

fix lint

ed8b441

fix offline close account row visibility

85a9bb5

ZhenjaHorbach approved these changes Feb 4, 2026

View reviewed changes

rayane-d mentioned this pull request Feb 4, 2026

[Domain Control] [Release 3.6] Bulk close members' accounts #79572

Open

jmusial requested a review from mountiny February 4, 2026 12:57

situchan approved these changes Feb 4, 2026

View reviewed changes

JS00001 previously approved these changes Feb 4, 2026

View reviewed changes

situchan reviewed Feb 4, 2026

View reviewed changes

war-in added 3 commits February 4, 2026 18:10

Merge branch 'main' into feat/domain-member-close-account

7767275

fix: remove unwanted space from translations

8173c34

Merge remote-tracking branch 'origin/feat/domain-member-close-account…

3ce78ff

…' into feat/domain-member-close-account

war-in dismissed JS00001’s stale review via 3ce78ff February 4, 2026 17:13

mountiny previously approved these changes Feb 4, 2026

View reviewed changes

NikkiWines requested changes Feb 4, 2026

View reviewed changes

fix typos

4b4d31d

jmusial dismissed mountiny’s stale review via 4b4d31d February 5, 2026 09:06

NikkiWines approved these changes Feb 5, 2026

View reviewed changes

NikkiWines merged commit 01941ae into Expensify:main Feb 5, 2026
42 of 56 checks passed

github-project-automation bot moved this from In Progress to Done in Bring Domain Control to NewDot Feb 5, 2026

melvin-bot bot added the Emergency label Feb 5, 2026

NikkiWines removed the Emergency label Feb 5, 2026

OSBotify mentioned this pull request Feb 5, 2026

Deploy Checklist: New Expensify 2026-02-05 #81590

Open

	* @param defaultSecurityGroupID Security group ip to be used for optimistic updates
	* @param defaultSecurityGroupID Security group ID to be used for optimistic updates

	// we need to use isSmallScreenWidth here because the DecisionModal is opening from RHP and ShouldUseNarrowLayout layout will not work in this place

	// We need to use isSmallScreenWidth here because the DecisionModal is opening from RHP and ShouldUseNarrowLayout layout will not work in this place

Conversation

jmusial commented Dec 18, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 18, 2025

Uh oh!

codecov bot commented Dec 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OSBotify commented Jan 20, 2026

🦜 Polyglot Parrot! 🦜

Uh oh!

jmusial commented Feb 4, 2026

Uh oh!

ZhenjaHorbach commented Feb 4, 2026

Uh oh!

melvin-bot bot commented Feb 4, 2026

Uh oh!

situchan Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

war-in Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiWines Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

NikkiWines commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

jmusial commented Dec 18, 2025 •

edited by mountiny

Loading

codecov bot commented Dec 19, 2025 •

edited by github-actions bot

Loading