-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Migrate icons navigations, arrows, and avatars to lazy loading #78242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@eh2077 appreciate your quick review since conflicts happen very often |
|
I'll prioritize review tmr |
|
How's the review going on this one, @eh2077? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-05.at.11.52.02.PM.movAndroid: mWeb ChromeScreen.Recording.2026-01-05.at.11.52.50.PM.moviOS: HybridAppScreen.Recording.2026-01-05.at.11.50.36.PM.moviOS: mWeb SafariScreen.Recording.2026-01-05.at.11.51.31.PM.movMacOS: Chrome / SafariScreen.Recording.2026-01-05.at.11.48.10.PM.mov |
eh2077
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the way to handle default fallback icon with ?? operator won't change existing function, so looks good to me!
mollfpr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.94-0 🚀
|
Migrate icons navigations, arrows, and avatars to lazy loading
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.94-4 🚀
|
Explanation of Change
Migrate the following icons to use the lazy loading system:
Fixed Issues
$ #75252
PROPOSAL: #75252 (comment)
Tests
Case 1: (#75930 #75931)
Case 2: (#75941 android only)
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
android2.mov
Android: mWeb Chrome
android.chrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios.safari.mov
MacOS: Chrome / Safari
web.mov