Add delegate access restriction checks to approval, payment, reject and hold #78300

mukhrr · 2025-12-22T17:33:15Z

Explanation of Change

Fixed Issues

$ #75171
#77609
PROPOSAL: #75171 (comment)

Tests

Precondition:
User A has added User B as copilot with Limited access level.

[User A] Go to workspace chat.
[User A] Create an expense and click Submit button.
[User A] Create another expense, click Submit and Approve button.
[User B] Go to Account.
[User B] Open account switcher and switch to User A account.
[User B] Go to Inbox and open User A's workspace chat.
[User B] Perform approval, payment, reject and hold actions on the expenses while on Inbox.
→ Verify Copilot is presented with "Not so fast" modal because copilot with Limited access level cannot perform approval, payment, reject and hold action on the expenses.
[User B] Go to Reports > Reports.
[User B] Click Approve and Pay button on the reports row.
→ Verify Copilot is presented with "Not so fast" modal
[User B] Select the report that is pending approval via checkbox > click dropdown button > Hold.
→ Verify Copilot is presented with "Not so fast" modal
[User B] Try to approve, hold and reject multiple (bulk) expenses
→ Verify Copilot is presented with "Not so fast" modal

Verify that no errors appear in the JS console

Offline tests

QA Steps

The same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…earch and money request flows

melvin-bot · 2025-12-22T17:34:44Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-22T17:43:22Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...nListWithSections/Search/ExpenseReportListItem.tsx	`0.00% <ø> (ø)`
...onListWithSections/Search/ReportListItemHeader.tsx	`94.59% <ø> (ø)`
src/components/MoneyRequestHeader.tsx	`0.00% <0.00%> (ø)`
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	`68.12% <50.00%> (+68.12%)`	⬆️
...ts/SelectionListWithSections/Search/ActionCell.tsx	`54.00% <0.00%> (-1.11%)`	⬇️
...ionListWithSections/Search/TransactionListItem.tsx	`0.00% <0.00%> (ø)`
src/pages/Search/SearchSelectedNarrow.tsx	`0.00% <0.00%> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
src/components/SettlementButton/index.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/Search.ts	`20.60% <9.09%> (+10.55%)`	⬆️
... and 1 more
... and 165 files with indirect coverage changes

DylanDylann · 2025-12-24T07:44:05Z

src/pages/Search/SearchPage.tsx

                        return;
                    }

+                    if (isDelegateAccessRestricted) {


@mukhrr This change is for regression, Is there any other changes?

Yes, this is the only one which #77609 mentioned

DylanDylann · 2025-12-24T07:56:37Z

src/libs/actions/Search.ts

+    } = params;
+
+    // If delegate access is restricted, we should not allow bulk pay with business bank account or bulk pay
+    if (isDelegateAccessRestricted && 'value' in item && (item.value === CONST.IOU.PAYMENT_TYPE.ELSEWHERE || item.value === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT)) {


Suggested change

if (isDelegateAccessRestricted && 'value' in item && (item.value === CONST.IOU.PAYMENT_TYPE.ELSEWHERE || item.value === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT)) {

if (isDelegateAccessRestricted) {

We need this check. Pls, see our discussion with you in previous PR #75821 (comment)

@mukhrr As I think every option in dropdown are pay options with diferent ways

@DylanDylann Strangely, they are not. I mean there are options that is not related to pay when handleBulkPayItemSelected is clicked. Maybe we need to rename this func. Try to delete, move expense, etc. "So fast.. " modal shows for every one if we remove the check as you suggested.

Yeah, thanks for explaining. I am afraid that we are missing other pay options

DylanDylann · 2025-12-24T07:57:56Z

@mukhrr Please list out all actions that we need to prevent when users access as copilot

DylanDylann · 2025-12-24T08:11:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-08.at.16.11.14.mov

Android: mWeb Chrome

Screen.Recording.2025-12-08.at.16.05.51.mov

iOS: HybridApp

Screen.Recording.2025-12-08.at.16.07.26.mov

iOS: mWeb Safari

Screen.Recording.2025-12-08.at.16.05.14.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-24.at.15.04.08.mov

Screen.Recording.2025-12-08.at.16.03.28.mov

…ccess

mukhrr · 2025-12-24T08:46:20Z

@mukhrr Please list out all actions that we need to prevent when users access as copilot

`isDelegateAccessRestricted` Checks Introduced in this PR

1. SearchPage.tsx

Bulk Pay – before processing bulk pay actions on selected items
Bulk Approve – in onSelected callback for APPROVE action
Bulk Reject – in onSelected callback for REJECT action (Caused regression)
Bulk Hold – in onSelected callback for HOLD action

2. SearchSelectedNarrow.tsx

Bulk Pay submenu – passes check to handleBulkPayItemSelected

3. SearchFiltersBar.tsx

Bulk Pay submenu – passes check to handleBulkPayItemSelected

4. Search.ts (libs/actions)

handleActionButtonPress – PAY – blocks Pay action for delegates
handleActionButtonPress – APPROVE – blocks Approve action for delegates
handleBulkPayItemSelected – blocks ELSEWHERE and BUSINESS_BANK_ACCOUNT payment types

5. ActionCell.tsx

Pay button – in confirmPayment callback

6. ExpenseReportListItem.tsx

Action button – passes check to handleActionButtonPress

7. ReportListItemHeader.tsx

Action button – passes check to handleActionButtonPress

8. TransactionListItem.tsx

Action button – passes check to handleActionButtonPress

DylanDylann · 2025-12-24T09:04:13Z

@mukhrr Which actions below action button on these places?

ExpenseReportListItem.tsx
Action button – passes check to handleActionButtonPress

ReportListItemHeader.tsx
Action button – passes check to handleActionButtonPress

TransactionListItem.tsx
Action button – passes check to handleActionButtonPress

mukhrr · 2025-12-24T10:14:10Z

@mukhrr Which actions below action button on these places?

ExpenseReportListItem.tsx
Action button – passes check to handleActionButtonPress

ReportListItemHeader.tsx
Action button – passes check to handleActionButtonPress

TransactionListItem.tsx
Action button – passes check to handleActionButtonPress

Pay and Approve

DylanDylann · 2025-12-30T03:54:05Z

@mukhrr Could you resolve the conflict? Then I will check the last one

…ccess

…stricted

mukhrr · 2025-12-30T07:05:18Z

@mukhrr Could you resolve the conflict? Then I will check the last one

@DylanDylann this is ready

DylanDylann · 2025-12-30T07:53:35Z

@mukhrr Please check the failed GH action

…ccess

OSBotify · 2025-12-30T15:10:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-31T19:02:45Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.90-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-02T10:34:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.90-2 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Add delegate access restriction checks to reject and pay actions in s…

7f14d6c

…earch and money request flows

melvin-bot bot assigned mukhrr Dec 22, 2025

Remove extra blank line in SearchPage reject action flow

a9354f4

mukhrr marked this pull request as ready for review December 22, 2025 17:34

mukhrr requested review from a team as code owners December 22, 2025 17:34

melvin-bot bot requested review from DylanDylann and removed request for a team December 22, 2025 17:34

melvin-bot bot requested review from heyjennahay and removed request for a team December 22, 2025 17:34

mukhrr mentioned this pull request Dec 23, 2025

[Due for payment 2026-01-09] [$250] Copilot with limited access level can perform prohibited actions without warning on Reports #75171

Open

8 tasks

DylanDylann reviewed Dec 24, 2025

View reviewed changes

Merge remote-tracking branch 'origin' into fix/copilot-with-limited-a…

5fff7d3

…ccess

mukhrr added 3 commits December 30, 2025 11:40

Merge remote-tracking branch 'origin' into fix/copilot-with-limited-a…

e12ec0b

…ccess

Fix delegate access check to prevent all bulk payment actions when re…

e07428f

…stricted

Add delegate access restriction check to SettlementButton

dafab25

prettier fix

03a8866

DylanDylann approved these changes Dec 30, 2025

View reviewed changes

melvin-bot bot requested a review from Gonals December 30, 2025 07:50

mukhrr added 2 commits December 30, 2025 13:09

prettier fix

1a84dcb

Merge remote-tracking branch 'origin' into fix/copilot-with-limited-a…

8ca11e9

…ccess

Gonals approved these changes Dec 30, 2025

View reviewed changes

Gonals merged commit 9e17f9a into Expensify:main Dec 30, 2025
30 checks passed

OSBotify mentioned this pull request Dec 31, 2025

Deploy Checklist: New Expensify 2025-12-31 #78646

Closed

28 tasks

	if (isDelegateAccessRestricted && 'value' in item && (item.value === CONST.IOU.PAYMENT_TYPE.ELSEWHERE \|\| item.value === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT)) {
	if (isDelegateAccessRestricted) {

Add delegate access restriction checks to approval, payment, reject and hold #78300

Add delegate access restriction checks to approval, payment, reject and hold #78300

Uh oh!

Conversation

mukhrr commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 22, 2025

Uh oh!

codecov bot commented Dec 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DylanDylann Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

mukhrr Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

mukhrr Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

mukhrr Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Dec 24, 2025

Uh oh!

DylanDylann commented Dec 24, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mukhrr commented Dec 24, 2025

isDelegateAccessRestricted Checks Introduced in this PR

1. SearchPage.tsx

2. SearchSelectedNarrow.tsx

3. SearchFiltersBar.tsx

4. Search.ts (libs/actions)

5. ActionCell.tsx

6. ExpenseReportListItem.tsx

7. ReportListItemHeader.tsx

8. TransactionListItem.tsx

Uh oh!

DylanDylann commented Dec 24, 2025

Uh oh!

mukhrr commented Dec 24, 2025

Uh oh!

DylanDylann commented Dec 30, 2025

Uh oh!

mukhrr commented Dec 30, 2025

Uh oh!

DylanDylann commented Dec 30, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 30, 2025

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

OSBotify commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

mukhrr commented Dec 22, 2025 •

edited

Loading

codecov bot commented Dec 22, 2025 •

edited by github-actions bot

Loading

`isDelegateAccessRestricted` Checks Introduced in this PR