Improve deleted tax behavior by huult · Pull Request #78472 · Expensify/App

huult · 2025-12-26T06:24:30Z

Explanation of Change

Handle deleted tax rates by detecting removed codes, showing them as disabled/selected in the picker, and clearing the tax on submit when editing

Fixed Issues

$ #73033
PROPOSAL: #73033 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Expensify app.
Create a workspace and enable Taxes in More features.
Open the Taxes page and add a new tax rate with a value greater than 0.
Go to the workspace chat and create an expense, selecting the tax rate from step 3.
Go to the workspace settings and change the value of the tax rate you used, or delete the tax rate you used.
Open the expense details and observe the Tax field and Tax Amount field.
Verify that the Tax field shows “Tax no longer valid.” When you tap Tax to open the tax picker, you should see that the tax value that was deleted or changed is shown in a disabled style. If you select this tax again, the Tax field becomes blank and this tax is removed from the picker list.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-19.at.10.46.29.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-19.at.10.50.11.mp4

iOS: Native

Screen.Recording.2026-01-19.at.10.55.24.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-19.at.10.57.56.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-19.at.10.39.58.mp4

melvin-bot · 2025-12-26T06:24:36Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/TaxPicker.tsx

codecov · 2025-12-26T06:32:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ges/iou/request/step/IOURequestStepTaxRatePage.tsx	`0.00% <0.00%> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.42% <0.00%> (-0.01%)`	⬇️
src/components/TaxPicker.tsx	`0.00% <0.00%> (ø)`
... and 9 files with indirect coverage changes

…fter-edit

huult · 2025-12-29T08:29:43Z

Hi @MonilBhavsar, I have a question about the backend behavior.

Screen.Recording.2025-12-29.at.15.21.50.mov

Select a tax (for example, Tax 2 with tax value 35% and taxCode id_TAX_RATE_2)
Go to Workspace settings and change the tax value to 40%
Go back to the expense and you will see: “Tax no longer valid.”
I select the tax with value 40% and taxCode id_TAX_RATE_2 and submit it to the backend, the tax value is not updated to 40% and the taxOutOfPolicy error still exists.

Can we update step 4 so that when I select the tax with value 40% and taxCode id_TAX_RATE_2 and submit it to the backend, the tax value is updated to 40% and the taxOutOfPolicy error is removed?

cc @thesahindia @joekaufmanexpensify

MonilBhavsar · 2025-12-29T08:50:12Z

What API response did you get when you selected new tax rate with 40%?

huult · 2025-12-29T08:53:19Z

The response was from the UpdateMoneyRequestTaxRate API.

MonilBhavsar · 2025-12-29T08:56:54Z

Yes, do you mind sharing it here?

huult · 2025-12-29T09:03:42Z

requestID: "9b57e3713e2db251-LAX"

{
    "jsonCode": 200,
    "requestID": "9b57e3713e2db251-LAX",
    "onyxData": [
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "participants": {
                    "21091638": {
                        "notificationPreference": ""
                    }
                }
            }
        },
        {
            "key": "personalDetailsList",
            "onyxMethod": "merge",
            "value": {
                "21091638": {
                    "accountID": 21091638,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_22.png",
                    "displayName": "TM",
                    "firstName": "TM",
                    "lastName": "",
                    "login": "huult+03242949242242@gmail.com",
                    "phoneNumber": "",
                    "pronouns": "",
                    "status": null,
                    "timezone": {
                        "automatic": true,
                        "selected": "Asia\/Ho_Chi_Minh"
                    },
                    "validated": false
                }
            }
        },
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "lastReadTime": "2025-12-29 08:20:52.382"
            }
        },
        {
            "key": "reportNameValuePairs_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "chatType": "",
                "description": "",
                "parentReportActionID": "245929997925888734",
                "parentReportID": "7730730594068390"
            }
        },
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "chatType": "",
                "description": "",
                "lastActorAccountID": 21091638,
                "lastMessageText": "huult+03242949242242@gmail.com ",
                "lastVisibleActionCreated": "2025-12-29 07:42:11.872",
                "managerID": null,
                "ownerAccountID": 0,
                "parentReportActionID": "245929997925888734",
                "parentReportID": "7730730594068390",
                "policyID": "B2E2C2A6310459F2",
                "reportID": "8491660798716591",
                "reportName": "Chat Report",
                "state": "OPEN",
                "stateNum": 0,
                "statusNum": 0,
                "type": "chat",
                "visibility": null
            }
        },
        {
            "key": "reportActions_8491660798716591",
            "onyxMethod": "merge",
            "shouldShowPushNotification": true,
            "value": {
                "7967640082084948723": {
                    "actionName": "MODIFIEDEXPENSE",
                    "actorAccountID": 21091638,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_22.png",
                    "created": "2025-12-29 08:22:14.096",
                    "lastModified": "2025-12-29 08:22:14.096",
                    "message": [
                        {
                            "html": "huult+03242949242242@gmail.com ",
                            "text": "huult+03242949242242@gmail.com",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "isNewDot": true,
                        "lastModified": "2025-12-29 08:22:14.096"
                    },
                    "person": [
                        {
                            "style": "strong",
                            "text": "TM",
                            "type": "TEXT"
                        }
                    ],
                    "reportActionID": "7967640082084948723",
                    "shouldShow": true
                }
            }
        },
        {
            "key": "reportActions_7730730594068390",
            "onyxMethod": "merge",
            "value": {
                "245929997925888734": {
                    "actionName": "IOU",
                    "actorAccountID": 21091638,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_22.png",
                    "created": "2025-12-29 07:42:09.798",
                    "lastModified": "2025-12-29 07:42:09.798",
                    "message": [
                        {
                            "html": "\u20ab23 expense",
                            "text": "\u20ab23 expense",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "IOUReportID": 7730730594068390,
                        "IOUTransactionID": "4798280820925149892",
                        "amount": 2300,
                        "comment": "",
                        "currency": "VND",
                        "isNewDot": true,
                        "lastModified": "2025-12-29 07:42:09.798",
                        "participantAccountIDs": [
                            21091638,
                            0
                        ],
                        "type": "create"
                    },
                    "person": [
                        {
                            "style": "strong",
                            "text": "TM",
                            "type": "TEXT"
                        }
                    ],
                    "reportActionID": "245929997925888734",
                    "shouldShow": true
                }
            }
        },
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "lastReadTime": "2025-12-29 08:22:14.096"
            }
        },
        {
            "key": "reportActions_742576667027986",
            "onyxMethod": "merge",
            "value": {
                "4352628338059460823": {
                    "childCanHold": true,
                    "childCanUnhold": false,
                    "childCommenterCount": 0,
                    "childLastActorAccountID": 21091638,
                    "childLastMoneyRequestComment": "",
                    "childLastVisibleActionCreated": "",
                    "childManagerAccountID": 21091638,
                    "childMoneyRequestCount": 1,
                    "childOldestFourAccountIDs": "",
                    "childOwnerAccountID": 21091638,
                    "childRecentReceiptTransactionIDs": {},
                    "childReportID": "7730730594068390",
                    "childReportName": "Expense Report 2025-12-29",
                    "childStateNum": 0,
                    "childStatusNum": 0,
                    "childType": "expense",
                    "childVisibleActionCount": 0,
                    "message": [
                        {
                            "html": "TM's Workspace owes \u20ab23",
                            "text": "TM's Workspace owes \u20ab23",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "isNewDot": true,
                        "lastModified": "2025-12-29 07:42:09.802",
                        "linkedReportID": "7730730594068390"
                    }
                }
            }
        },
        {
            "key": "transactionViolations_",
            "onyxMethod": "mergecollection",
            "value": {
                "transactionViolations_4798280820925149892": [
                    {
                        "data": null,
                        "name": "taxOutOfPolicy",
                        "showInReview": true,
                        "type": "violation"
                    }
                ]
            }
        },
        {
            "key": "transactions_4798280820925149892",
            "onyxMethod": "merge",
            "value": {
                "amount": -2300,
                "bank": "",
                "billable": false,
                "cardID": 23662666,
                "cardName": "Cash Expense",
                "cardNumber": "",
                "category": "Advertising",
                "comment": {
                    "comment": ""
                },
                "convertedAmount": -2300,
                "created": "2025-12-29",
                "currency": "VND",
                "hasEReceipt": false,
                "inserted": "2025-12-29 07:42:09",
                "managedCard": false,
                "mcc": 0,
                "merchant": "M",
                "modifiedAmount": "",
                "modifiedCreated": "",
                "modifiedCurrency": "",
                "modifiedMCC": "",
                "modifiedMerchant": "",
                "originalAmount": 0,
                "originalCurrency": "",
                "parentTransactionID": "",
                "posted": "",
                "receipt": null,
                "reimbursable": true,
                "reportID": "7730730594068390",
                "status": "Posted",
                "tag": "",
                "taxAmount": -596,
                "taxCode": "id_TAX_RATE_2",
                "taxValue": "35%", // I would like to change this value to 40%.
                "transactionID": "4798280820925149892"
            }
        },
        {
            "key": "report_7730730594068390",
            "onyxMethod": "merge",
            "value": {
                "avatarUrl": null,
                "chatReportID": "742576667027986",
                "chatType": "",
                "created": "2025-12-29 07:42:09",
                "currency": "VND",
                "description": "",
                "errorFields": {
                    "export": null,
                    "notFound": null
                },
                "fieldList": null,
                "hasExportError": false,
                "hasOutstandingChildRequest": false,
                "hasOutstandingChildTask": false,
                "hasParentAccess": true,
                "hasReportBeenReopened": false,
                "hasReportBeenRetracted": false,
                "invoiceReceiver": null,
                "iouReportID": null,
                "isCancelledIOU": false,
                "isDeletedParentAction": null,
                "isExportedToIntegration": false,
                "isPinned": false,
                "isWaitingOnBankAccount": false,
                "lastActionType": "CREATED",
                "lastActorAccountID": "21091638",
                "lastMentionedTime": null,
                "lastMessageHtml": "",
                "lastMessageText": "",
                "lastReadSequenceNumber": 0,
                "lastReadTime": "2025-12-29 08:22:00.726",
                "lastVisibleActionCreated": "2025-12-29 07:42:09.795",
                "lastVisibleActionLastModified": "2025-12-29 07:42:09.795",
                "managerID": 21091638,
                "nonReimbursableTotal": 0,
                "oldPolicyName": "",
                "ownerAccountID": 21091638,
                "parentReportActionID": "4352628338059460823",
                "parentReportID": "742576667027986",
                "participants": {
                    "21091638": {
                        "notificationPreference": ""
                    }
                },
                "permissions": [],
                "policyAvatar": null,
                "policyID": "B2E2C2A6310459F2",
                "policyName": null,
                "private_isArchived": "",
                "reportID": "7730730594068390",
                "reportName": "Expense Report 2025-12-29",
                "stateNum": 0,
                "statusNum": 0,
                "total": -2300,
                "transactionCount": 1,
                "tripData": null,
                "type": "expense",
                "unheldNonReimbursableTotal": 0,
                "unheldTotal": -2300,
                "visibility": null,
                "welcomeMessage": "",
                "writeCapability": "all"
            }
        },
        {
            "key": "reportNameValuePairs_7730730594068390",
            "onyxMethod": "merge",
            "value": {
                "expensify_text_title": {
                    "defaultExternalID": "",
                    "defaultValue": "{report:type} {report:startdate}",
                    "deletable": true,
                    "disabledOptions": [],
                    "externalID": null,
                    "externalIDs": [],
                    "fieldID": "text_title",
                    "isTax": false,
                    "keys": [],
                    "name": "title",
                    "orderWeight": 0,
                    "origin": null,
                    "target": "expense",
                    "type": "formula",
                    "value": "Expense Report 2025-12-29",
                    "values": []
                },
                "parentReportActionID": 4352628338059460823,
                "parentReportID": 742576667027986
            }
        },
        { // It should remove the taxOutOfPolicy violation.
            "key": "transactionViolations_",
            "onyxMethod": "mergecollection",
            "value": {
                "transactionViolations_4798280820925149892": [
                    {
                        "data": null,
                        "name": "taxOutOfPolicy",
                        "showInReview": true,
                        "type": "violation"
                    }
                ]
            }
        }
    ],
    "previousUpdateID": 9523081771,
    "lastUpdateID": 9523082270
}

MonilBhavsar · 2025-12-29T09:07:48Z

Thanks for sharing! Will take a look

…fter-edit

MonilBhavsar · 2026-02-23T05:32:04Z

@huult the change was deployed. Can you retest the bug?

…fter-edit

huult · 2026-02-23T06:26:12Z

Screen.Recording.2026-02-23.at.13.24.14.mov

@MonilBhavsar it's works

huult · 2026-02-23T06:26:45Z

@thesahindia All yours. Could you re-test this PR?

…fter-edit

MonilBhavsar · 2026-02-24T06:08:06Z

@thesahindia would you be able to review this today?

…fter-edit

thesahindia · 2026-02-25T09:00:58Z

Reviewing today.

…fter-edit

thesahindia · 2026-02-26T11:08:15Z

We have the same problem when we add back deleted tax or enable the disabled tax. The error doesn't disappear.

Screen.Recording.2026-02-26.at.2.48.09.PM.mov

Screen.Recording.2026-02-26.at.2.50.56.PM.mov

…fter-edit

huult · 2026-02-27T09:12:25Z

Screen.Recording.2026-02-27.at.16.06.25.mp4

@MonilBhavsar #78472 (comment) I think this is a backend issue because when we disable and then enable it again, the transactionViolations_ is not cleared.

MonilBhavsar · 2026-02-27T09:29:33Z

How's it working with categories/tags. Do we clear violations?

huult · 2026-02-27T09:38:12Z

Screen.Recording.2026-02-27.at.16.32.56.mp4

It seems that categories are not sending a Pusher update when they are disabled or enabled. We have to reload to update the violations.

MonilBhavsar · 2026-02-27T09:52:22Z

Yeah, we're not sending pusher updates as of now, and tax is inline with category/tags. So not a bug.

huult · 2026-02-27T09:57:31Z

#78472 (comment) cc @thesahindia

…fter-edit

huult · 2026-03-03T02:45:50Z

@thesahindia Gentle bump 🙂

thesahindia · 2026-03-03T17:14:08Z

@huult, on changing the tax percentage the previous tax percentage appears twice in the picker

…fter-edit

huult · 2026-03-04T02:30:47Z

@thesahindia it's done

Improve deleted tax behavior

6999b0c

huult requested review from a team as code owners December 26, 2025 06:24

melvin-bot bot assigned huult Dec 26, 2025

melvin-bot bot requested review from thesahindia and removed request for a team December 26, 2025 06:24

melvin-bot bot requested review from JmillsExpensify, flaviadefaria, heyjennahay, joekaufmanexpensify and trjExpensify and removed request for a team December 26, 2025 06:24

github-actions bot reviewed Dec 26, 2025

View reviewed changes

src/components/TaxPicker.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 26, 2025

View reviewed changes

src/components/TaxPicker.tsx Outdated Show resolved Hide resolved

huult marked this pull request as draft December 26, 2025 06:28

huult added 5 commits December 29, 2025 12:37

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

4e80669

…fter-edit

Handle case where tax value changes

2e421b1

update case where tax value changes

c8f59f2

fix perf-4

d9ff23b

Rename variables for clarity

37e04f1

huult marked this pull request as ready for review December 29, 2025 08:21

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

428ca4a

…fter-edit

huult added 6 commits February 14, 2026 12:44

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

15da7fa

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

78c5bb8

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

781f197

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

3aac97c

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

99ad095

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

6cf2d82

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

a2de645

…fter-edit

huult added 2 commits February 24, 2026 08:23

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

d1d38cc

…fter-edit

run prettier

396cb9b

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

5bb730d

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

4847d44

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

b726f90

…fter-edit

huult added 2 commits March 2, 2026 10:13

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

db65630

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

11f1234

…fter-edit

huult added 2 commits March 4, 2026 09:06

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

c12b2f2

…fter-edit

Fix logic for adding tax option

a68b792

Conversation

huult commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 26, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Dec 29, 2025

Uh oh!

MonilBhavsar commented Dec 29, 2025

Uh oh!

huult commented Dec 29, 2025

Uh oh!

MonilBhavsar commented Dec 29, 2025

Uh oh!

huult commented Dec 29, 2025

Uh oh!

MonilBhavsar commented Dec 29, 2025

Uh oh!

MonilBhavsar commented Feb 23, 2026

Uh oh!

huult commented Feb 23, 2026

Uh oh!

huult commented Feb 23, 2026

Uh oh!

MonilBhavsar commented Feb 24, 2026

Uh oh!

thesahindia commented Feb 25, 2026

Uh oh!

thesahindia commented Feb 26, 2026

Uh oh!

huult commented Feb 27, 2026

Uh oh!

MonilBhavsar commented Feb 27, 2026

Uh oh!

huult commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MonilBhavsar commented Feb 27, 2026

Uh oh!

huult commented Feb 27, 2026

Uh oh!

huult commented Mar 3, 2026

Uh oh!

thesahindia commented Mar 3, 2026

Uh oh!

huult commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huult commented Dec 26, 2025 •

edited

Loading

codecov bot commented Dec 26, 2025 •

edited by github-actions bot

Loading

huult commented Feb 27, 2026 •

edited

Loading