[CP Staging] Make sure to treat normal direct feeds same as plaid #78615

mountiny · 2025-12-30T21:58:39Z

Explanation of Change

We were only treating the plaid feeds as direct, which is not correct - you can have native direct connection.

Fixed Issues

$ #78614
PROPOSAL:

Tests

Have policy with the company cards and feed that is directly connected (not through plaid) - Can be amex, Chase, Bank of america for example
Open the Company cards page
Verify the list of the assigned cards is not loading indefinitely
Switch to a plaid feed or to a policy that has such feed
Make sure that feed is also not loading indefinitely

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as test

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Works on the adhoc

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2025-12-30T21:59:29Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-30T22:04:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78615.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://78615.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

codecov · 2025-12-30T22:07:08Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useCompanyCards.ts	`100.00% <100.00%> (+100.00%)`	⬆️
... and 19 files with indirect coverage changes

melvin-bot · 2025-12-30T22:13:10Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-12-30T22:44:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-31.at.1.55.50.PM.mov

allgandalf

I can confirm that i was able to reproduce the issue:

Screen.Recording.2025-12-31.at.1.48.27.PM.mov

And i can also confirm that the issue is fixed with the current PR:

Screen.Recording.2025-12-31.at.1.55.50.PM.mov

Also the plaid imports still work correctly:

Screen.Recording.2025-12-31.at.1.57.20.PM.mov

allgandalf · 2025-12-31T08:28:38Z

@mountiny should we CP the fix ?

There have been lot of reports about this bug from customers:

[CP Staging] Make sure to treat normal direct feeds same as plaid (cherry picked from commit 409b0d6) (cherry-picked to staging by mountiny)

OSBotify · 2025-12-31T13:17:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-31T13:48:42Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.89-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny · 2025-12-31T13:51:57Z

Fixed in staging

OSBotify · 2025-12-31T18:35:28Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.89-6 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-31T19:03:07Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.90-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-02T10:35:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.90-2 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Make sure to treat normal direct feeds same as plaid

4cdd801

mountiny self-assigned this Dec 30, 2025

mountiny added 2 commits December 30, 2025 23:07

Create unit test for the company cards

e88a628

Add afterEach to the tests for proper clean up

74984cd

mountiny marked this pull request as ready for review December 30, 2025 22:13

mountiny requested review from a team as code owners December 30, 2025 22:13

melvin-bot bot requested review from FitseTLT and removed request for a team December 30, 2025 22:13

mountiny added the InternalQA This pull request required internal QA label Dec 30, 2025

Styles

f970dc3

mountiny removed the request for review from FitseTLT December 30, 2025 22:21

mountiny added 2 commits December 30, 2025 23:25

Fix esLint

d1fcf49

Prettier

a368008

mountiny requested a review from allgandalf December 30, 2025 22:37

abzokhattab mentioned this pull request Dec 31, 2025

[$250] The Company Card page keeps loading, and unable assign the company cards #78485

Closed

7 tasks

allgandalf approved these changes Dec 31, 2025

View reviewed changes

mountiny changed the title ~~Make sure to treat normal direct feeds same as plaid~~ [CP Staging] Make sure to treat normal direct feeds same as plaid Dec 31, 2025

MariaHCD approved these changes Dec 31, 2025

View reviewed changes

MariaHCD merged commit 409b0d6 into main Dec 31, 2025
31 checks passed

MariaHCD deleted the vit-fixDirectfeedIssue branch December 31, 2025 13:07

OSBotify pushed a commit that referenced this pull request Dec 31, 2025

Merge pull request #78615 from Expensify/vit-fixDirectfeedIssue

21b1304

[CP Staging] Make sure to treat normal direct feeds same as plaid (cherry picked from commit 409b0d6) (cherry-picked to staging by mountiny)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 31, 2025

OSBotify mentioned this pull request Dec 31, 2025

Deploy Checklist: New Expensify 2025-12-30 #78583

Closed

56 tasks

OSBotify mentioned this pull request Dec 31, 2025

Deploy Checklist: New Expensify 2025-12-31 #78646

Closed

28 tasks

melvin-bot bot mentioned this pull request Jan 2, 2026

[Due for payment 2026-01-09] Direct feed cards page is showing as loading indefinitely #78614

Open

[CP Staging] Make sure to treat normal direct feeds same as plaid #78615

[CP Staging] Make sure to treat normal direct feeds same as plaid #78615

Conversation

mountiny commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

codecov bot commented Dec 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 30, 2025

Uh oh!

allgandalf commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

mountiny commented Dec 31, 2025

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

OSBotify commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mountiny commented Dec 30, 2025 •

edited

Loading

codecov bot commented Dec 30, 2025 •

edited by github-actions bot

Loading

allgandalf commented Dec 30, 2025 •

edited

Loading

allgandalf commented Dec 31, 2025 •

edited

Loading