-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix - Make it more apparent in the expense chat carousel view when ex… #78637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Make it more apparent in the expense chat carousel view when ex… #78637
Conversation
…penses are added to a report This reverts commit 47ca864.
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second try after original PR was reverted due to DB 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-06.at.11.04.45.movScreen.Recording.2026-01-06.at.11.04.09.movAndroid: mWeb ChromeScreen.Recording.2025-12-16.at.23.30.49-compressed.moviOS: HybridAppScreen.Recording.2026-01-06.at.10.49.56.moviOS: mWeb SafariScreen.Recording.2026-01-06.at.10.59.33.movMacOS: Chrome / SafariScreen.Recording.2026-01-06.at.10.21.08.mov |
dominictb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎀
marcochavezf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.2.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.95-5 🚀
|
Explanation of Change
Fixed Issues
$ #71390 #78526
PROPOSAL: #71390 (comment)
Tests
Prerequisite: Account has at least one workspace.
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-01-02.19-57-12.mp4
Android: mWeb Chrome
2026-01-02.21-59-37.mp4
iOS: Native
2026-01-02.20-39-38.mp4
iOS: mWeb Safari
2026-01-02.21-58-45.mp4
MacOS: Chrome / Safari
2025-12-31.16-57-23.mp4