Add `SearchForUsers` command and use it when searching for members by fedirjh · Pull Request #78743 · Expensify/App

fedirjh · 2026-01-01T00:18:06Z

Explanation of Change

We noticed that the member search input (name/email/phone) is calling SearchForReports on every keystroke. That command also queries reports, which makes sense for things like the chat switcher, but not for pages where we’re only searching for members (e.g. invite new members). We implemented a new command SearchForUsers to query just the personal details for the member search.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/582334
PROPOSAL: https://github.com/Expensify/Expensify/issues/582334#issuecomment-3702930257

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Prerequisites:

Have at least 2 accounts (one to search for)
Have a workspace with members
Open browser DevTools > Network tab to verify API commands

1. Workspace Invite Page

Go to a workspace > Members > Invite member
Type a name/email/phone in the search input
Verify matching users appear correctly
Verify the Network tab shows SearchForUsers (not SearchForReports)
In chrome: Select a user and confirm the invite completes successfully

2. Room Invite Page

Open a chat room > Members > Invite
Search for a user by name or email
Verify results appear and selecting a user works
In chrome: Verify SearchForUsers is fired in the Network tab

3. Invite Report Participants

Open a group chat > Members > Invite
Search for a user
Verify results and selection work correctly
In chrome: Verify SearchForUsers in the Network tab

4. Money Request - Participants Selector

Start a new expense (Request money / Split)
In the participant selector, search for a user
Verify the correct results appear and can be selected
Verify SearchForUsers in the Network tab

5. Money Request - Attendee Selector

Create/edit an expense that supports attendees
Search for an attendee by name or email
Verify results and selection
In chrome: Verify SearchForUsers in the Network tab

6. Money Request - Accountant Selector

Navigate to the accountant selector in a money request flow
Search for a user
In chrome: Verify results and SearchForUsers in the Network tab

7. Task Assignee Selector

Create or edit a task
In the assignee selector, search for a user
Select an assignee and verify the task updates correctly
In chrome: Verify SearchForUsers in the Network tab

8. Vacation Delegate Selection

Go to Settings > Security > Vacation Delegate
Search for a user to set as delegate
Verify results appear and selection works
In chrome: Verify SearchForUsers in the Network tab

9. Add Security Delegate

Go to Settings > Security > Add delegate
Search for a user
Verify results and selection
In chrome: Verify SearchForUsers in the Network tab

10. Domain Add Admin

Go to a domain > Admins > Add admin
Search for a user by name or email
Verify results appear and the invite works
Verify SearchForUsers in the Network tab

11. Assign Company Card

Go to a workspace > Company Cards > Assign card
In the assignee step, search for a member
In chrome: Verify results and SearchForUsers in the Network tab

12. Issue New Expensify Card

Go to a workspace > Expensify Cards > Issue new card
In the assignee step, search for a member
In chrome: Verify results and SearchForUsers in the Network tab

13. Onboarding Workspace Invite

Trigger the onboarding flow (new account or clear onboarding state)
On the workspace invite step, search for a user
In chrome: Verify results and SearchForUsers in Network tab

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…components

…ove parameter handling

codecov · 2026-01-01T00:26:08Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ponents/BaseVacationDelegateSelectionComponent.tsx	`0.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/HttpUtils.ts	`86.36% <100.00%> (+0.20%)`	⬆️
src/libs/actions/Report/index.ts	`63.23% <100.00%> (-0.25%)`	⬇️
src/pages/InviteReportParticipantsPage.tsx	`0.00% <ø> (ø)`
...gWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx	`0.00% <ø> (ø)`
src/pages/RoomInvitePage.tsx	`0.00% <ø> (ø)`
src/pages/domain/Admins/DomainAddAdminPage.tsx	`0.00% <ø> (ø)`
...ges/iou/request/MoneyRequestAccountantSelector.tsx	`0.00% <ø> (ø)`
...pages/iou/request/MoneyRequestAttendeeSelector.tsx	`0.00% <ø> (ø)`
... and 6 more
... and 135 files with indirect coverage changes

carlosmiceli · 2026-02-19T19:46:35Z

Is this ready to review @fedirjh ?

fedirjh · 2026-02-19T20:07:47Z

Is this ready to review @fedirjh ?

This is still awaiting for https://github.com/Expensify/Web-Expensify/pull/49992 to reach prod

carlosmiceli · 2026-02-19T20:08:38Z

Ah, but it could be on hold and I can review on the meantime (also in case other tests fail).

melvin-bot · 2026-02-19T20:14:56Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f32726f069

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ChavdaSachin · 2026-02-20T12:39:21Z

Does this a need C+ review?

fedirjh · 2026-02-20T15:27:05Z

Does this a need C+ review?

Yes, we need to test the new command once it's deployed.

…command across multiple components

…orts function

carlosmiceli · 2026-02-24T20:50:21Z

This should be ready to polish/review 💪

ChavdaSachin · 2026-02-24T21:51:38Z

@fedirjh is there any special reason why we are not using searchUserInServer in following places?

App/src/components/BaseVacationDelegateSelectionComponent.tsx

Line 82 in 6e29772

searchInServer(debouncedSearchTerm);

App/src/pages/NewChatPage.tsx

Line 150 in 6e29772

searchInServer(debouncedSearchTerm);

App/src/pages/domain/Admins/DomainAddAdminPage.tsx

Line 63 in 6e29772

searchInServer(debouncedSearchTerm);

…eVacationDelegateSelectionComponent and DomainAddAdminPage

fedirjh · 2026-02-25T13:35:41Z

is there any special reason why we are not using searchUserInServer in following places?

Good catch, those seem to be implemented recently. For the NewChatPage.tsx, This one is actually correct as-is. NewChatPage is for creating a new chat — it searches for both users and reports/rooms, not just users. That's the core use case for searchInServer (which calls SEARCH_FOR_REPORTS), since the results can include existing chat reports, rooms, etc., in addition to individual people.

ChavdaSachin · 2026-02-25T13:49:26Z

is there any special reason why we are not using searchUserInServer in following places?

Good catch, those seem to be implemented recently. For the NewChatPage.tsx, This one is actually correct as-is. NewChatPage is for creating a new chat — it searches for both users and reports/rooms, not just users. That's the core use case for searchInServer (which calls SEARCH_FOR_REPORTS), since the results can include existing chat reports, rooms, etc., in addition to individual people.

Yeah, did not realize it uses recent reports to float few participants.

Reviewing ♻️

fedirjh · 2026-02-25T14:32:06Z

@ChavdaSachin the new command is SearchForUsers

Is BE branch not yet deployed to staging?

It's deployed to production.

ChavdaSachin · 2026-02-25T14:46:49Z

    }

-    API.read(policyID ? READ_COMMANDS.SEARCH_FOR_ROOMS_TO_MENTION : READ_COMMANDS.SEARCH_FOR_REPORTS, policyID ? searchForRoomToMentionParams : searchForReportsParams, {
+    API.read(policyID ? READ_COMMANDS.SEARCH_FOR_ROOMS_TO_MENTION : READ_COMMANDS.SEARCH_FOR_REPORTS, policyID ? searchForRoomToMentionParams : searchForReportsOrUsersParams, {


I guess we need to include SEARCH_FOR_USERS command here right?

Yes, that's correct. Updated in a8002f4

… a variable for server command selection

ChavdaSachin · 2026-02-25T16:57:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screenshots

melvin-bot · 2026-02-25T17:00:28Z

🎯 @ChavdaSachin, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #83461.

github-actions · 2026-02-25T17:34:42Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-25T17:39:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #78743.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-807d187-0dbc7e1-f23c824995d4cfe3c6aef0d059fc9d14e7c8b1dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-807d187-0dbc7e1-177e7e714a38e4f50f6e08f8b14ddc54c1a7835c/index.html

Web 🕸️
https://78743.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

izarutskaya · 2026-02-25T18:19:52Z

Hi @fedirjh Do we need QA for this?

OSBotify · 2026-02-25T18:22:48Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

carlosmiceli · 2026-02-25T18:26:14Z

@izarutskaya yes, let's wait for @fedirjh to add QA steps 👍

fedirjh · 2026-02-25T23:19:09Z

@izarutskaya QA steps updated 🙇🏼

OSBotify · 2026-02-27T14:54:23Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fedirjh added 6 commits January 1, 2026 00:07

chore: Add SearchForUsersParams type and integrate into API parameters

069754e

feat: Implement searchUserInServer function and update related API calls

a38c7ba

feat: Replace searchInServer with searchUserInServer across multiple …

82e0633

…components

Merge remote-tracking branch 'upstream' into add-SearchForUsers-command

5525f4e

feat: Refactor search functions to unify server search logic and impr…

623ef4f

…ove parameter handling

fix: Style formatting

e1354e2

melvin-bot Bot assigned fedirjh Jan 1, 2026

fedirjh requested a review from carlosmiceli January 1, 2026 00:18

fedirjh added 3 commits January 12, 2026 16:50

Merge branch 'Expensify:main' into add-SearchForUsers-command

9829c12

Merge remote-tracking branch 'upstream' into add-SearchForUsers-command

adfda30

Merge branch 'Expensify:main' into add-SearchForUsers-command

b2ac0c9

fedirjh changed the title ~~[Hold Auth#19018 Web-E#49992] Add SearchForUsers command and use it when searching for members~~ [Web-E#49992] Add SearchForUsers command and use it when searching for members Feb 19, 2026

Merge branch 'Expensify:main' into add-SearchForUsers-command

f32726f

fedirjh marked this pull request as ready for review February 19, 2026 20:14

fedirjh requested review from a team as code owners February 19, 2026 20:14

melvin-bot Bot requested review from ChavdaSachin and joekaufmanexpensify and removed request for a team and joekaufmanexpensify February 19, 2026 20:14

melvin-bot Bot removed the request for review from a team February 19, 2026 20:14

carlosmiceli changed the title ~~[Web-E#49992] Add SearchForUsers command and use it when searching for members~~ [HOLD Web-E#49992] Add SearchForUsers command and use it when searching for members Feb 19, 2026

chatgpt-codex-connector Bot reviewed Feb 19, 2026

View reviewed changes

Comment thread src/pages/RoomInvitePage.tsx

Merge branch 'Expensify:main' into add-SearchForUsers-command

9c6e774

fedirjh added 3 commits February 20, 2026 16:33

chore: Refactor pending request cancellation to use SEARCH_FOR_USERS …

b3864d0

…command across multiple components

refactor: Simplify pending request cancellation logic in searchForRep…

79e91d3

…orts function

Merge branch 'main' into add-SearchForUsers-command

d8e60a5

carlosmiceli changed the title ~~[HOLD Web-E#49992] Add SearchForUsers command and use it when searching for members~~ Add SearchForUsers command and use it when searching for members Feb 24, 2026

fedirjh added 2 commits February 25, 2026 14:27

Merge branch 'main' into add-SearchForUsers-command

400d3bf

chore: Refactor search functionality to use searchUserInServer in Bas…

77f6b9f

…eVacationDelegateSelectionComponent and DomainAddAdminPage

This comment was marked as resolved.

Sign in to view

ChavdaSachin reviewed Feb 25, 2026

View reviewed changes

refactor: Simplify search command handling in Report actions by using…

a8002f4

… a variable for server command selection

ChavdaSachin approved these changes Feb 25, 2026

View reviewed changes

melvin-bot Bot mentioned this pull request Feb 25, 2026

[Due for Payment 2026-03-05] Payment issue for E/App PR#78743 #83461

Closed

carlosmiceli approved these changes Feb 25, 2026

View reviewed changes

carlosmiceli merged commit 807d187 into Expensify:main Feb 25, 2026
30 of 31 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

fedirjh deleted the add-SearchForUsers-command branch February 25, 2026 23:12

Conversation

fedirjh commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

carlosmiceli commented Feb 19, 2026

Uh oh!

fedirjh commented Feb 19, 2026

Uh oh!

carlosmiceli commented Feb 19, 2026

Uh oh!

melvin-bot Bot commented Feb 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ChavdaSachin commented Feb 20, 2026

Uh oh!

fedirjh commented Feb 20, 2026

Uh oh!

carlosmiceli commented Feb 24, 2026

Uh oh!

ChavdaSachin commented Feb 24, 2026

Uh oh!

fedirjh commented Feb 25, 2026

Uh oh!

ChavdaSachin commented Feb 25, 2026

Uh oh!

This comment was marked as resolved.

fedirjh commented Feb 25, 2026

Uh oh!

ChavdaSachin Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

fedirjh Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

izarutskaya commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

carlosmiceli commented Feb 25, 2026

Uh oh!

fedirjh commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fedirjh commented Jan 1, 2026 •

edited

Loading

codecov Bot commented Jan 1, 2026 •

edited by github-actions Bot

Loading

ChavdaSachin commented Feb 25, 2026 •

edited

Loading