fix: distance edited is not updated in 1:1 chat but updated amount is shown#78862
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I am having an issue with IOS native, will update the recording for IOS native once it is solved |
trjExpensify
left a comment
There was a problem hiding this comment.
Doesn't this need to hold on @francoisl's BE issue first?
|
@trjExpensify I think we can merge the FE PR. It can fix the issue in offline mode. The online mode's issue will be resolved automatically once BE PR is merged |
|
Let's wait for the backend changes so we can test the whole flow while online. |
|
Makes sense to me 👍 |
|
The backend changes are live |
|
@thelullabyy Is this PR ready for review? |
|
@thelullabyy ☝️ |
|
Checking it now... I will provides update shortly |
…2-track-distance-issue
|
@dominictb it is ready for review now |
|
Taking this over |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-02-25.at.3.15.04.pm.mov |
|
@thelullabyy please fix conflict |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
Conflicts are resolved @mkhutornyi |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
mkhutornyi
left a comment
There was a problem hiding this comment.
The bug is not fixed yet. Offline works but distance is reverted back when online.
Looks like you forgot to pass params needed in #76712 (comment).
online.mov
|
Checking it.... |
bb29f63 to
ae2f783
Compare
|
|
…2-track-distance-issue
|
@mkhutornyi Please check again. It should work now Screen.Recording.2026-02-24.at.17.22.29.mov |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
Explanation of Change
Fixed Issues
$ #76712
PROPOSAL: #76712 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
web-android.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2026-01-06.at.01.16.17.mov
MacOS: Chrome / Safari
web.mov
Screen.Recording.2026-02-02.at.19.21.59.mov