remove REPORT_NAME_VALUE_PAIRS from Onyx.merge part 1 by dukenv0307 · Pull Request #79028 · Expensify/App

dukenv0307 · 2026-01-07T17:54:00Z

Explanation of Change

Refactor getReportOption and getReportDisplayOption to use reportNameValuePair from component instead of using it from Onyx.connect

Fixed Issues

$ #66380
PROPOSAL:

Tests

Test 1:

Click FAB button
Create expense
Enter amount
Choose the recipient (workspace or individual)
Verify that the selected recipient is shown correctly
Complete the flow
Verify the expense is created correctly

Test 2 (Native only)

Open Photo App
Select any photo
Share to Expensify
Verify the participants show correctly
Select any participant and share
Verify the image is shared successfully

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-08.at.10.50.47.mov

Android: mWeb Chrome

Screen.Recording.2026-01-08.at.10.59.30.mov

iOS: Native

Screen.Recording.2026-01-08.at.10.44.18.mov

Screen.Recording.2026-01-08.at.10.47.58.mov

iOS: mWeb Safari

Screen.Recording.2026-01-08.at.10.59.51.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-08.at.10.59.14.mov

melvin-bot · 2026-01-07T17:54:08Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-07T18:02:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/usePrivateIsArchivedMap.ts	`100.00% <100.00%> (ø)`
src/libs/OptionsListUtils/index.ts	`75.08% <100.00%> (+49.59%)`	⬆️
src/libs/ReportNameUtils.ts	`82.88% <100.00%> (+0.33%)`	⬆️
src/pages/Share/ShareDetailsPage.tsx	`0.00% <0.00%> (ø)`
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	`3.77% <0.00%> (ø)`
...es/iou/request/step/IOURequestStepConfirmation.tsx	`56.18% <85.71%> (+0.26%)`	⬆️
src/pages/Share/SubmitDetailsPage.tsx	`0.00% <0.00%> (ø)`
src/selectors/ReportNameValuePairs.ts	`70.58% <71.42%> (+0.58%)`	⬆️
...ou/request/step/IOURequestStepDistanceOdometer.tsx	`0.00% <0.00%> (ø)`
.../pages/iou/request/step/IOURequestStepDistance.tsx	`1.26% <0.00%> (ø)`
... and 4 more
... and 250 files with indirect coverage changes

dukenv0307 · 2026-01-08T04:12:56Z

@DylanDylann Pls review this PR. Thanks

DylanDylann · 2026-01-08T12:11:50Z

src/libs/OptionsListUtils/index.ts


        // Set properties that are used in SearchOption context
-        result.private_isArchived = reportNameValuePairs?.private_isArchived;
+        result.private_isArchived = reportNameValuePairsForReport?.private_isArchived;


If we only use private_isArchived, let's use useArchivedReportsIdSet, it's designed for this case

@DylanDylann, useArchivedReportsIdSet is used to get the set of archived report IDs, but in this case we just need 1 private_isArchived so I don't think we should use it. ANW, I think we can just pass the single private_isArchived intead of the whole reportNameValuePairs.

heyjennahay · 2026-01-08T12:58:49Z

Product review not required. Removing myself and unsubscribing

DylanDylann · 2026-01-12T10:11:58Z

src/libs/ReportNameUtils.ts

    allReportNameValuePairs?: OnyxCollection<ReportNameValuePairs>,
    personalDetailsList?: PersonalDetailsList,
    reportActions?: OnyxCollection<ReportActions>,
+    reportNameValuePair?: OnyxEntry<ReportNameValuePairs>,


I think passing the isArchived parameter is enough

src/pages/Share/SubmitDetailsPage.tsx

DylanDylann · 2026-01-12T10:15:40Z

src/pages/iou/request/step/IOURequestStepAmount.tsx

            const participants = selectedParticipants.map((participant) => {
                const participantAccountID = participant?.accountID ?? CONST.DEFAULT_NUMBER_ID;
-                return participantAccountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, reportAttributesDerived);
+                return participantAccountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, privateIsArchived, reportAttributesDerived);


DylanDylann · 2026-01-12T10:15:54Z

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

                    return participant;
                }
-                return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, reportAttributesDerived, reportDrafts);
+                return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, privateIsArchived, reportAttributesDerived, reportDrafts);


DylanDylann · 2026-01-12T10:17:06Z

@dukenv0307 Typescript check is failed

dukenv0307 · 2026-01-13T08:26:57Z

@DylanDylann I addressed all your comments, it's ready for review again

src/pages/iou/request/step/IOURequestStepDistance.tsx

src/pages/iou/request/step/IOURequestStepDistanceManual.tsx

src/pages/iou/request/step/IOURequestStepDistanceMap.tsx

DylanDylann · 2026-01-14T08:23:26Z

src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx

            const participants = selectedParticipants.map((participant) => {
                const participantAccountID = participant?.accountID ?? CONST.DEFAULT_NUMBER_ID;
-                return participantAccountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, derivedReports);
+                return participantAccountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, !!reportNameValuePairs?.private_isArchived, derivedReports);


@dukenv0307 Hello

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

src/pages/iou/request/step/IOURequestStepScan/index.tsx

src/selectors/ReportNameValuePairs.ts

DylanDylann · 2026-01-14T08:25:23Z

src/types/onyx/ReportNameValuePairs.ts

 type ReportNameValuePairs = OnyxCommon.OnyxValueWithOfflineFeedback<{
    /** Whether the report is an archived room */
-    private_isArchived?: string;
+    private_isArchived?: string | boolean;


I don't think we should edit this type, private_isArchived in rNVP should be string (save the deleted time)

Oh, I think it can be Boolean as defined in

App/src/libs/actions/Policy/Member.ts

Line 579 in 232cb11

private_isArchived: false,

and

App/src/libs/actions/Policy/Member.ts

Line 534 in 232cb11

private_isArchived: true,

@dukenv0307 Hmmm, Could you check again the response from BE to confirm if it could be boolean or not? We should use same type from BE

I think BE will return a string, but it's safe to be a boolean because:

We already used it as I mentioned above

We use useArchivedReportsIdSet to get the list of reportID that are archived reports, so we can easily get private_isArchived as a boolean.

What do you think?

We already used it as I mentioned above

It's bad practice as I think. It may cause problems in the future that I also don't know 😄 Anw, Why do we need to do it here?

cc @tgolen What do you think?

@DylanDylann We used it here

https://github.com/Expensify/App/pull/79028/changes#diff-48f7edf19f169a2c5131f019a4701a02e1207efdf4ce3d00b1e81c247330e80fR926

In the downstream tasks, we just use it as a boolean (like !!result.private_isArchived), then we can leverage useArchivedReportsIdSet. If it must be a string, we need to create another selector to get private_isArchived

I also think we need to use private_isArchived instead of a boolean flag in this case. Happy to wait for @tgolen's perspective on this before moving forward.

We should be try to keep it as consistent as we can from the BE (makes all of our lives easier). I verified in the BE that the value is a timestamp, so let's try to keep it that way as much as we can.

dukenv0307 · 2026-01-15T07:55:12Z

@DylanDylann It's ready for review again

DylanDylann

LGTM

DylanDylann · 2026-01-15T08:11:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-01-15.at.15.09.04.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-01-19T16:39:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-20T17:41:38Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:06:07Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dukenv0307 requested review from a team as code owners January 7, 2026 17:54

melvin-bot bot assigned dukenv0307 Jan 7, 2026

melvin-bot bot requested review from ZhenjaHorbach and heyjennahay and removed request for a team January 7, 2026 17:54

melvin-bot bot removed the request for review from a team January 7, 2026 17:54

dukenv0307 marked this pull request as draft January 7, 2026 17:54

remove REPORT_NAME_VALUE_PAIRS Onyx connect part 1

f974722

dukenv0307 force-pushed the fix/66380-part-1 branch from 97f396f to f974722 Compare January 8, 2026 03:52

dukenv0307 marked this pull request as ready for review January 8, 2026 04:12

DylanDylann reviewed Jan 8, 2026

View reviewed changes

heyjennahay removed their request for review January 8, 2026 12:58

dukenv0307 added 4 commits January 9, 2026 10:09

use private_isArchived instead of reportNameValuePairs

c1fb0fc

rename isArchived

dc6672d

Merge branch 'main' into fix/66380-part-1

fc76be3

lint fix

e578816

DylanDylann reviewed Jan 12, 2026

View reviewed changes

dukenv0307 added 2 commits January 13, 2026 10:51

refactor private_isArchived

7d4f1b9

fix test

d3d2d1c

DylanDylann reviewed Jan 14, 2026

View reviewed changes

dukenv0307 added 3 commits January 14, 2026 17:03

refactor isArchivedReport

ce926ae

update IOURequestStepDIstanceOdometer

2cb2769

update type

18284c6

DylanDylann approved these changes Jan 15, 2026

View reviewed changes

melvin-bot bot requested a review from danieldoglas January 15, 2026 08:04

DylanDylann approved these changes Jan 15, 2026

View reviewed changes

dukenv0307 added 2 commits January 19, 2026 11:45

merge main

1ee9142

lint fix

21925f8

danieldoglas approved these changes Jan 19, 2026

View reviewed changes

danieldoglas merged commit 73ba797 into Expensify:main Jan 19, 2026
29 checks passed

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

melvin-bot bot mentioned this pull request Jan 21, 2026

[Due for payment 2026-01-28] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/OptionsListUtils.ts #66380

Open

Conversation

dukenv0307 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 7, 2026

Uh oh!

codecov bot commented Jan 7, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dukenv0307 commented Jan 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

heyjennahay commented Jan 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 12, 2026

Uh oh!

dukenv0307 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jan 15, 2026

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jan 19, 2026

dukenv0307 commented Jan 7, 2026 •

edited

Loading

codecov bot commented Jan 7, 2026 •

edited by github-actions bot

Loading

dukenv0307 commented Jan 13, 2026 •

edited

Loading

DylanDylann Jan 14, 2026 •

edited

Loading