Remove unnecessary custom types from translations - batch 6

[mrejdak]

Explanation of Change

Removing unnecessary custom types from translations (batch 6). Translations returning PluralForms are not flattened. Modified translation of spreadsheet.importFinalModal to allow for flattened arguments or lack of promptKeyParams.

Fixed Issues

$ #76429
$ #79136
PROPOSAL: #76429 (comment)

Tests

Testing every modified component is not necessary since the changes are all related to types only, and TypeScript already checks types and enforces correct parameter usage.

AddressForm.tsx

1. Go to Account tab and select Profile
2. Scroll down and select Address
3. Input a zipcode in a wrong format for a chosen country (e.g. 'A12-B332' for Poland)
4. Verify that the incorrect zip code message is displayed correctly

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

1. Go to Workspaces tab and create a new one.
2. Select Members, click More and Download CSV.
3. Click More, Import spreadsheet and select the same file that was just downloaded.
4. Click Import and verify that the modal displays the correct message.
5. Edit the downloaded file, by adding a new row ("[email],admin,[email],,,,,").
6. Import the modified file and verify the displayed message is correct.
7. Modify the added row, by changing the role to member and add 2 more rows without specifying the roles ("[email],,[email],,,,,").
8. Select the modified file for import, but change the first field mapping to 'Ignore'.
9. Click Import and verify that the error message about required mapping missing is correct.
10. Change both first and second field mapping to 'Email' and verify the error message about multiple mapping is correct.
11. Change the second field mapping back to 'Role' and click Import.
12. In the new confirmation page, verify that the message above role selection is correct.
13. Select any role and click Import.
14. Verify that the message about added and updated members is correct.

Category.ts

1. Go to Workspaces tab and create a new one.
2. Select Categories, click More and Download CSV.
3. Edit the downloaded file, by adding a few new rows (e.g. "Aaa,,,true,,false,,," "Aab,,,true,,true,,,")
4. Import the modified file and verify the displayed message is correct.

ImportSpreadsheetConfirmModal.tsx Tag.ts

1. Go to Workspaces tab and create a new one.
2. Enable 'Tags'.
3. Go to Tags and add a new one
4. Select Members, click More and Download CSV.
5. Click More, Import spreadsheet, Multi-level tags and select the same file that was just downloaded.
6. Press Next and Import.
7. Verify that the app does not crash and the displayed modal displays a correct message about the failed import.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

AddressForm.tsx

---

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

---

Category.ts

---

ImportSpreadsheetConfirmModal.tsx Tag.ts

iOS: mWeb Safari

MacOS: Chrome / Safari

AddressForm.tsx

---

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

---

Category.ts

---

ImportSpreadsheetConfirmModal.tsx Tag.ts

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AddressForm.tsx	98.00% <ø> (ø)
src/components/ExceededCommentLength.tsx	100.00% <100.00%> (ø)
src/components/UploadFile.tsx	0.00% <ø> (ø)
.../pages/MissingPersonalDetails/substeps/Address.tsx	0.00% <ø> (ø)
src/pages/Travel/FlightTripDetails.tsx	0.00% <ø> (ø)
src/pages/settings/Wallet/TransferBalancePage.tsx	0.00% <ø> (ø)
...es/workspace/categories/ImportedCategoriesPage.tsx	0.00% <ø> (ø)
...rc/pages/workspace/members/ImportedMembersPage.tsx	0.00% <ø> (ø)
src/pages/workspace/tags/ImportedTagsPage.tsx	0.00% <ø> (ø)
src/components/FocusModeNotification.tsx	0.00% <0.00%> (ø)
... and 9 more
... and 10 files with indirect coverage changes

[melvin-bot]

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a4a6c51a1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[mrejdak]

The workaround for handling the case of an old data persisting in Onyx after an update added unnecessary complexity, thus the promptKeyParams are kept as objects.

[heyjennahay]

Product review not required. Removing myself and unsubscribing

[mrejdak]

hi, friendly bump @QichenZhu 😄

[QichenZhu]

I'll review in 24 hours.

[QichenZhu]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

android-native-2.webm

Category.ts

android-native-3.webm

ImportSpreadsheetConfirmModal.tsx Tag.ts

android-native-4.webm

Android: mWeb Chrome

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

android-web-2a.webm

android-web-2b.webm

android-web-2c.webm

Category.ts

android-web-3.webm

ImportSpreadsheetConfirmModal.tsx Tag.ts

android-web-4.webm

iOS: HybridApp

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

ios-native-2.mov

Category.ts

ios-native-3.mov

ImportSpreadsheetConfirmModal.tsx Tag.ts

ios-native-4.mov

iOS: mWeb Safari

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

ios-web-2.mov

Category.ts

ios-web-3.mov

ImportSpreadsheetConfirmModal.tsx Tag.ts

ios-web-4.mov

MacOS: Chrome / Safari

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

mac-web-2.mov

Category.ts

mac-web-3.mov

ImportSpreadsheetConfirmModal.tsx Tag.ts

mac-web-4.mov

[iwiznia]

Lint errors existed before these changes

[melvin-bot]

@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅