fix: broken card feed missing currentStep causing infinite loading by ikevin127 · Pull Request #79291 · Expensify/App

ikevin127 · 2026-01-11T03:23:23Z

Explanation of Change

The issue was caused by missing currentStep initialization in the Onyx ASSIGN_CARD key when navigating to the BrokenCardFeedConnectionPage due to BYOC implementation - commit e5379f72d29 ("re-arrange assign card flow") adding BrokenCardFeedConnectionPage.tsx.

Problem: When currentStep is undefined (not set), the default case is hit, showing LoadingPage indefinitely.

Contrast with Working Flow: In the normal assign card flow via useAssignCard.ts - the working flow first sets currentStep, then navigates. The broken flow navigates without setting currentStep.

Proposed Changes

[MODIFY] WorkspaceCompanyCardsTableHeaderButtons.tsx
- Import setAssignCardStepAndData from @userActions/CompanyCards
- Import getPlaidInstitutionId from @libs/CardUtils
- Update openBankConnection function:
  - Determine the correct initialStep based on the feed type (Plaid vs. scraping)
  - Call setAssignCardStepAndData({currentStep: initialStep}) to seed Onyx data
  - Ensure this happens before the navigation call

const openBankConnection = () => {
    if (!feedName) {
        return;
    }

    const institutionId = getPlaidInstitutionId(feedName);
    const initialStep = institutionId ? CONST.COMPANY_CARD.STEP.PLAID_CONNECTION : CONST.COMPANY_CARD.STEP.BANK_CONNECTION;
    setAssignCardStepAndData({currentStep: initialStep});

    Navigation.setNavigationActionToMicrotaskQueue(() => {
        Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_BROKEN_CARD_FEED_CONNECTION.getRoute(policyID ?? String(CONST.DEFAULT_NUMBER_ID), feedName));
    });
};

@carlosmiceli

Fixed Issues

https://github.com/Expensify/Expensify/issues/570675
PROPOSAL:

Tests

Open the app and navigate to Settings > Workspaces > [Workspace Name] > Company Cards.
Ensure you have a card feed with a broken connection (you should see a red error message: Card feed connection is broken. Please log into your bank...).
Click the "log into your bank" link in the error message.
Verify that the Right Hand Panel (RHP) opens and immediately displays the bank connection / login flow.
Verify that you do not see an infinite loading spinner in the RHP.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-01-10.at.19.11.29.mov

codecov · 2026-01-11T03:32:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...sTable/WorkspaceCompanyCardsTableHeaderButtons.tsx	`0.00% <0.00%> (ø)`
... and 6 files with indirect coverage changes

chrispader

LGTM! Thanks @ikevin127 for the quick workaround fix!

github-actions · 2026-01-12T15:48:32Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-12T17:56:56Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-12T18:02:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79291.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://79291.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…7-brokenCardFeed

melvin-bot · 2026-01-12T21:58:12Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

carlosmiceli · 2026-01-12T22:02:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88990a6b9c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…connect

OSBotify · 2026-01-12T23:14:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: broken card feed missing currentStep causing infinite loading (cherry picked from commit 8ef22e0) (cherry-picked to staging by roryabraham)

OSBotify · 2026-01-13T01:12:37Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.2.99-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-13T03:13:50Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-13T03:41:04Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T02:57:18Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: broken card feed missing currentStep causing infinite loading

ac95c58

melvin-bot Bot assigned ikevin127 Jan 11, 2026

chrispader approved these changes Jan 11, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

88990a6

…7-brokenCardFeed

ikevin127 marked this pull request as ready for review January 12, 2026 21:57

ikevin127 requested review from a team as code owners January 12, 2026 21:57

melvin-bot Bot requested review from JmillsExpensify and Julesssss and removed request for a team January 12, 2026 21:57

carlosmiceli requested review from carlosmiceli and removed request for Julesssss January 12, 2026 22:00

carlosmiceli previously approved these changes Jan 12, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jan 12, 2026

View reviewed changes

Comment thread ...orkspace/companyCards/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableHeaderButtons.tsx

fix: seed selectedCountry for Plaid feeds before broken connection re…

18d080a

…connect

ikevin127 dismissed carlosmiceli’s stale review via 18d080a January 12, 2026 22:37

carlosmiceli approved these changes Jan 12, 2026

View reviewed changes

carlosmiceli merged commit 8ef22e0 into Expensify:main Jan 12, 2026
32 checks passed

OSBotify pushed a commit that referenced this pull request Jan 13, 2026

Merge pull request #79291 from ikevin127/ikevin127-brokenCardFeed

cc4cd1c

fix: broken card feed missing currentStep causing infinite loading (cherry picked from commit 8ef22e0) (cherry-picked to staging by roryabraham)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 13, 2026

OSBotify mentioned this pull request Jan 13, 2026

Deploy Checklist: New Expensify 2026-01-09 #79227

Closed

77 tasks

Conversation

ikevin127 commented Jan 11, 2026 • edited by carlosmiceli Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chrispader left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 12, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jan 12, 2026

Uh oh!

github-actions Bot commented Jan 12, 2026

Uh oh!

melvin-bot Bot commented Jan 12, 2026

Uh oh!

carlosmiceli commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Jan 12, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ikevin127 commented Jan 11, 2026 •

edited by carlosmiceli

Loading

codecov Bot commented Jan 11, 2026 •

edited by github-actions Bot

Loading

carlosmiceli commented Jan 12, 2026 •

edited

Loading