Fix report title not updating when reimbursable expense is changed offline #79294

marufsharifi · 2026-01-11T13:04:58Z

Explanation of Change

Recalculate report total when reimbursable expense value changes in offline mode.

Fixed Issues

$ #74274
PROPOSAL: #74274 Comment

Tests

Precondition:

Edit the default report title formula to: Total {report:total} - Reimbursable {report:reimbursable} for the workspace.

Create an empty report
Add two transactions,
amount $150 (reimbursable toggle is on)
amount $50 (reimbursable toggle is off)
Report title should be "Total: $200.00 - Reimbursable: $150.00."
Go offline and toggle on the reimbursable for the $50 transaction created in step 2.
The Report title should change to "Total: $200.00 - Reimbursable: $200.00."
Add another transaction amount of $75, and (reimbursable toggle is on)
The report title should change to "Total: $275.00 - Reimbursable: $275.00".

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

and-n.mp4

Android: mWeb Chrome

and-w.mp4

iOS: Native

ios-n.mp4

iOS: mWeb Safari

ios-w.mp4

MacOS: Chrome / Safari

d-w.mp4

melvin-bot · 2026-01-11T13:05:05Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-11T13:13:22Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`71.62% <0.00%> (-0.07%)`	⬇️
src/libs/actions/IOU/index.ts	`67.72% <38.46%> (-0.11%)`	⬇️
... and 10 files with indirect coverage changes

mananjadhav · 2026-01-14T18:32:48Z

I am still reviewing and testing the PR. Will post an update tomorrow.

JS00001 · 2026-01-16T12:58:17Z

@mananjadhav Any update? @marufsharifi Conflicts

…dating

marufsharifi · 2026-01-16T13:39:48Z

@mananjadhav Any update? @marufsharifi Conflicts

@JS00001, thanks, conflicts resolved. @mananjadhav, the PR is ready for your review.

marufsharifi · 2026-01-19T06:27:25Z

@mananjadhav, kindly bump. thanks.

mananjadhav · 2026-01-19T06:28:21Z

I am reviewing another PR. I'll get to this by end of day.

mananjadhav · 2026-01-19T12:10:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Uploading android-reimbursable-offline.mov…

Android: mWeb Chrome

mweb-chrome-reimbursable-offline.mov

iOS: HybridApp

ios-reimbursable-offline.mov

iOS: mWeb Safari

mweb-safari-reimbursable-offline.mov

MacOS: Chrome / Safari

web-reimbursable-offline.mov

JmillsExpensify

No product spec changed. Looks good to me.

OSBotify · 2026-01-20T17:42:08Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ursable-report-title-not-updating" This reverts commit 9a6b28d, reversing changes made to b6b66f6.

Revert #79294 - Fix report title not updating when reimbursable expense is changed offline

Revert #79294 - Fix report title not updating when reimbursable expense is changed offline (cherry picked from commit c003a54) (cherry-picked to staging by Julesssss)

OSBotify · 2026-01-21T23:06:37Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:37:14Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-22T22:24:30Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix report title update when reimbursable expense changes offline

fccb22d

marufsharifi requested review from a team as code owners January 11, 2026 13:04

melvin-bot bot assigned marufsharifi Jan 11, 2026

melvin-bot bot requested review from JmillsExpensify and mananjadhav and removed request for a team January 11, 2026 13:05

Merge branch 'main' into fix/offline-reimbursable-report-title-not-up…

e7e5aaf

…dating

mananjadhav approved these changes Jan 19, 2026

View reviewed changes

melvin-bot bot requested a review from JS00001 January 19, 2026 18:57

JmillsExpensify approved these changes Jan 20, 2026

View reviewed changes

JS00001 approved these changes Jan 20, 2026

View reviewed changes

JS00001 merged commit 9a6b28d into Expensify:main Jan 20, 2026
31 checks passed

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

OSBotify mentioned this pull request Jan 20, 2026

Reports - Report title changes briefly when selecting a tag #80026

Closed

7 tasks

Julesssss added a commit that referenced this pull request Jan 21, 2026

Revert "Merge pull request #79294 from marufsharifi/fix/offline-reimb…

5d88ce7

…ursable-report-title-not-updating" This reverts commit 9a6b28d, reversing changes made to b6b66f6.

Julesssss mentioned this pull request Jan 21, 2026

[CP Staging] Revert #79294 - Fix report title not updating when reimbursable expense is changed offline #80051

Merged

Julesssss added a commit that referenced this pull request Jan 21, 2026

Merge pull request #80051 from Expensify/jules-revert79294

c003a54

Revert #79294 - Fix report title not updating when reimbursable expense is changed offline

melvin-bot bot mentioned this pull request Jan 22, 2026

[Due for payment 2026-01-29] [$250] Report title is not updated when change reimbursable expense offline #74274

Open

8 tasks

Fix report title not updating when reimbursable expense is changed offline #79294

Fix report title not updating when reimbursable expense is changed offline #79294

Uh oh!

Conversation

marufsharifi commented Jan 11, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 11, 2026

Uh oh!

codecov bot commented Jan 11, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mananjadhav commented Jan 14, 2026

Uh oh!

JS00001 commented Jan 16, 2026

Uh oh!

marufsharifi commented Jan 16, 2026

Uh oh!

marufsharifi commented Jan 19, 2026

Uh oh!

mananjadhav commented Jan 19, 2026

Uh oh!

mananjadhav commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 11, 2026 •

edited by github-actions bot

Loading

mananjadhav commented Jan 19, 2026 •

edited

Loading