Skip to content

Conversation

@JakubKorytko
Copy link
Contributor

@JakubKorytko JakubKorytko commented Jan 13, 2026

Explanation of Change

This PR adds:

  • The useMultifactorAuthenticationStatus helper hook
  • The useNativeBiometricsSetup internal hook
  • The useNativeBiometrics hook
  • MultifactorAuthenticationContext
  • Automated tests

Fixed Issues

$ #79371
$ #79058
$ #81020
PROPOSAL: N/A

Tests

  1. Open Expensify App
  2. Navigate to the Settings -> Troubleshoot
  3. Click on the "Test" button next to the "Biometrics (Not registered)" text.
  4. Click on the "Test" button in the RHP view.
  5. Fill the magic code input
  6. Click on the "Got it" button
  7. Authenticate using device credentials or biometry
  8. Verify that the Authentication was successful
  9. Verify that the registered label has changed to true
  10. Repeat steps 3 and 4
  11. Verify that validate code is no longer required
  12. Repeat test, but:
  • Fail the authentication
  • Input the wrong validate code (previously revoking the access on the Security page)
  • Cancel the authentication using back arrow / clicking outside the RHP
  1. Verify that the Authentication failed

Offline tests

N/A, D - Full Page Blocking UI Pattern for this project.

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android.mov
Android: mWeb Chrome
iOS: Native
iOS.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

@JakubKorytko JakubKorytko changed the title [WIP] [ECUK In-App 3DS] Implement useNativeBiometrics & useMultifactorAuthenticationStatus modules [WIP] [ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus Jan 19, 2026
@JakubKorytko JakubKorytko force-pushed the korytko/ecuk/3ds/implement-native-hooks branch from 5c0dcef to e96169a Compare January 19, 2026 18:23
@codecov
Copy link

codecov bot commented Jan 19, 2026

@JakubKorytko JakubKorytko changed the title [WIP] [ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus [HELD BY #79477] [ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus Jan 19, 2026
@JakubKorytko JakubKorytko force-pushed the korytko/ecuk/3ds/implement-native-hooks branch 4 times, most recently from 0cc2926 to 3ce42d3 Compare January 23, 2026 15:39
@JakubKorytko JakubKorytko force-pushed the korytko/ecuk/3ds/implement-native-hooks branch 2 times, most recently from 6b3a875 to daec038 Compare January 26, 2026 19:53
@JakubKorytko JakubKorytko changed the title [HELD BY #79477] [ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus [ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus Jan 26, 2026
@JakubKorytko JakubKorytko force-pushed the korytko/ecuk/3ds/implement-native-hooks branch from daec038 to 9f8e4ad Compare January 26, 2026 22:15
@JakubKorytko JakubKorytko marked this pull request as ready for review January 26, 2026 22:33
@JakubKorytko JakubKorytko requested review from a team as code owners January 26, 2026 22:33
@melvin-bot melvin-bot bot requested review from DylanDylann and trjExpensify and removed request for a team January 26, 2026 22:33
@JakubKorytko
Copy link
Contributor Author

Spanish translations confirmation post here

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

@JakubKorytko JakubKorytko changed the title [ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus [ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & helpers Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

Copy link
Contributor

@joekaufmanexpensify joekaufmanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well from my perspective!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.