-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & helpers
#79473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ECUK In-App 3DS] Implement MultifactorAuthenticationContext, useNativeBiometrics & helpers
#79473
Conversation
useNativeBiometrics & useMultifactorAuthenticationStatus modulesMultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus
5c0dcef to
e96169a
Compare
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatusMultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus
0cc2926 to
3ce42d3
Compare
6b3a875 to
daec038
Compare
MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatusMultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatus
daec038 to
9f8e4ad
Compare
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Spanish translations confirmation post here |
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Use large buttons for biometrics screens
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Add missing forceReplace
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…he soft prompt since they last reinstalled the app
MultifactorAuthenticationContext, useNativeBiometrics & useMultifactorAuthenticationStatusMultifactorAuthenticationContext, useNativeBiometrics & helpers
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well from my perspective!
Explanation of Change
This PR adds:
useMultifactorAuthenticationStatushelper hookuseNativeBiometricsSetupinternal hookuseNativeBiometricshookMultifactorAuthenticationContextFixed Issues
$ #79371
$ #79058
$ #81020
PROPOSAL: N/A
Tests
registeredlabel has changed totrueOffline tests
N/A,
D - Full Page Blocking UI Patternfor this project.QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.mov
Android: mWeb Chrome
iOS: Native
iOS.mov
iOS: mWeb Safari
MacOS: Chrome / Safari