[No QA] Fix Batch 1 of React Compiler warnings by roryabraham · Pull Request #79597 · Expensify/App

roryabraham · 2026-01-14T19:21:11Z

Explanation of Change

In this PR, I migrated a batch of hooks and components to become compatible with React Compiler. All of these were previously not compiling, but now they are. I also removed all manual memoization. This has two purposes:

Hopefully will improve baseline performance across the board
Simplifies implementation significantly by removing manual memoization (net ~1000 lines of code removed)

For this batch, I focused on components with only manual memoization errors and not other Rules of React violations that cause React Compiler to fail, but are trickier/risker to fix. I excluded files that:

Can't be compiled due to React Compiler limitations (such as template object keys or finally clauses)
Have lint rules that aren't compatible with the new code style for compiled components (such as rulesdir/no-inline-useOnyx-selector or react/jsx-no-constructed-context-values.

Fixed Issues

(partial) #68765

Tests

Full regression tests will be completed on an AdHoc build before merge.

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

None. Regression tests only.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Resolved conflicts in: - TransactionListItem.tsx: Kept new mergeProhibitedViolations and fallback logic, removed useMemo - AddUnreportedExpense.tsx: Used new AddUnreportedExpenseFooter component, removed useMemo - NewReportWorkspaceSelectionPage.tsx: Kept new changeTransactionsReport API, removed useCallback/useMemo - ProfilePage.tsx: Used currentUserAccountID from hook, removed useMemo

melvin-bot · 2026-01-14T19:21:15Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Resolved conflict in LoginUtils.ts by keeping both normalizeLogin (from our branch) and sanitizePhoneOrEmail (from main).

Resolve conflict in TransactionListItem.tsx: - Keep new policyID fallback logic for self DM tracking expenses - Keep new policyCategories fetch and syncMissingAttendeesViolation - Remove useMemo wrappers to trust React Compiler

github-actions · 2026-01-14T23:38:18Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-15T00:02:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79597.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6e902d9b9f45448c1aa2f9464c63c204b8cbf84f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-beee5a4c2c373658fdd27561ee2e1ee9919cc4b6/index.html

Web 🕸️
https://79597.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

nlemma · 2026-01-15T11:00:52Z

Expense - Report field in IOU expense shows IOU, Report field in self DM is blank

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.3.2-0 PR:79597
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2977/folder/13177029/41237792/1126277307
Email or phone of affected tester (no customers): sdjoisnjosjsodisjoijsi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.1 / Chrome

Action Performed:

Go to 79597.pr-testing.expensify.com
Open 1:1 DM.
Create an expense.
Open the expense report.
BUG 1: Report field shows IOU instead of "User owes x".
Go to self DM.
Create an expense.
Open the expense report.
BUG 2: Report field is empty.

Expected Result:

BUG 1: Report field will show "User owes x".
BUG 2: Report field shows User (You).

Actual Result:

BUG 1: Report field shows IOU instead of "User owes x".
BUG 2: Report field is empty.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7049847_1768474118357.12.mp4

View all open jobs on GitHub

jponikarchuk · 2026-01-15T14:14:23Z

This issue is still reproducible in the current build.

Resolve conflicts: - SearchSidebar.tsx: Keep without useMemo import - TransactionListItem.tsx: Use currentSearchResults from SearchContext instead of snapshot, add exportedReportActions, all without useMemo - WorkspaceReportsPage.tsx: Keep without useMemo/useCallback, add type fallback for reportField.type

roryabraham · 2026-01-16T16:44:46Z

these issues are reproducible on main.

Kept lower max-warnings count (367) from React Compiler work.

melvin-bot · 2026-01-16T18:41:02Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

Resolved conflict in SplitExpensePage.tsx - kept non-memoized version (trusting React Compiler).

inimaga

Overall the changes look good to me and no massive blockers. Just had a couple of clarifying questions regarding some bits.

src/pages/tasks/NewTaskPage.tsx

src/pages/NewChatPage.tsx

src/components/SelectionListWithSections/Search/TransactionListItem.tsx

inimaga · 2026-01-19T19:03:38Z

You've also picked up some conflicts and lint errors.

Resolved conflicts: - EmptySearchView.tsx: Added isFilteredWorkspaceAccessible logic (from main) without useMemo, integrated into existing assignment-based pattern - SplitExpensePage.tsx: Added preferredLocale parameter to date formatting (from main) while keeping non-memoized version

roryabraham · 2026-01-19T19:19:33Z

Conflicts resolved. I've fixed all lint errors except some in lint-changed that were pre-existing in some of the files touched here. I don't intend to fix all these to minimize the risk of this already-large PR.

src/pages/Search/EmptySearchView.tsx

inimaga · 2026-01-19T21:24:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

roryabraham · 2026-01-19T21:48:51Z

Merging through failing checks as discussed here: https://expensify.slack.com/archives/C05LX9D6E07/p1768857854486449?thread_ts=1768850793.632499&cid=C05LX9D6E07

melvin-bot · 2026-01-19T21:49:02Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2026-01-19T21:58:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-20T17:42:53Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:07:22Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

roryabraham added 5 commits January 13, 2026 17:48

Migrate first batch of components

a20414b

Migrate first batch of hooks

2f3e8cf

Migrate AddUnreportedExpense

e5e3243

Migrate first batch of pages

9badcd3

roryabraham self-assigned this Jan 14, 2026

roryabraham added 3 commits January 14, 2026 13:34

Fix implicit any in useSelectedTransactionsActions

64b9b30

Fix errors in useSearchHighlightAndScroll

8973d66

Revert files that don't compile or have conflicting ESLint rules

f20b4b6

roryabraham changed the title ~~[WIP] Fix Batch 1 of React Compiler warnings~~ [WIP][No QA] Fix Batch 1 of React Compiler warnings Jan 14, 2026

Merge main into Rory-ReactCompilerFirstPass

9078e51

Resolved conflict in LoginUtils.ts by keeping both normalizeLogin (from our branch) and sanitizePhoneOrEmail (from main).

This comment was marked as off-topic.

Sign in to view

roryabraham added 4 commits January 14, 2026 15:11

Fix lint

1dd5b4b

Merge main into Rory-ReactCompilerFirstPass

ad5bfe9

Resolve conflict in TransactionListItem.tsx: - Keep new policyID fallback logic for self DM tracking expenses - Keep new policyCategories fetch and syncMissingAttendeesViolation - Remove useMemo wrappers to trust React Compiler

Revert AddUnreportedExpense (useOnyx selector incompatibility)

8c3de4e

Update warning count

06e9f3c

roryabraham mentioned this pull request Jan 14, 2026

[Tracking] Use React Compiler to enforce the Rules of React #68765

Open

roryabraham added 3 commits January 15, 2026 14:46

Fix lint after merge

b6bdb2b

Fix lint

04182d0

Merge main into Rory-ReactCompilerFirstPass

210de0e

Kept lower max-warnings count (367) from React Compiler work.

roryabraham changed the title ~~[WIP][No QA] Fix Batch 1 of React Compiler warnings~~ [No QA] Fix Batch 1 of React Compiler warnings Jan 16, 2026

roryabraham requested a review from AndrewGable January 16, 2026 18:41

roryabraham added 3 commits January 16, 2026 11:47

Merge main into Rory-ReactCompilerFirstPass

4ed50a4

Resolved conflict in SplitExpensePage.tsx - kept non-memoized version (trusting React Compiler).

Fix type error in IOUTest

f293678

Adjust warning count after merge to main

ac8e5b9

kacper-mikolajczak mentioned this pull request Jan 19, 2026

[AI Reviewer] Testing tracking issue #79390

Closed

inimaga reviewed Jan 19, 2026

View reviewed changes

src/pages/tasks/NewTaskPage.tsx Show resolved Hide resolved

src/pages/NewChatPage.tsx Show resolved Hide resolved

src/components/SelectionListWithSections/Search/TransactionListItem.tsx Outdated Show resolved Hide resolved

roryabraham added 2 commits January 19, 2026 11:05

Revert unintentional logic change in TransactionListItem

9493723

fix EmptySearchView after merge

9876251

inimaga requested changes Jan 19, 2026

View reviewed changes

src/pages/Search/EmptySearchView.tsx Outdated Show resolved Hide resolved

roryabraham requested a review from inimaga January 19, 2026 21:23

inimaga previously approved these changes Jan 19, 2026

View reviewed changes

Update warning count after merging main

0bf7ad2

roryabraham dismissed inimaga’s stale review via 0bf7ad2 January 19, 2026 21:30

inimaga approved these changes Jan 19, 2026

View reviewed changes

AndrewGable approved these changes Jan 19, 2026

View reviewed changes

roryabraham merged commit cac193a into main Jan 19, 2026
41 of 43 checks passed

roryabraham deleted the Rory-ReactCompilerFirstPass branch January 19, 2026 21:48

melvin-bot bot added the Emergency label Jan 19, 2026

roryabraham removed the Emergency label Jan 19, 2026

ShridharGoel mentioned this pull request Jan 20, 2026

[NoQA] Update max warnings for ESLint in package.json #79963

Merged

54 tasks

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

situchan mentioned this pull request Jan 21, 2026

[CP Staging] Revert "Fix localization: dates not being localized correctly" #80124

Merged

54 tasks

Conversation

roryabraham commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 14, 2026

Uh oh!

This comment was marked as off-topic.

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

nlemma commented Jan 15, 2026

Expense - Report field in IOU expense shows IOU, Report field in self DM is blank

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Uh oh!

jponikarchuk commented Jan 15, 2026

Uh oh!

roryabraham commented Jan 16, 2026

Uh oh!

melvin-bot bot commented Jan 16, 2026

Uh oh!

inimaga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inimaga commented Jan 19, 2026

Uh oh!

roryabraham commented Jan 19, 2026

Uh oh!

Uh oh!

inimaga commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

roryabraham commented Jan 19, 2026

Uh oh!

Uh oh!

melvin-bot bot commented Jan 19, 2026

Uh oh!

OSBotify commented Jan 19, 2026

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

roryabraham commented Jan 14, 2026 •

edited

Loading

inimaga commented Jan 19, 2026 •

edited

Loading