Perf: Split `SearchRouter` to State and Actions #79753

staszekscp · 2026-01-16T09:46:34Z

Explanation of Change

The PR splits the SearchRouterContext into State and Actions in order to make sure, that if some component uses only state-agnostic actions doesn't re-render when the state changes.

Performance of SearchAutocompleteList based on the browser INP metrics.

Opening: 89,8 ms -> 77,6 ms (-15,7%)
Closing: 218,0 ms -> 203,7 ms (-7,0%)

Fixed Issues

$ #79353
PROPOSAL: N/A

Tests

Open and close the SearchRouter several times to see if the app doesn't crash

Offline tests

QA Steps

Open and close the SearchRouter several times to see if the app doesn't crash

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-19.at.11.54.17.mov

Android: mWeb Chrome

Screen.Recording.2026-01-19.at.11.59.24.mov

iOS: Native

Screen.Recording.2026-01-16.at.17.05.59.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-19.at.11.58.18.mov

…outer

codecov · 2026-01-16T10:52:51Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../Search/SearchPageHeader/SearchPageHeaderInput.tsx	`37.36% <100.00%> (ø)`
...rc/components/Search/SearchRouter/SearchButton.tsx	`100.00% <100.00%> (+42.85%)`	⬆️
...mponents/Search/SearchRouter/SearchRouterModal.tsx	`100.00% <ø> (ø)`
src/libs/Navigation/AppNavigator/AuthScreens.tsx	`51.37% <100.00%> (ø)`
...onents/Search/SearchRouter/SearchRouterContext.tsx	`55.17% <58.82%> (+1.60%)`	⬆️
... and 303 files with indirect coverage changes

dariusz-biela

This is a step in the right direction.

To be sure, I checked that the original function logic was preserved and everything is fine.

src/components/Search/SearchRouter/SearchRouterContext.tsx

dariusz-biela · 2026-01-16T12:14:24Z

src/components/Search/SearchRouter/SearchRouterModal.tsx

Run npm run prettier

adamgrzybowski · 2026-01-16T12:55:06Z

src/components/Search/SearchRouter/SearchRouterContext.tsx

+    const actionsContextValue = {
+        openSearchRouter,
+        closeSearchRouter,
+        toggleSearch,
+        registerSearchPageInput,
+        unregisterSearchPageInput,
+    };
+
+    const stateContextValue = {isSearchRouterDisplayed}


Normally I use useMemo for context value but not sure if this is sucha a case since we have react-compiler

I let the React Compiler do its job here - I've checked the results with and without the manual memoisation, and React Compiler slightly wins!

mountiny · 2026-01-17T10:16:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 092408d34f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/Search/SearchRouter/SearchRouterContext.tsx

melvin-bot · 2026-01-19T11:03:20Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-19T11:07:01Z

src/components/Search/SearchRouter/SearchButton.tsx

                style={[styles.flexRow, styles.touchableButtonImage, style]}
                shouldUseAutoHitSlop={shouldUseAutoHitSlop}
                sentryLabel={CONST.SENTRY_LABEL.SEARCH.SEARCH_BUTTON}
+                // eslint-disable-next-line react-hooks/refs


❌ CONSISTENCY-5 (docs)

ESLint rule disables without justification can mask underlying issues and reduce code quality. Clear documentation ensures team members understand exceptions, promoting better maintainability.

Suggested fix:
Add a comment explaining why the react-hooks/refs rule needs to be disabled here. For example:

// eslint-disable-next-line react-hooks/refs -- <explanation of why this is needed>

Please add comment as bot says

This change is unrelated to my PR and I haven't touched the code below it, but because of the es-lint failure I decided to disable it to improve visibility of the issue

@aimane-chnaif Just to let you know instead of a comment I moved the function to follow the Rules of React so it can be compiled, because it turned out it's an easy one

aimane-chnaif · 2026-01-19T11:30:45Z

src/components/Search/SearchRouter/SearchButton.tsx

                style={[styles.flexRow, styles.touchableButtonImage, style]}
                shouldUseAutoHitSlop={shouldUseAutoHitSlop}
                sentryLabel={CONST.SENTRY_LABEL.SEARCH.SEARCH_BUTTON}
+                // eslint-disable-next-line react-hooks/refs


Please add comment as bot says

aimane-chnaif · 2026-01-19T11:32:18Z

src/components/Search/SearchRouter/SearchRouterContext.tsx

+    // Because of the React Compiler we don't need to memoize it manually
+    // eslint-disable-next-line react/jsx-no-constructed-context-values


Does it cause lint error without this comment?

Yes, it does

aimane-chnaif · 2026-01-19T11:32:32Z

src/components/Search/SearchRouter/SearchRouterContext.tsx

+    // Because of the React Compiler we don't need to memoize it manually
+    // eslint-disable-next-line react/jsx-no-constructed-context-values


Same as above

Yep, there is a lint error

aimane-chnaif · 2026-01-20T07:58:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

chatgpt-codex-connector · 2026-01-20T08:27:57Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JmillsExpensify

Product review not required.

mountiny

Thanks Mariusz, nice change!

OSBotify · 2026-01-20T17:30:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-21T23:38:02Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-22T22:25:18Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

staszekscp added 3 commits January 16, 2026 08:31

Split SearchRouter to State and Actions

fc9d7bf

Merge remote-tracking branch 'origin/main' into perf/inprove-search-r…

5352122

…outer

Fix double import

fbc3d90

melvin-bot bot assigned staszekscp Jan 16, 2026

staszekscp added 2 commits January 16, 2026 11:42

Remove memoisation in SearchRouterContext to allow Compiler do its job

728c413

Fix linter

242e7d0

dariusz-biela reviewed Jan 16, 2026

View reviewed changes

adamgrzybowski reviewed Jan 16, 2026

View reviewed changes

Fix prettier

092408d

chatgpt-codex-connector bot reviewed Jan 17, 2026

View reviewed changes

src/components/Search/SearchRouter/SearchRouterContext.tsx Show resolved Hide resolved

Disable unrelated es-lint rules

b90935c

staszekscp marked this pull request as ready for review January 19, 2026 11:03

staszekscp requested review from a team as code owners January 19, 2026 11:03

melvin-bot bot requested review from JmillsExpensify and aimane-chnaif January 19, 2026 11:03

melvin-bot bot removed request for a team January 19, 2026 11:03

github-actions bot reviewed Jan 19, 2026

View reviewed changes

aimane-chnaif reviewed Jan 19, 2026

View reviewed changes

Remove es-lint error and enable React Compiler for SearchButton.tsx

ef66bc4

aimane-chnaif approved these changes Jan 20, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny January 20, 2026 08:29

JmillsExpensify reviewed Jan 20, 2026

View reviewed changes

mountiny approved these changes Jan 20, 2026

View reviewed changes

mountiny merged commit 03d098f into Expensify:main Jan 20, 2026
31 of 32 checks passed

mountiny mentioned this pull request Jan 21, 2026

Refactor SplashScreenStateContext to improve performance and usability #80123

Closed

51 tasks

OSBotify mentioned this pull request Jan 21, 2026

Deploy Checklist: New Expensify 2026-01-21 #80164

Closed

78 tasks

staszekscp mentioned this pull request Jan 22, 2026

Refactor ContextProviders with AI #80196

Open

51 tasks

mountiny mentioned this pull request Jan 22, 2026

Split context providers to return State and Actions separately #80271

Open

melvin-bot bot mentioned this pull request Jan 22, 2026

[Due for payment 2026-01-29] [Metrics] Improve ManualOpenSearchRouter time performance #79353

Open

		// Because of the React Compiler we don't need to memoize it manually
		// eslint-disable-next-line react/jsx-no-constructed-context-values

Perf: Split SearchRouter to State and Actions #79753

Perf: Split SearchRouter to State and Actions #79753

Conversation

staszekscp commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dariusz-biela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jan 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot bot commented Jan 19, 2026

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-5 (docs)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staszekscp Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Jan 20, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 22, 2026

Uh oh!

Perf: Split `SearchRouter` to State and Actions #79753

Perf: Split `SearchRouter` to State and Actions #79753

staszekscp commented Jan 16, 2026 •

edited

Loading

codecov bot commented Jan 16, 2026 •

edited by github-actions bot

Loading

adamgrzybowski Jan 16, 2026 •

edited

Loading

staszekscp Jan 19, 2026 •

edited

Loading

aimane-chnaif commented Jan 20, 2026 •

edited

Loading