-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Added new spans for bootsplashvisible #79764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new spans for bootsplashvisible #79764
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…or locale and bootsplash features
…alization and navigation
| SPLASH_HIDER: 'BootsplashVisibleHider', | ||
| }, | ||
| SPAN_LOCALE: { | ||
| ROOT: 'BootsplashVisibleLocale', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this BootsplashVisibleLocale name correct? Maybe ROOT should be something more specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I maintained the convention that was initially created for SPAN_BOOTSPLASH, since the child elements were created for that specific one
| EMOJI_IMPORT: 'LocaleEmojiImport', | ||
| }, | ||
| SPAN_NAVIGATION: { | ||
| ROOT: 'BootsplashVisibleNavigation', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
| const bootsplashSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ROOT); | ||
| startSpan(CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, { | ||
| name: CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, | ||
| op: CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, | ||
| parentSpan: bootsplashSpan, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const bootsplashSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ROOT); | |
| startSpan(CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, { | |
| name: CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, | |
| op: CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, | |
| parentSpan: bootsplashSpan, | |
| }); | |
| startSpan(CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, { | |
| name: CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, | |
| op: CONST.TELEMETRY.SPAN_NAVIGATION.PUSHER_INIT, | |
| parentSpan: getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ROOT), | |
| }); |
| const localeSpan = getSpan(CONST.TELEMETRY.SPAN_LOCALE.ROOT); | ||
|
|
||
| startSpan(CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, { | ||
| name: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | ||
| op: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | ||
| parentSpan: localeSpan, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const localeSpan = getSpan(CONST.TELEMETRY.SPAN_LOCALE.ROOT); | |
| startSpan(CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, { | |
| name: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | |
| op: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | |
| parentSpan: localeSpan, | |
| }); | |
| startSpan(CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, { | |
| name: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | |
| op: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | |
| parentSpan: getSpan(CONST.TELEMETRY.SPAN_LOCALE.ROOT), | |
| }); |
No need to create separate variable if you are not going to reuse it.
|
|
||
| if (!account || account.isFromPublicDomain) { | ||
| return; | ||
| return undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is unnecessary
| // If the user haven't completed the flow, we want to always redirect them to the onboarding flow. | ||
| // We also make sure that the user is authenticated, isn't part of a group workspace, isn't in the transition flow & wasn't invited to NewDot. | ||
| if (!CONFIG.IS_HYBRID_APP && !hasNonPersonalPolicy && !isOnboardingCompleted && !wasInvitedToNewDot && authenticated && !isTransitioning) { | ||
| if (!CONFIG.IS_HYBRID_APP && !hasNonPersonalPolicy && !isOnboardingCompleted && !wasInvitedToNewDot && authenticated) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this line changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The !isTransitioning check was redundant. If isTransitioning is true, the code returns early at line 140 (if (isTransitioning) { return ... }), so it never reaches this condition. By the time we get here, isTransitioning is always false.
| const bootsplashSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ROOT); | ||
| startSpan(CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, { | ||
| name: CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, | ||
| op: CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, | ||
| parentSpan: bootsplashSpan, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const bootsplashSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ROOT); | |
| startSpan(CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, { | |
| name: CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, | |
| op: CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, | |
| parentSpan: bootsplashSpan, | |
| }); | |
| startSpan(CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, { | |
| name: CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, | |
| op: CONST.TELEMETRY.SPAN_NAVIGATION_ROOT_READY, | |
| parentSpan: getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ROOT), | |
| }); |
src/libs/actions/Link.ts
Outdated
| const publicRoomCheckSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_CHECK); | ||
| startSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, { | ||
| name: CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, | ||
| op: CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, | ||
| parentSpan: publicRoomCheckSpan, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const publicRoomCheckSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_CHECK); | |
| startSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, { | |
| name: CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, | |
| op: CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, | |
| parentSpan: publicRoomCheckSpan, | |
| }); | |
| startSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, { | |
| name: CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, | |
| op: CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_API, | |
| parentSpan: getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.PUBLIC_ROOM_CHECK), | |
| }); |
src/libs/migrateOnyx.ts
Outdated
| const parentSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX); | ||
|
|
||
| startSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, { | ||
| name: CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, | ||
| op: CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, | ||
| parentSpan, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const parentSpan = getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX); | |
| startSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, { | |
| name: CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, | |
| op: CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, | |
| parentSpan, | |
| }); | |
| startSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, { | |
| name: CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, | |
| op: CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX_MIGRATIONS, | |
| parentSpan: getSpan(CONST.TELEMETRY.SPAN_BOOTSPLASH.ONYX), | |
| }); |
…val across components
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…to feat/improve-visibility-in-bootsplashvisible
|
converting to draft, I need to pay attention for web build 👀 Edit: All good |
This reverts commit 07c62f8.
…to feat/improve-visibility-in-bootsplashvisible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa3450d243
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.mp4Android: mWeb Chromeandroid.mweb.mp4iOS: HybridAppios.mp4iOS: mWeb Safariios.mweb.mp4MacOS: Chrome / Safariweb.mp4 |
| startSpan(CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, { | ||
| name: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | ||
| op: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT, | ||
| parentSpan: getSpan(CONST.TELEMETRY.SPAN_LOCALE.ROOT), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that SPAN_LOCALE.ROOT is never started and only used as a parentSpan. Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is intentional, It share the same string value by design to maintain a clear span hierarchy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
bernhardoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…lity-in-bootsplashvisible
…after Onyx migrations complete
rlinoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.10-0 🚀
|
|
@BartekObudzinski Is it an internal PR? QA team can't execute the mentioned steps |
|
Yeah, this is internal qa, sorry, I can take it. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀
|


Explanation of Change
Fixed Issues
$ #79955
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-21.at.08.36.22.mov
Android: mWeb Chrome
Screen.Recording.2026-01-21.at.08.39.35.mov
iOS: Native
Screen.Recording.2026-01-21.at.08.32.25.mov
iOS: mWeb Safari
Screen.Recording.2026-01-21.at.08.33.47.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-21.at.08.27.37.mov