[NoQA] Feature: Travel Invoicing - Release 2.3: Update Settlement Account Flow #79809

ikevin127 · 2026-01-17T04:01:00Z

Explanation of Change

UX Flow

In the active state, the summary shows a “Settlement account” row with the current bank name / last 4.
When the admin taps the row:
- We reuse the existing workspace card settlement account picker screen (the same one used when configuring the Expensify Card settlement account in WorkspaceCardPage.tsx). When the “Settlement account” row is tapped from WorkspaceTravelInvoicingSection, we navigate to that screen with an extra context flag (mode = 'travelInvoicing'), and on selection we call setTravelInvoicingSettlementAccount instead of the card‑specific action.
- That screen shows:
  - Any existing bank accounts linked for this domain.
  - A “Connect a new bank” path (reusing the Expensify Card settlement flow).
When the admin selects an account:
- We call the Travel Invoicing settlement account action.
- On success, we return to the Travel page and show the updated account in the summary.

Data & Onyx

The settlement account is read from:
- The same NVP structure used by Expensify Card in private_expensifyCardSettings, but for the PROGRAM_TRAVEL_US feed.
Our selector:
- getTravelSettlementAccount(policy) returns a structure like {displayName, last4, bankAccountID} for use in UI.
After calling the backend to set a new settlement account:
- The server updates the NVP, and policy in Onyx is refreshed.
- getTravelSettlementAccount(policy) recomputes to the new bank, which updates the row.

Actions
New function in src/libs/actions/TravelInvoicing.ts:

setTravelInvoicingSettlementAccount({policyID, settlementAccountID}):
- Wraps backend SetTravelInvoicingSettlementAccount.
- On error, shows a localized error toast.

Components & reuse
Navigation:

When row is tapped, we route to the same screen used by card settlement account flows, e.g. WorkspaceBankAccountSelectorPage, with an extra param indicating this is for Travel Invoicing.

Settlement account screen:

Reuses existing bank connection list and “Connect bank” UI used for Expensify Card.
The only difference is which action we call on selection (setTravelInvoicingSettlementAccount vs the card’s action).

Testing
Component tests:

Tapping the “Settlement account” row triggers navigation with the correct params (policyID, context = 'travel').

Integration:

From a test user, select a different settlement account, verify the Travel Invoicing summary row updates after the mock backend updates the policy.

Fixed Issues

$ #78675
PROPOSAL:

Tests

Note

Right now in order to test the section locally - tester can edit / comment out two blocks of code to be able to see the new section in Workspace Settings > Travel, below is a diff:

DIFF

diff --git a/src/pages/workspace/travel/PolicyTravelPage.tsx b/src/pages/workspace/travel/PolicyTravelPage.tsx
index d40bc2682fd..f024973df16 100644
--- a/src/pages/workspace/travel/PolicyTravelPage.tsx
+++ b/src/pages/workspace/travel/PolicyTravelPage.tsx
@@ -46,17 +46,18 @@ function WorkspaceTravelPage({
     const step = getTravelStep(policy, travelSettings, isBetaEnabled(CONST.BETAS.IS_TRAVEL_VERIFIED), policies, currentUserLogin);
 
     const mainContent = (() => {
-        switch (step) {
-            case CONST.TRAVEL.STEPS.BOOK_OR_MANAGE_YOUR_TRIP:
-                if (isTravelInvoicingEnabled) {
-                    return <WorkspaceTravelInvoicingSection policyID={policyID} />;
-                }
-                return <BookOrManageYourTrip policyID={policyID} />;
-            case CONST.TRAVEL.STEPS.REVIEWING_REQUEST:
-                return <ReviewingRequest />;
-            default:
-                return <GetStartedTravel policyID={policyID} />;
-        }
+        return <WorkspaceTravelInvoicingSection policyID={policyID} />;
+        // switch (step) {
+        //     case CONST.TRAVEL.STEPS.BOOK_OR_MANAGE_YOUR_TRIP:
+        //         if (isTravelInvoicingEnabled) {
+        //             return <WorkspaceTravelInvoicingSection policyID={policyID} />;
+        //         }
+        //         return <BookOrManageYourTrip policyID={policyID} />;
+        //     case CONST.TRAVEL.STEPS.REVIEWING_REQUEST:
+        //         return <ReviewingRequest />;
+        //     default:
+        //         return <GetStartedTravel policyID={policyID} />;
+        // }
     })();
 
     return (
diff --git a/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx b/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
index d0bb2ec87ca..8b65df8c5ff 100644
--- a/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
+++ b/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
@@ -167,9 +167,9 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
 
     // If Travel Invoicing is not enabled or no settlement account is configured
     // show the BookOrManageYourTrip component as fallback
-    if (!isTravelInvoicingEnabled || !hasSettlementAccount) {
-        return <BookOrManageYourTrip policyID={policyID} />;
-    }
+    // if (!isTravelInvoicingEnabled || !hasSettlementAccount) {
+    //     return <BookOrManageYourTrip policyID={policyID} />;
+    // }
 
     return (
         <>

Test 1: Navigation Flow

Go to Settings > Workspaces > [Workspace] > Travel.
In the Travel Invoicing section, tap Settlement account row.
Expected: RHP opens showing bank account list (if any exist).

Test 2: Account Selection

From the Settlement account picker, select a bank account.
Expected:

Selection updates immediately (optimistic)
RHP closes automatically
Settlement account row shows bank account's last four.

Test 3: Persistence

After changing settlement account, navigate away from Travel page.
Return to Travel page.
Expected: The previously assigned settlement account is persisted.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

web.mov

ios-hybrid.mov

melvin-bot · 2026-01-17T04:01:06Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-01-17T04:01:08Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-17T04:01:13Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx

src/pages/workspace/travel/WorkspaceTravelSettlementAccountPage.tsx

codecov · 2026-01-17T04:11:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/libs/TravelInvoicingUtils.ts	`100.00% <100.00%> (ø)`
src/libs/actions/TravelInvoicing.ts	`60.00% <100.00%> (+60.00%)`	⬆️
src/ROUTES.ts	`13.07% <0.00%> (-0.11%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.81% <0.00%> (-0.02%)`	⬇️
...rkspace/travel/WorkspaceTravelInvoicingSection.tsx	`89.65% <71.42%> (-6.18%)`	⬇️
...e/expensifyCard/WorkspaceSettlementAccountPage.tsx	`0.00% <0.00%> (ø)`
... and 2 more
... and 20 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47fc11416e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/TravelInvoicing.ts

The merge-base changed after approval.

…7-travel-invoicing-23

ikevin127 · 2026-01-22T02:56:14Z

@parasharrajat 🟢 Ready for review - just merged main after we merged the first PR.

parasharrajat · 2026-01-27T08:04:47Z

src/libs/actions/TravelInvoicing.ts

+ */
+function setTravelInvoicingSettlementAccount(policyID: string, workspaceAccountID: number, settlementBankAccountID: number, previousPaymentBankAccountID?: number) {
+    const cardSettingsKey =
+        `${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${workspaceAccountID}_${CONST.TRAVEL.PROGRAM_TRAVEL_US}` as `${typeof ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${string}`;


Do we need to add explicity type here?

parasharrajat · 2026-01-27T08:10:55Z

src/libs/actions/TravelInvoicing.ts

+            },
+        },
+    ];
+    Onyx.update(onyxData);


Can we use Onyx.merge here...

parasharrajat · 2026-01-27T08:31:14Z

src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx

+                    >
+                        <MenuItemWithTopDescription
+                            description={translate('workspace.moreFeatures.travel.travelInvoicing.centralInvoicingSection.subsections.settlementAccountLabel')}
+                            title={settlementAccountNumber || translate('common.none')}


Should this be empty on fallback instead of none.

parasharrajat · 2026-01-27T08:32:22Z

src/pages/workspace/travel/WorkspaceTravelSettlementAccountPage.tsx

Can we reuse the existing component if we already have a settlement page component? We should modify that to work for this section.

Used created a wrapper component WorkspaceTravelInvoicingSettlementAccountPage (renamed) that uses existing Expensify Card - Settlement account page but for Travel Invoicing via isTravelInvoicing (boolean) prop / conditional logic.

…7-travel-invoicing-23

ikevin127 · 2026-01-28T00:07:12Z

🟢 Ready for a final pass!

Screen.Recording.2026-01-27.at.15.10.04.mov

src/pages/workspace/expensifyCard/WorkspaceSettlementAccountPage.tsx

parasharrajat · 2026-01-28T09:47:00Z

Looking good. I have one more comment before we finalize.

blimpich · 2026-01-28T21:27:54Z

testing k2 extension, ignore this comment

ikevin127 · 2026-01-29T00:30:26Z

🟢 Resolved all previous review comments in latest commit - aligned Expensify card and Travel Invoicing - Settlement account flows behaviour in terms of offline behaviour as discussed on Slack.

Ready for a final pass and possibly merge! 🎉

parasharrajat · 2026-01-29T15:55:34Z

src/components/SettlementAccountSelector.tsx

+    );
+}
+
+SettlementAccountSelector.displayName = 'SettlementAccountSelector';


No Blocker: not needed.

✅ Removed.

…7-travel-invoicing-23

parasharrajat · 2026-01-30T09:12:33Z

Screenshots

🔲 iOS / native

30.01.2026_14.58.58_REC.mp4

🔲 iOS / Safari

30.01.2026_15.02.44_REC.mp4

🔲 MacOS / Chrome

30.01.2026_14.14.50_REC.mp4

🔲 Android / Chrome

🔲 Android / native

30.01.2026_14.43.40_REC.mp4

parasharrajat · 2026-01-30T09:21:51Z

BUG: Add bank account button does not show Full page blocked view while you are offline.

We can add that in next PR as this is behind beta.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2026-01-30T09:34:29Z

One change requested above. We can merge this PR and address that in the next PRs, as it is NoQA.

ikevin127 · 2026-01-30T10:43:12Z

BUG: Add bank account button does not show Full page blocked view while you are offline.

I think this is fine since the flow is aligned with Expensify card - even if you click on the button, you'll be blocked by existing add BA flow (Continue button disabled while offline).

OSBotify · 2026-01-30T17:46:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:16:12Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: release 2.3 - update settlement account flow

47fc114

ikevin127 requested review from a team as code owners January 17, 2026 04:01

melvin-bot bot assigned ikevin127 Jan 17, 2026

melvin-bot bot requested review from joekaufmanexpensify and parasharrajat and removed request for a team January 17, 2026 04:01

melvin-bot bot requested review from a team and blimpich and removed request for a team January 17, 2026 04:01