Skip to content

Conversation

@VictoriaExpensify
Copy link
Contributor

@VictoriaExpensify VictoriaExpensify commented Jan 19, 2026

Article incorrectly referrenced the Expensify Card for non-US users

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Article incorrectly referrenced the Expensify Card for non-US users
@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR corrects inaccurate information about Expensify Card availability for non-US users in the Billing Overview documentation. The changes appropriately remove references to card-based pricing and cash back options from GBP, EUR, AUD, and NZD currency sections, while maintaining these details for USD. The corrections improve accuracy and prevent user confusion.

Scores Summary

  • Readability: 9/10 - Clear, concise language with well-structured pricing information. Slight deduction for one typo introduced.
  • AI Readiness: 10/10 - Excellent metadata, clear headings with descriptive titles, proper YAML structure, and consistent heading hierarchy.
  • Style Compliance: 8/10 - Good adherence to formatting and terminology standards, but contains one typo and inconsistent phrasing across currency sections.

Key Findings

Positive Aspects:

  • Correctly removes misleading card references for non-US currencies
  • Maintains consistent structure across currency blocks
  • Preserves the important clarification "(US Only)" in the heading
  • Proper use of HTML formatting for currency selector sections
  • No impact on navigation or metadata

Issues Identified:

  1. Critical typo (line 83): "AU$60 ay-per-use" should be "AU$60 pay-per-use" (missing 'p')
  2. Inconsistent terminology: Some sections say "without Card or for pay-per-use" while updated sections say just "pay-per-use"
  3. Cash back reference removal: The EUR section previously mentioned "Earn up to 2% cash back" which was removed but USD section retained similar language - this creates some inconsistency in whether card benefits apply to non-US currencies

Content Accuracy:

  • The removal of card references from non-US pricing is correct
  • The "(US Only)" clarification in the section heading is appropriate
  • Simplification of Control plan pricing descriptions improves clarity

Recommendations

Must Fix:

  1. Correct the typo on line 83: Change "AU$60 ay-per-use" to "AU$60 pay-per-use"

Should Consider:

  1. Review whether cash back information should be consistently removed from all non-USD Control plan descriptions
  2. Consider adding a brief note in non-USD currency sections explicitly stating "Expensify Card is available for USD billing only" to make the limitation clearer
  3. Ensure consistent phrasing across all currency blocks (e.g., "pay-per-use" terminology)

Files Reviewed

  • docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md: Contains one critical typo that must be fixed before merge. Otherwise, changes correctly address the PR objective of removing incorrect card references for non-US users.

Note: This is a summary assessment. The primary action required is fixing the typo on line 83.

@VictoriaExpensify VictoriaExpensify requested a review from a team January 19, 2026 00:13
@melvin-bot
Copy link

melvin-bot bot commented Jan 19, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot melvin-bot bot requested a review from greg-schroeder January 19, 2026 00:13
@melvin-bot
Copy link

melvin-bot bot commented Jan 19, 2026

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 19, 2026 00:13
@github-actions github-actions bot changed the title Update billing details and remove optional card mention [No QA] Update billing details and remove optional card mention Jan 19, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Jan 19, 2026

A preview of your ExpensifyHelp changes have been deployed to https://556733a5.helpdot.pages.dev ⚡️

Updated articles:

Removed mention of optional Expensify Card from billing overview.
@jliexpensify jliexpensify self-requested a review January 19, 2026 01:53
Copy link
Contributor

@jliexpensify jliexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 82 - missing a p in front of pay-per-use

@VictoriaExpensify
Copy link
Contributor Author

Line 82 - missing a p in front of pay-per-use

Fixed!

Copy link
Contributor

@jliexpensify jliexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stephanieelliott stephanieelliott merged commit 32c29c2 into main Jan 21, 2026
12 of 15 checks passed
@stephanieelliott stephanieelliott deleted the VictoriaExpensify-patch-6 branch January 21, 2026 00:35
@melvin-bot melvin-bot bot added the Emergency label Jan 21, 2026
@melvin-bot
Copy link

melvin-bot bot commented Jan 21, 2026

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.6-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants