-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Update billing details and remove optional card mention #79848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Article incorrectly referrenced the Expensify Card for non-US users
HelpDot Documentation ReviewOverall AssessmentThis PR corrects inaccurate information about Expensify Card availability for non-US users in the Billing Overview documentation. The changes appropriately remove references to card-based pricing and cash back options from GBP, EUR, AUD, and NZD currency sections, while maintaining these details for USD. The corrections improve accuracy and prevent user confusion. Scores Summary
Key FindingsPositive Aspects:
Issues Identified:
Content Accuracy:
RecommendationsMust Fix:
Should Consider:
Files Reviewed
Note: This is a summary assessment. The primary action required is fixing the typo on line 83. |
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-Overview.md
Show resolved
Hide resolved
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://556733a5.helpdot.pages.dev ⚡️ Updated articles: |
Removed mention of optional Expensify Card from billing overview.
jliexpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 82 - missing a p in front of pay-per-use
Fixed! |
jliexpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.6-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀
|
Article incorrectly referrenced the Expensify Card for non-US users
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari