Skip to content

Conversation

@stephanieelliott
Copy link
Contributor

@stephanieelliott stephanieelliott commented Jan 19, 2026

For https://github.com/Expensify/Expensify/issues/588714#issuecomment-3752663429

I've ported account access troubleshooting to a new article, will cross link that to this once created

@stephanieelliott stephanieelliott self-assigned this Jan 19, 2026
@github-actions github-actions bot changed the title Update Two-Factor-Authentication.md [No QA] Update Two-Factor-Authentication.md Jan 19, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Jan 19, 2026

A preview of your ExpensifyHelp changes have been deployed to https://70b1240d.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott marked this pull request as ready for review January 19, 2026 05:51
@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR restructures the Two-Factor Authentication documentation for both Expensify Classic and New Expensify. While the changes improve user orientation by organizing content around specific use cases (setup, admin reset, lockout recovery), there are several issues that need attention including broken links, inconsistent terminology, formatting errors, and content that undermines the previous structure improvements.

Scores Summary

  • Readability: 6/10 - Clear task-oriented structure, but contains awkward phrasing, broken links, and formatting inconsistencies that hinder comprehension.
  • AI Readiness: 5/10 - New headings lack searchable keywords, section organization is inconsistent, and missing context makes content difficult to parse independently.
  • Style Compliance: 5/10 - Inconsistent terminology (user vs member), unclear button labels, missing proper Markdown spacing, and FAQ structure doesn't follow standards.

Key Findings

Critical Issues:

  1. Broken Links: Both files reference "Troubleshoot login issues (LINK)" - placeholder links that must be replaced before merge
  2. YAML Syntax Error: New Expensify file has malformed keywords array (missing closing bracket)
  3. Wrong Product Reference: New Expensify file header says "Who can use Two-Factor Authentication in Expensify Classic" instead of "New Expensify"
  4. Platform-Specific Instruction: New Expensify article instructs users to switch to Expensify Classic for admin resets - creates confusion about feature availability

Structural Concerns:

  1. Removed the clear "Recommended Authenticator Apps" standalone section and buried it in FAQ - less discoverable
  2. New headings lack descriptive keywords ("How to enable" vs previous "Enable Two-Factor Authentication")
  3. Inconsistent heading hierarchy mixing task-based and role-based organization
  4. Removed helpful "Best practices" section from New Expensify version

Terminology & Style Issues:

  1. Inconsistent use of "member" vs "user" (line 59 Classic uses "user", elsewhere uses "member")
  2. Inconsistent button label format ("Click" vs "Select", mixed throughout)
  3. Inconsistent code formatting ("Copy" vs Copy)
  4. Missing blank lines between sections in several places

Content Quality:

  1. FAQ answers are too brief and lack context
  2. Removed specific troubleshooting guidance (device time settings, multiple logins)
  3. New Expensify article lost valuable content about recovery options and best practices

Recommendations

Must Fix Before Merge:

  1. Replace "(LINK)" placeholders with actual URLs for troubleshooting guide
  2. Fix YAML syntax error in New Expensify keywords array (add closing bracket)
  3. Correct product reference: Change "Expensify Classic" to "New Expensify" in line 11 of new-expensify version
  4. Remove or clarify the platform-switching instruction - either make admin reset work in New Expensify UI or explain why Classic is required

High Priority:

  1. Restore "Recommended Authenticator Apps" as a prominent H1 section before setup instructions
  2. Standardize button terminology: Use either "Click" or "Select" consistently (prefer "Select" for Expensify style)
  3. Add descriptive keywords to headings: "How to enable Two-Factor Authentication on your account" → "Enable Two-Factor Authentication on your account"
  4. Fix terminology: Use "member" consistently for domain members, "user" for general account holders
  5. Restore removed troubleshooting content (clock sync, multiple device login issues)
  6. Add back "Best practices" section to New Expensify version

Medium Priority:

  1. Expand FAQ answers with more context and examples
  2. Ensure consistent Markdown formatting (blank lines between sections, consistent bold/code formatting)
  3. Verify keywords in YAML match actual article content
  4. Consider reorganizing FAQ to group related questions

Nice to Have:

  1. Add more specific navigation paths (full breadcrumb) in procedural steps
  2. Include expected outcomes/confirmation messages after key actions
  3. Cross-reference between Classic and New Expensify versions where appropriate

Files Reviewed

  1. docs/articles/expensify-classic/settings/Two-Factor-Authentication.md - Restructured with issues (broken links, terminology inconsistencies, removed useful content)
  2. docs/articles/new-expensify/settings/Two-Factor-Authentication.md - Major issues (YAML error, wrong product name, platform confusion, removed best practices)

Note: The restructuring effort toward task-based organization is positive, but execution needs refinement. The previous version had clearer information hierarchy and more complete content.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5c39be9a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@VictoriaExpensify VictoriaExpensify merged commit 3f086a1 into main Jan 21, 2026
12 of 13 checks passed
@VictoriaExpensify VictoriaExpensify deleted the stephanieelliott-patch-27 branch January 21, 2026 02:41
@melvin-bot melvin-bot bot added the Emergency label Jan 21, 2026
@melvin-bot
Copy link

melvin-bot bot commented Jan 21, 2026

@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.3.6-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants