-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Update Two-Factor-Authentication.md #79853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://70b1240d.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR restructures the Two-Factor Authentication documentation for both Expensify Classic and New Expensify. While the changes improve user orientation by organizing content around specific use cases (setup, admin reset, lockout recovery), there are several issues that need attention including broken links, inconsistent terminology, formatting errors, and content that undermines the previous structure improvements. Scores Summary
Key FindingsCritical Issues:
Structural Concerns:
Terminology & Style Issues:
Content Quality:
RecommendationsMust Fix Before Merge:
High Priority:
Medium Priority:
Nice to Have:
Files Reviewed
Note: The restructuring effort toward task-based organization is positive, but execution needs refinement. The previous version had clearer information hierarchy and more complete content. |
docs/articles/expensify-classic/settings/Two-Factor-Authentication.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/settings/Two-Factor-Authentication.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/settings/Two-Factor-Authentication.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/settings/Two-Factor-Authentication.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/settings/Two-Factor-Authentication.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/settings/Two-Factor-Authentication.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5c39be9a9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
docs/articles/new-expensify/settings/Two-Factor-Authentication.md
Outdated
Show resolved
Hide resolved
|
@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.3.6-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀
|
For https://github.com/Expensify/Expensify/issues/588714#issuecomment-3752663429
I've ported account access troubleshooting to a new article, will cross link that to this once created