Skip to content

Conversation

@stephanieelliott
Copy link
Contributor

Explanation of Change

Update redirects file for in-product url that links to dead community page

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/590501
PROPOSAL: N/A

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

Explanation of Change

Fixed Issues

Tests

Precondition: User have an expense moved from one report to other

  1. Go to the Reports > Expense page
  2. Open an expense and scroll to its report history
  3. Click on the report link from the moved this expense thread
  4. The report should open in the reports page.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-09-23.at.12.41.27.AM.mov
Android: mWeb Chrome
Screen.Recording.2025-09-23.at.12.46.46.AM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-23.at.00.50.53.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-23.at.00.54.06.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-10-10.at.1.17.17.AM.mov
Screen.Recording.2025-09-23.at.12.27.18.AM.mov
MacOS: Desktop
Screen.Recording.2025-09-23.at.12.52.20.AM.mov

@stephanieelliott stephanieelliott self-assigned this Jan 20, 2026
@stephanieelliott stephanieelliott requested a review from a team as a code owner January 20, 2026 22:36
@melvin-bot melvin-bot bot requested a review from sobitneupane January 20, 2026 22:36
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2026

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@melvin-bot melvin-bot bot removed the request for review from a team January 20, 2026 22:36
@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single redirect entry to docs/redirects.csv, mapping a deprecated Expensify Community discussion URL about approval workflows to the current Expensify Classic help article. This is a maintenance task to fix a dead link in the product.

Change Summary:

  • Files Modified: 1 (docs/redirects.csv)
  • Lines Changed: +1 addition
  • Type: Redirect mapping update

Scores Summary

  • Readability: N/A - This is a CSV redirect entry, not prose documentation
  • AI Readiness: N/A - Redirect mappings do not require AI optimization
  • Style Compliance: 10/10 - Perfect adherence to redirect file formatting standards

Key Findings

Positive Aspects:

  • The redirect follows the exact format of existing entries in the file
  • The mapping is logical: old community discussion → current help article on the same topic
  • The source URL includes the trailing slash convention used elsewhere in the file
  • The target URL follows the standard Expensify Classic help article URL structure
  • No syntax errors or formatting issues

Technical Validation:

  • Source: https://community.expensify.com/discussion/5700/deep-dive-approval-workflow-overview/
  • Target: https://help.expensify.com/articles/expensify-classic/reports/Create-a-report-approval-workflow
  • Format: Correct CSV structure (source,target)
  • Placement: Appropriately added at end of file

Recommendations

Approval Status:Ready to Merge

This is a straightforward redirect update with no issues identified. The change:

  1. Follows existing conventions perfectly
  2. Addresses the stated issue of fixing a dead community page link
  3. Redirects to an appropriate replacement resource
  4. Maintains file integrity and formatting

No action items required. This PR is technically sound and ready for deployment.

Files Reviewed

  • docs/redirects.csv - Single redirect entry added with proper formatting

This review assessed the technical accuracy and formatting compliance of the redirect entry. No inline comments were necessary as the change is a single-line addition that follows all conventions correctly.

@github-actions github-actions bot changed the title [NO QA] Update redirects.csv for Approval Workflows [No QA] [NO QA] Update redirects.csv for Approval Workflows Jan 20, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Jan 20, 2026

A preview of your ExpensifyHelp changes have been deployed to https://9384a3d1.helpdot.pages.dev ⚡️

@stephanieelliott stephanieelliott changed the title [No QA] [NO QA] Update redirects.csv for Approval Workflows [No QA] [NO QA] Update redirects.csv for broken in-product links Jan 21, 2026
@stephanieelliott stephanieelliott changed the title [No QA] [NO QA] Update redirects.csv for broken in-product links [NO QA] Update redirects.csv for broken in-product links Jan 21, 2026
@github-actions github-actions bot changed the title [NO QA] Update redirects.csv for broken in-product links [No QA] [NO QA] Update redirects.csv for broken in-product links Jan 21, 2026
@stephanieelliott stephanieelliott changed the title [No QA] [NO QA] Update redirects.csv for broken in-product links [NO QA] Update redirects.csv for broken in-product links Jan 22, 2026
@github-actions github-actions bot changed the title [NO QA] Update redirects.csv for broken in-product links [No QA] [NO QA] Update redirects.csv for broken in-product links Jan 22, 2026
@stephanieelliott stephanieelliott requested review from VictoriaExpensify and removed request for sobitneupane January 22, 2026 02:13
@VictoriaExpensify VictoriaExpensify merged commit 9fd2604 into main Jan 22, 2026
12 of 13 checks passed
@VictoriaExpensify VictoriaExpensify deleted the stephanieelliott-patch-26 branch January 22, 2026 02:21
@melvin-bot melvin-bot bot added the Emergency label Jan 22, 2026
@melvin-bot
Copy link

melvin-bot bot commented Jan 22, 2026

@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.3.7-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants