-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] [NO QA] Update redirects.csv for broken in-product links #80040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single redirect entry to Change Summary:
Scores Summary
Key FindingsPositive Aspects:
Technical Validation:
RecommendationsApproval Status: ✅ Ready to Merge This is a straightforward redirect update with no issues identified. The change:
No action items required. This PR is technically sound and ready for deployment. Files Reviewed
This review assessed the technical accuracy and formatting compliance of the redirect entry. No inline comments were necessary as the change is a single-line addition that follows all conventions correctly. |
|
A preview of your ExpensifyHelp changes have been deployed to https://9384a3d1.helpdot.pages.dev ⚡️ |
|
@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.3.7-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀
|
Explanation of Change
Update redirects file for in-product url that links to dead community page
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/590501
PROPOSAL: N/A
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Explanation of Change
Fixed Issues
Tests
Precondition: User have an expense moved from one report to other
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-09-23.at.12.41.27.AM.mov
Android: mWeb Chrome
Screen.Recording.2025-09-23.at.12.46.46.AM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-23.at.00.50.53.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-23.at.00.54.06.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-10-10.at.1.17.17.AM.mov
Screen.Recording.2025-09-23.at.12.27.18.AM.mov
MacOS: Desktop
Screen.Recording.2025-09-23.at.12.52.20.AM.mov