chore: Upgrade @fullstory/react-native to latest#80093
chore: Upgrade @fullstory/react-native to latest#80093TaduJR wants to merge 1 commit intoExpensify:mainfrom
Conversation
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Then what to test with this account? Do you have screen recording of test result on this? |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@TaduJR any update? |
Hi @mkhutornyi Sorry for the delay. Will provide update tomorrow Thanks! |
FullStory only initializes in production or with a special test email (fullstory-*@expensify.com.qa) in staging/dev. App/src/libs/Fullstory/common.ts Lines 67 to 74 in 4ab4ccd So For this PR, since the main verification is that the package upgrade doesn't cause crashes or regressions we just need to navigate on the pages and check that the upgrade doesn't problems Updated the Test Steps, and adding demos now. |
I think applause.expensifail.com can only be used by the QA team, so we can not start the fullystory record, QA can check the tests. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
@TaduJR please merge main.
Screenshots are still missing |
bc38f06 to
d6549c9
Compare
Done.
@mkhutornyi As I stated in this comment #80093 (comment) only QA has access to the fullstory session in staging, and applause.expensifail.com domain is need to start the fullstory session, so only QA can test this. |
@TaduJR this is what you said and this test doesn't need access to fullstory. |
|
Job 7 failing |
Not related it being handled here #81546 |
@mkhutornyi Yes, the upgrade is fullstory right and fullstory only starts with QA domain or in production. So to test it QA can only do it in staging environment. |
Explanation of Change
This PR upgrades
@fullstory/react-nativefrom version1.7.8to1.8.0and implements additional improvements to better utilize the FullStory SDK.Fixed Issues
$ #79774
PROPOSAL: #79774 (comment)
Tests
Prerequisite : FullStory only records in production or staging/dev with test emails (
fullstory-*@expensify.com.qa). These tests verify the package upgrade doesn't cause regressions.Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari