-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: pass transaction data for unreported expenses #80120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass transaction data for unreported expenses #80120
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-20.at.15.10.51.movAndroid: mWeb ChromeScreen.Recording.2026-01-20.at.15.18.46.moviOS: HybridAppScreen.Recording.2026-01-20.at.15.00.06.moviOS: mWeb SafariScreen.Recording.2026-01-20.at.14.44.54.movMacOS: Chrome / SafariScreen.Recording.2026-01-20.at.14.38.04.mov |
|
@puneetlath All yours 👍 |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Product review not required.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.7-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀
|
Explanation of Change
Problem
Opening a scan expense in NewDot after unreporting in OldDot showed "it's not here" page because:
Solution
Pass transaction data when !reportActionID OR isFromSelfDM
Pass full reportAction object instead of just {reportActionID}
Fixed Issues
$ #78770
PROPOSAL: #78770 (comment)
Tests
Prerequisites:
Offline tests
N/A - This fix addresses navigation logic, not network-dependent behavior.
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-21.at.8.26.16.PM.mp4
Android: mWeb Chrome
Screen.Recording.2026-01-21.at.8.33.43.PM.mp4
iOS: Native
Screen.Recording.2026-01-21.at.8.07.16.PM.mp4
iOS: mWeb Safari
Screen.Recording.2026-01-21.at.8.10.00.PM.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-01-21.at.7.53.00.PM.mp4