Update Say hello! to Ask me anything! in Conceirge in all languages
#80172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
melvin-bot
bot
requested review from
heyjennahay
and removed request for
a team
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
linhvovan29546
suggested changes
Jan 22, 2026
src/languages/fr.ts
Outdated
| beginningOfChatHistorySystemDM: 'Bienvenue ! Commençons votre configuration.', | ||
| chatWithAccountManager: 'Discutez avec votre gestionnaire de compte ici', | ||
| sayHello: 'Dites bonjour !', | ||
| askMeAnything: 'Demande-moi n’importe quoi !', |
Contributor
There was a problem hiding this comment.
Did you confirm the translation on the Slack open-source channel?
Contributor
There was a problem hiding this comment.
For non-Spanish languages, this is the process, not Slack: #80172 (comment)
Contributor
There was a problem hiding this comment.
I commented in the wrong place (I remember adding it in the es file)😅
Contributor
Author
There was a problem hiding this comment.
@linhvovan29546 Okay, so i think according to the new generated translation script, we need to only to do changes in fr.ts, nl.ts , pl.ts and zh-hans.ts.
src/components/ReportWelcomeText.tsx
Outdated
| const reportDetailsLink = report?.reportID ? `${environmentURL}/${ROUTES.REPORT_WITH_ID_DETAILS.getRoute(report.reportID, Navigation.getReportRHPActiveRoute())}` : ''; | ||
|
|
||
| let welcomeHeroText = translate('reportActionsView.sayHello'); | ||
| let welcomeHeroText = translate('reportActionsView.askMeAnything'); |
Contributor
There was a problem hiding this comment.
In an empty Concierge chat, the prompt text should read "Ask me anything!" instead of "Say hello!".
I think we only want to change the text for the Concierge chat. cc @thienlnam Could you please help confirm?
Contributor
|
Running the translations script on this PR, which is the process for the wider language translations. |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 717400cd..10539c52 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -912,7 +912,7 @@ const translations: TranslationDeepObject<typeof en> = {
beginningOfChatHistorySelfDM: 'Ceci est votre espace personnel. Utilisez-le pour vos notes, tâches, brouillons et rappels.',
beginningOfChatHistorySystemDM: 'Bienvenue ! Commençons votre configuration.',
chatWithAccountManager: 'Discutez avec votre gestionnaire de compte ici',
- askMeAnything: 'Demande-moi n’importe quoi !',
+ askMeAnything: 'Posez-moi toutes vos questions !',
yourSpace: 'Votre espace',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Bienvenue dans ${roomName} !`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Utilisez le bouton + pour ${additionalText} une dépense.`,
@@ -973,7 +973,7 @@ const translations: TranslationDeepObject<typeof en> = {
buttonMySettings: 'Mes paramètres',
fabNewChat: 'Démarrer le chat',
fabNewChatExplained: 'Démarrer le chat (Action flottante)',
- fabScanReceiptExplained: 'Scanner un reçu (Action flottante)',
+ fabScanReceiptExplained: 'Scanner le reçu (action flottante)',
chatPinned: 'Discussion épinglée',
draftedMessage: 'Message rédigé',
listOfChatMessages: 'Liste des messages de discussion',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index c406434f..fe179900 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -969,8 +969,8 @@ const translations: TranslationDeepObject<typeof en> = {
buttonFind: 'Trova qualcosa...',
buttonMySettings: 'Le mie impostazioni',
fabNewChat: 'Avvia chat',
- fabNewChatExplained: 'Avvia chat (Azione flottante)',
- fabScanReceiptExplained: 'Scansiona ricevuta (Azione flottante)',
+ fabNewChatExplained: 'Avvia chat (Azione fluttuante)',
+ fabScanReceiptExplained: 'Scansiona ricevuta (Azione rapida)',
chatPinned: 'Chat fissata',
draftedMessage: 'Messaggio in bozza',
listOfChatMessages: 'Elenco dei messaggi della chat',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 79a57c83..cea7c87c 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -968,7 +968,7 @@ const translations: TranslationDeepObject<typeof en> = {
buttonFind: '何かを検索…',
buttonMySettings: 'マイ設定',
fabNewChat: 'チャットを開始',
- fabNewChatExplained: 'チャットを開始 (フローティングアクション)',
+ fabNewChatExplained: 'チャット開始（フローティングアクション）',
fabScanReceiptExplained: '領収書をスキャン',
chatPinned: 'ピン留めされたチャット',
draftedMessage: '下書きメッセージ',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 38019ef4..40936147 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -909,7 +909,7 @@ const translations: TranslationDeepObject<typeof en> = {
beginningOfChatHistorySelfDM: 'Dit is je persoonlijke ruimte. Gebruik het voor notities, taken, concepten en herinneringen.',
beginningOfChatHistorySystemDM: 'Welkom! Laten we je instellen.',
chatWithAccountManager: 'Chat hier met je accountmanager',
- askMeAnything: 'Vraag me alles!',
+ askMeAnything: 'Vraag mij wat je maar wilt!',
yourSpace: 'Je ruimte',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Welkom bij ${roomName}!`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Gebruik de knop + om een uitgave te ${additionalText}.`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index f4e463e6..007dc27a 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -908,7 +908,7 @@ const translations: TranslationDeepObject<typeof en> = {
beginningOfChatHistorySelfDM: 'To jest Twoja osobista przestrzeń. Używaj jej do notatek, zadań, szkiców i przypomnień.',
beginningOfChatHistorySystemDM: 'Witamy! Skonfigurujmy wszystko.',
chatWithAccountManager: 'Czat z Twoim opiekunem klienta tutaj',
- askMeAnything: 'Zapytaj mnie o wszystko!',
+ askMeAnything: 'Zapytaj mnie o cokolwiek!',
yourSpace: 'Twoja przestrzeń',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Witamy w ${roomName}!`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Użyj przycisku +, aby ${additionalText} wydatek.`,
@@ -969,7 +969,7 @@ const translations: TranslationDeepObject<typeof en> = {
buttonFind: 'Znajdź coś...',
buttonMySettings: 'Moje ustawienia',
fabNewChat: 'Rozpocznij czat',
- fabNewChatExplained: 'Rozpocznij czat (Akcja pływająca)',
+ fabNewChatExplained: 'Rozpocznij czat (Przycisk unoszący się)',
fabScanReceiptExplained: 'Zeskanuj paragon (Akcja pływająca)',
chatPinned: 'Czat przypięty',
draftedMessage: 'Wiadomość robocza',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index b9ee8347..b07be4e6 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -969,7 +969,7 @@ const translations: TranslationDeepObject<typeof en> = {
buttonMySettings: 'Minhas configurações',
fabNewChat: 'Iniciar chat',
fabNewChatExplained: 'Iniciar chat (Ação flutuante)',
- fabScanReceiptExplained: 'Digitalizar recibo (Ação flutuante)',
+ fabScanReceiptExplained: 'Escanear recibo (Ação flutuante)',
chatPinned: 'Conversa fixada',
draftedMessage: 'Mensagem rascunhada',
listOfChatMessages: 'Lista de mensagens de chat',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index eaa44511..c2909261 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -900,7 +900,7 @@ const translations: TranslationDeepObject<typeof en> = {
beginningOfChatHistorySelfDM: '这是你的个人空间。可用于记录笔记、任务、草稿和提醒。',
beginningOfChatHistorySystemDM: '欢迎！我们来为你完成设置。',
chatWithAccountManager: '在这里与您的客户经理聊天',
- askMeAnything: '随便问我任何问题！',
+ askMeAnything: '问我任何问题！',
yourSpace: '您的空间',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `欢迎来到 ${roomName}！`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `使用“+”按钮来${additionalText}一笔报销。`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
Author
|
@linhvovan29546 Made the changes, I think PR is ready for merge. Please verify the translations once again if they are correct .... cc: @thienlnam |
Contributor
@PiyushChandra17 I don’t think this is ready yet. You need to confirm the Spanish translation on Slack as mentioned here, and we only need to update the Concierge chat (you’ve updated all chats) #80172 (comment). |
Contributor
Author
@linhvovan29546 Yes, awaiting confirmation on this
Okay, looking into this .. 👀 |
Contributor
Author
|
@linhvovan29546 Done, can you please review once again? Thanks! |
Contributor
@PiyushChandra17 Are you in the Slack |
linhvovan29546
suggested changes
Jan 27, 2026
src/components/ReportWelcomeText.tsx
Outdated
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
| const [reportMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report?.reportID || undefined}`, {canBeMissing: true}); | ||
| const isReportArchived = useReportIsArchived(report?.reportID); | ||
| const isConciergeChat = isConciergeChatReport(report); |
Contributor
There was a problem hiding this comment.
Suggested change
| const isConciergeChat = isConciergeChatReport(report); | |
| const [conciergeReportID] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID, {canBeMissing: true}); | |
| const isConciergeChat = isConciergeChatReport(report, conciergeReportID); |
src/components/ReportWelcomeText.tsx
Outdated
| if (isConciergeChat) { | ||
| welcomeHeroText = translate('reportActionsView.askMeAnything'); | ||
| } | ||
| if (isInvoiceRoom) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isInvoiceRoom) { | |
| else if (isInvoiceRoom) { |
Contributor
Author
@linhvovan29546 I think there is some glitches and it's been worked-on as far as my cc: @trjExpensify |
Contributor
|
@PiyushChandra17 I mean this channel. Do you have access to it? If not, I'll ask for confirmation |
Contributor
Author
As of now, No .. |
Contributor
|
Asking confirmation here |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
|
Contributor
Author
Hi @linhvovan29546 Did you get the conformation? |
linhvovan29546
approved these changes
Jan 28, 2026
Contributor
linhvovan29546
left a comment
linhvovan29546
left a comment
There was a problem hiding this comment.
@thienlnam All yours!
thienlnam
approved these changes
Jan 28, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.3.11-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Update
Say hello!toAsk me anything!in Conceirge in all languagesFixed Issues
$ #80016
PROPOSAL: #80016(Comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari