Fix split input and show a warning when the split total exceeds the original transaction #80188

tsa321 · 2026-01-22T05:51:43Z

Explanation of Change

Fixed Issues

$ #78092
PROPOSAL: #78092 (comment)

Tests

Test steps:

Open an expense report.
Click More → Split.
Go to the Amount tab.
Verify the amount text input is left-aligned.
Enter a long number into the amount text input.
Verify the text does not wrap to a second line (the input remains single-line; on iOS, ellipsis … is shown).
Fill both split amounts so the total is less than the original amount.
Verify a warning indicating the total amount is less than the original is displayed at the bottom.
Go to the Percentage tab.
Verify the text input is left-aligned.
Verify the text input width is larger than before and can contain at least 4 characters.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test steps:

Open an expense report.
Click More → Split.
Go to the Amount tab.
Verify the amount text input is left-aligned.
Enter a long number into the amount text input.
Verify the text does not wrap to a second line (the input remains single-line; on iOS, ellipsis … is shown).
Fill both split amounts so the total is less than the original amount.
Verify a warning indicating the total amount is less than the original is displayed at the bottom.
Go to the Percentage tab.
Verify the text input is left-aligned.
Verify the text input width is larger than before and can contain at least 4 characters.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native_d.mp4

Android: mWeb Chrome

android_mweb_d.mp4

iOS: Native

ios_native_d.mp4

iOS: mWeb Safari

ios_msafari_d.mp4

MacOS: Chrome / Safari

macos_web_d.mp4

…s the original transaction Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

melvin-bot · 2026-01-22T05:51:50Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tsa321 · 2026-01-22T05:54:17Z

src/styles/index.ts

-        optionRowAmountMobileInputContainer: {
-            width: variables.splitExpenseAmountMobileWidth,
-        },


I am removing this because it is not used anywhere.

tsa321 · 2026-01-22T05:55:08Z

src/styles/variables.ts

    reportSearchHeaderMaxWidth: 700,

-    // Split expense tabs
-    splitExpenseAmountMobileWidth: 82,


I am removing this because it is not used anywhere.

src/styles/index.ts

tsa321 · 2026-01-22T05:56:49Z

src/styles/variables.ts

-    splitExpensePercentageWidth: 42,
-    splitExpensePercentageMobileWidth: 62,


Directly set the width in the optionRowPercentInputContainer style.

codecov · 2026-01-22T06:00:43Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/styles/index.ts	`46.85% <ø> (ø)`
src/styles/variables.ts	`100.00% <ø> (ø)`
...onList/ListItem/SplitListItem/SplitAmountInput.tsx	`0.00% <0.00%> (ø)`
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`
... and 192 files with indirect coverage changes

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2026-01-22T06:11:52Z

There is a bug in main: the split amount text input width is too small when the split expense page first opens, and then becomes the correct size after the data loads:

tsa321 · 2026-01-22T06:39:07Z

@ShridharGoel PR is ready

ShridharGoel · 2026-01-22T17:09:42Z

src/styles/index.ts

-
        optionRowPercentInputContainer: {
-            width: variables.splitExpensePercentageMobileWidth,
+            width: 66, // Width of the split expense percentage text input container. It should not be too wide or too narrow.


Let's move it to src/styles/variables.ts.

@ShridharGoel I’ve moved this to variables.

ShridharGoel · 2026-01-22T17:12:09Z

src/styles/index.ts

        },

-        optionRowAmountMobileInputContainer: {
-            width: variables.splitExpenseAmountMobileWidth,


Why are we changing this?

optionRowAmountMobileInputContainer is not used anywhere in the codebase, so I’m removing it to avoid confusion.

ShridharGoel · 2026-01-22T17:12:38Z

src/styles/index.ts

@@ -1266,17 +1266,11 @@ const staticStyles = (theme: ThemeColors) =>
            textAlign: 'right',


Do we not need to change this?

optionRowAmountInput is also used by other files, so we can’t change it.
I’m removing optionRowAmountInput from the SplitAmountInput styles instead.

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

ShridharGoel · 2026-01-24T09:19:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-24.at.3.11.23.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-01-24.at.3.09.35.PM.mov

iOS: HybridApp

Screen.Recording.2026-01-24.at.2.48.30.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-01-24.at.2.52.20.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-24.at.2.51.40.PM.mov

OSBotify · 2026-01-28T21:45:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-28T23:21:34Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

tsa321 added 4 commits January 22, 2026 10:33

Fix split amount input and show a warning when the split total exceed…

2710852

…s the original transaction Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Fix eslint warning

a229cd7

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Merge branch 'main' into fixSplitInput

d77e99e

Adjust percentage input wide

ed1bf51

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested review from a team as code owners January 22, 2026 05:51

melvin-bot bot assigned tsa321 Jan 22, 2026

melvin-bot bot requested review from ShridharGoel and heyjennahay January 22, 2026 05:51

melvin-bot bot removed request for a team and heyjennahay January 22, 2026 05:51

tsa321 commented Jan 22, 2026

View reviewed changes

github-actions bot reviewed Jan 22, 2026

View reviewed changes

src/styles/index.ts Outdated Show resolved Hide resolved

tsa321 commented Jan 22, 2026

View reviewed changes

Add comment

7750ec9

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

ShridharGoel reviewed Jan 22, 2026

View reviewed changes

Move width to variables

3f17f4d

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

ShridharGoel approved these changes Jan 24, 2026

View reviewed changes

melvin-bot bot requested a review from puneetlath January 24, 2026 09:51

puneetlath approved these changes Jan 28, 2026

View reviewed changes

puneetlath merged commit a478279 into Expensify:main Jan 28, 2026
30 of 31 checks passed

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Open

		splitExpensePercentageWidth: 42,
		splitExpensePercentageMobileWidth: 62,

		@@ -1266,17 +1266,11 @@ const staticStyles = (theme: ThemeColors) =>
		textAlign: 'right',

Fix split input and show a warning when the split total exceeds the original transaction #80188

Fix split input and show a warning when the split total exceeds the original transaction #80188

Conversation

tsa321 commented Jan 22, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 22, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tsa321 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsa321 commented Jan 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 22, 2026 •

edited by github-actions bot

Loading

tsa321 commented Jan 22, 2026 •

edited

Loading

ShridharGoel commented Jan 24, 2026 •

edited

Loading