refactor getMemberInviteOptions #80201
Merged
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
DylanDylann and
heyjennahay
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/pages/RoomInvitePage.tsx
Outdated
| const [userSearchPhrase] = useOnyx(ONYXKEYS.ROOM_MEMBERS_USER_SEARCH_PHRASE, {canBeMissing: true}); | ||
| const [countryCode = CONST.DEFAULT_COUNTRY_CODE] = useOnyx(ONYXKEYS.COUNTRY_CODE, {canBeMissing: false}); | ||
| const [loginList] = useOnyx(ONYXKEYS.LOGIN_LIST, {canBeMissing: true}); | ||
| const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true}); |
Contributor
There was a problem hiding this comment.
❌ PERF-11 (docs)
Fetching the entire policy collection without a selector causes unnecessary re-renders. Since getMemberInviteOptions passes reports: [] to getValidOptions, the policies are never actually used in this code path, but the component will still re-render whenever any policy in the collection changes.
Suggested fix: If policies are not needed for this use case, pass undefined instead. If they might be needed in the future, add a selector to fetch only the required fields:
const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {
canBeMissing: true,
selector: (policies) => {
// Return only the fields actually needed by getMemberInviteOptions
// Or return undefined if not needed at all
if (!policies) return undefined;
// Example: return specific policy fields if needed
},
});Alternatively, if the policies are truly not used, consider passing undefined to avoid the subscription entirely.\n\n---\n\nPlease rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…stead of allPolicies
dukenv0307
force-pushed
the
fix/66377-part-6
branch
from
9af3cf6 to
b1263a0
Compare
Contributor
Author
|
@DylanDylann in getMemberInviteOptions we passed includeRecentReports: false, so |
heyjennahay
reviewed
Jan 26, 2026
Contributor
heyjennahay
left a comment
heyjennahay
left a comment
There was a problem hiding this comment.
Product review not required
DylanDylann
reviewed
Jan 27, 2026
tests/unit/OptionsListUtilsTest.tsx
Outdated
Comment on lines
1431
to
1442
| it('should return personal details with expected structure', () => { | ||
| // Given a set of personalDetails | ||
| // When we call getMemberInviteOptions | ||
| const results = getMemberInviteOptions(OPTIONS.personalDetails, nvpDismissedProductTraining, loginList, [CONST.BETAS.ALL]); | ||
|
|
||
| // Then personal details should be returned | ||
| expect(results.personalDetails.length).toBeGreaterThan(0); | ||
|
|
||
| // Then the results should contain expected structure | ||
| expect(results.recentReports).toEqual([]); | ||
| expect(results.currentUserOption).toBeUndefined(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Please integrate this case into the existing one.
Comment on lines
1444
to
1454
| it('should exclude logins when excludeLogins is provided', () => { | ||
| // Given a set of personalDetails and excludeLogins | ||
| const excludeLogins = {'reedrichards@expensify.com': true}; | ||
|
|
||
| // When we call getMemberInviteOptions with excludeLogins | ||
| const results = getMemberInviteOptions(OPTIONS.personalDetails, nvpDismissedProductTraining, loginList, [], excludeLogins); | ||
|
|
||
| // Then the excluded login should not be in the results | ||
| const excludedUser = results.personalDetails.find((detail) => detail.login === 'reedrichards@expensify.com'); | ||
| expect(excludedUser).toBeUndefined(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Please integrate this case into the existing one.
Contributor
Author
There was a problem hiding this comment.
I still think we should keep it separately because in this case, we have excludedUser
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-01-27.at.15.25.05.mov |
Contributor
|
@dukenv0307 Minor comments on new test case. The rest looks good |
DylanDylann
approved these changes
Jan 28, 2026
Contributor
Author
|
@DylanDylann Done |
danieldoglas
approved these changes
Jan 29, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.3.11-16 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #66377
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-22.at.16.34.11.mov