Revert "fix: Self DM appears twice in Recents section"

[blimpich]

context: https://expensify.slack.com/archives/C01GTK53T8Q/p1769106437797199

Reverts #79640

[melvin-bot]

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[blimpich]

Not emergency, straight revert to fix broken type check

[chatgpt-codex-connector]

💡 Codex Review

App/src/libs/actions/IOU/index.ts

Lines 3746 to 3750 in a5a9279

	optimisticData.push(
	{
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.REPORT}${optimisticReportID}`,
	value: {

Keep SELF_DM_REPORT_ID in sync when creating self DM

This block creates a new optimistic self‑DM report but no longer updates ONYXKEYS.SELF_DM_REPORT_ID; since findSelfDMReportID() returns the cached value without validating it (ReportUtils.ts around 1903‑1905), any stale cached ID (e.g., from persisted Onyx after the report was removed/filtered) will keep being used and the newly created report is ignored. That can lead to repeated creation of additional self‑DM reports or lookups against a non‑existent report ID (e.g., convertBulkTrackedExpensesToIOU relies on findSelfDMReportID and then fetches actions by that ID), which manifests as duplicate self‑DM entries in Recents or missing tracked‑expense actions. Consider restoring the merge of SELF_DM_REPORT_ID when a new self‑DM report is created.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌