-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Create and update Automatic Report Submissions docs #80296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://dadfe313.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@rlinoz @twisterdotcom One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
docs/articles/expensify-classic/reports/Automatically-submit-employee-reports.md
Show resolved
Hide resolved
docs/articles/expensify-classic/reports/Automatically-submit-employee-reports.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/reports/Automatically-submit-employee-reports.md
Show resolved
Hide resolved
docs/articles/expensify-classic/reports/Automatically-submit-employee-reports.md
Show resolved
Hide resolved
docs/articles/expensify-classic/reports/Automatically-submit-employee-reports.md
Show resolved
Hide resolved
docs/articles/expensify-classic/reports/Automatically-submit-employee-reports.md
Show resolved
Hide resolved
docs/articles/expensify-classic/reports/Automatically-submit-employee-reports.md
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR creates comprehensive documentation for automatic report submissions across both Expensify Classic and New Expensify platforms. The documentation demonstrates strong improvements in clarity, structure, and user guidance. The addition of the Scores Summary
Key FindingsStrengths:
Areas for Improvement:
Critical Issues:
RecommendationsHigh Priority:
Medium Priority: Low Priority: Files Reviewed
Overall Recommendation: Approve after addressing the stray text on line 46. This is high-quality documentation that significantly improves upon the previous version. The structural improvements and expanded FAQ section will greatly benefit users and AI search capabilities. |
|
Happy to merge this once the suggestions are resolved @stephanieelliott |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.3.11-0 🚀
|
Slack conv: https://expensify.slack.com/archives/C02QSAC6BJ8/p1768586868142379
GH issue for images: https://github.com/Expensify/Expensify/issues/591868
Article incorrectly referrenced the Expensify Card for non-US users
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari